<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>No - no problem at all. Some extra exception handling but
probably best for the long run.</p>
<p><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~coffeys/webrev.8208583.v3/webrev/index.html">http://cr.openjdk.java.net/~coffeys/webrev.8208583.v3/webrev/index.html</a></p>
<p>regards,<br>
Sean.<br>
</p>
<br>
<div class="moz-cite-prefix">On 02/08/2018 02:13, Weijun Wang wrote:<br>
</div>
<blockquote type="cite"
cite="mid:DAC13804-867C-4205-9C25-927A1E01E1F8@oracle.com">
<blockquote type="cite" style="color: #000000;">
<pre wrap="">1.
I wasn't able to rename to destroy since that method is reserved for the Destroyable interface. I've gone with destroyKey.
</pre>
</blockquote>
<pre wrap="">Sorry I wasn't clear but this is exactly what I meant. SecretKey implements Destroyable so you don't need to define sKey as PBEKey. Does it make any problem?
</pre>
</blockquote>
<br>
</body>
</html>