<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:windowtext'>Hi Xuelei/John,<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>I did a minor change to handle graceful shutdown of server thread along with handling timeout for long waiting accept().<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Webrev: <a href="http://cr.openjdk.java.net/~ssahoo/8208496/webrev.01/">http://cr.openjdk.java.net/~ssahoo/8208496/webrev.01/</a><o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Siba<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> John Jiang <br><b>Sent:</b> Friday, August 03, 2018 7:21 AM<br><b>To:</b> Sibabrata Sahoo <sibabrata.sahoo@oracle.com><br><b>Cc:</b> Xue-Lei Fan <xuelei.fan@oracle.com>; security-dev@openjdk.java.net<br><b>Subject:</b> Re: [11] RFR: 8208496: New Test to verify concurrent behavior for TLS.<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>Hi Siba,<br>Would it be better to check how many connections the server accepts?<br>In your case, the server must accept 50 (no more no less) connections; otherwise, some problem may raise.<br><br>And I suppose, when the server thread is interrupted, the server socket may not be closed.<br>The server should exit immediately and gracefully when it has accepted all the connections.<br>If the server can be closed gracefully, it may be no need to set the server thread as daemon.<br><br>Some minors:<br>-- 28 import java.net.SocketException;<br>This import statement looks unused.<br><br>-- 131 sslSocket.setNeedClientAuth(false);<br>Now that client auth is not requested by default, so it may be unnecessary to set false value explicitly.<br><br>Best regards,<br>John Jiang<span style='font-size:12.0pt'><o:p></o:p></span></p><div><p class=MsoNormal>On 2018/8/2 18:41, Sibabrata Sahoo wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi Xuelei,<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Please review the patch for,<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8208496">https://bugs.openjdk.java.net/browse/JDK-8208496</a><o:p></o:p></p><p class=MsoNormal>Webrev: <a href="http://cr.openjdk.java.net/%7Essahoo/8208496/webrev.00/">http://cr.openjdk.java.net/~ssahoo/8208496/webrev.00/</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>This is a new Test which test concurrent behavior of TLS. It uses 50 client thread to access a single server port concurrently and repeat this process for each protocol supported.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Siba<o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></body></html>