<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thanks for the comments!<br>
Please take a look the updated webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jjiang/8164639/webrev.02/">http://cr.openjdk.java.net/~jjiang/8164639/webrev.02/</a><br>
Only README was adjusted.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2018/8/14 23:48, Rajan Halade wrote:<br>
</div>
<blockquote type="cite"
cite="mid:840d5d61-7f01-4eb7-4f6d-c301f22f4d2f@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
Few minor comments on README:<br>
<br>
- Please leave an empty line after each numbered section<br>
- I would suggest to update #2 to have general instruction on use
of artifactory. Something like<br>
<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">2. Pre-built NSS libraries from artifactory server
If the value of system property test.nss.lib.paths is null then tests will try
to download pre-built NSS libraries from artifactory server.
Currently, test only looks for libraries for Windows and MacOSX on artifactory.
Please note that, JIB jar MUST be present in classpath when downloading the libraries.
</pre>
Other changes look good to me.<br>
<br>
Thanks,<br>
Rajan<br>
<br>
<div class="moz-cite-prefix">On 8/14/18 4:40 AM, <a
class="moz-txt-link-abbreviated"
href="mailto:sha.jiang@oracle.com" moz-do-not-send="true">sha.jiang@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:3879a3e8-ded4-7f54-2c2a-0fdb55544e2b@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<p>Hi Max,<br>
Please review the new webrev: <a
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejjiang/8164639/webrev.01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jjiang/8164639/webrev.01/<br>
</a><br>
The new system property has been renamed to
test.nss.lib.paths, and it supports multiple paths.<br>
Currently, it cannot download the artifacts outside Oracle
network. This affects the test executions on Windows and
MacOSX.<br>
I added a block to README for clarifying something on getting
NSS libraries.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2018/8/13 16:48, Weijun Wang
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7C8994F3-8FC4-4E97-9568-72F535F4D8CC@oracle.com">
<pre wrap="">Sorry, more questions:
</pre>
<blockquote type="cite">
<pre wrap="">On Aug 13, 2018, at 3:36 PM, <a class="moz-txt-link-abbreviated" href="mailto:sha.jiang@oracle.com" moz-do-not-send="true">sha.jiang@oracle.com</a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Is there an artifact server available on the open internet?
</pre>
</blockquote>
<pre wrap="">It's transparent to me. @Artifact tool delegates the downloading.
</pre>
</blockquote>
<pre wrap="">Have you tried running the test outside Oracle?
Have you tried submitting the change to Mach5 as a non-Oracle developer? (i.e. using submit-repo)
While I am glad to see these files removed from the repo, I hope people still have a chance to run the tests.
Thanks
Max
</pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>