<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Martin,</p>
<p>I still observe the TestTLS12 regression test failure with your
webrev.07. Judging from the test failure log, it seems that the
test fails when run on a machine whose NSS library does not
support the TLS v1.2 mechanisms. Generally, the test should check
and skip if the to-be-tested algorithms aren't supported.<br>
</p>
There are some lines in TestTLS12.java which exceeds the 80-chars
length. Can you please fix them?<br>
That's it.<br>
<br>
Thanks,<br>
Valerie<br>
<br>
<div class="moz-cite-prefix">On 8/14/2018 7:43 AM, Martin Balao
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAKZz+gee5T5f3o4sKw0p-ai-P1=S=BDE2hWC8g_JJyX_AXN3Ug@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div>Hi Valerie,</div>
<div><br>
</div>
<div>Here it is Webrev.07:</div>
<div><br>
</div>
<div> * <a
href="http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.07/"
moz-do-not-send="true">http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.07/</a></div>
<div> * <a
href="http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.07.zip"
moz-do-not-send="true">http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.07.zip</a></div>
<div><br>
</div>
<div> * p11_convert.c:</div>
<div><br>
</div>
<div> * L530 and 834:
masterKeyDeriveParamToCKMasterKeyDeriveParam and
keyMatParamToCKKeyMatParam functions used to accept "null"
value for class parameter -and, in fact, immediately return in
such case-. Null-checking was in these functions to avoid
checking on each call site (i.e.:
jSsl3MasterKeyDeriveParamToCKSsl3MasterKeyDeriveParam and
jTls12MasterKeyDeriveParamToCKTls12MasterKeyDeriveParam call
sites for masterKeyDeriveParamToCKMasterKeyDeriveParam). But I
reverted this change now, so we check on call sites. I
couldn't find any not-checked FindClass call.</div>
<div><br>
</div>
<div> * L1262: well spotted! Fixed.</div>
<div><br>
</div>
<div> * Author tags removed</div>
<div><br>
</div>
<div> * Updated copyright on every modified file</div>
<div><br>
</div>
<div> * TestTLS12.java improvements:</div>
<div> * initSecmod is now called when starting the test</div>
<div> * Better integration with existing NSSDB + FIPS
infrastructure</div>
<div> * RSA+SHA256 certificate (that expires in 2042) was
added to FIPS keystore and NSSDB.</div>
<div><br>
</div>
<div> * Putback comment on webrev</div>
<div><br>
</div>
<div> * jdk/sun/security/pkcs11 test suite pass-rate experienced
no regression</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Martin.-</div>
<div class="gmail_extra">
<div class="gmail_quote"><br>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>