<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Max,<br>
Please review the updated webrev: <a
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejjiang/8209546/webrev.01/">http://cr.openjdk.java.net/~jjiang/8209546/webrev.01/</a><br>
All your comments are addressed, though this test is moved to
problem list for windows due to JDK-8204203.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2018/9/25 22:30, Weijun Wang wrote:<br>
</div>
<blockquote type="cite"
cite="mid:F7EB4230-6050-4CC0-B5B8-8FF87562B593@oracle.com">
<pre wrap="">Some questions:
1. Do we still need the OS check on lines 47-49? As long as getLibPath() can return something, does it mean the test should just run? Especially, does the test run on Windows?
2. Is launching a separate process necessary? Can we just call KeyToolTest::main after setting system properties and copying the files.
3. Is it possible to include standard.sh?
Thanks
Max
</pre>
<blockquote type="cite">
<pre wrap="">On Sep 25, 2018, at 6:30 PM, <a class="moz-txt-link-abbreviated" href="mailto:sha.jiang@oracle.com">sha.jiang@oracle.com</a> wrote:
Hi,
JDK-8164639 removed NSS libs from repo, so sun/security/tools/keytool/autotest.sh has to download NSS libs from artifactory on macosx.
This patch also refactors this shell test to a Java test.
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ejjiang/8209546/webrev.00/">http://cr.openjdk.java.net/~jjiang/8209546/webrev.00/</a>
Issue: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8209546">https://bugs.openjdk.java.net/browse/JDK-8209546</a>
Best regards,
John Jiang
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>