<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><br class=""><blockquote type="cite" class="">On Oct 2, 2018, at 2:49 AM, Sean Mullan <<a href="mailto:sean.mullan@oracle.com" class="">sean.mullan@oracle.com</a>> wrote:<br class=""><br class="">Looks good. After you update the CSR with these changes, I can review it.<br class=""></blockquote><div class=""><br class=""></div>Sure.<div class=""><br class=""></div><div class="">How do you think of the following change? Shall I also add it?</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">diff --git a/src/java.base/share/classes/java/security/KeyStore.java b/src/java.base/share/classes/java/security/KeyStore.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">--- a/src/java.base/share/classes/java/security/KeyStore.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(52, 188, 38); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">+++ b/src/java.base/share/classes/java/security/KeyStore.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(213, 59, 211); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -318,7 +318,7 @@</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * for a given keystore type is set using the</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * {@code 'keystore.<type>.keyProtectionAlgorithm'} security property.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * For example, the</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * {@code keystore.PKCS12.keyProtectionAlgorithm} property stores the</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(52, 188, 38); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+ * {@code keystore.pkcs12.keyProtectionAlgorithm} property stores the</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * name of the default key protection algorithm used for PKCS12</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * keystores. If the security property is not set, an</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * implementation-specific algorithm will be used.</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class="">Shall I add some word to this method saying we should use lowercase or are we going to live with this lower+UPPER for every keystore type forever?</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class="">If yes, there will also be some text for its compatibility risk.</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class="">Thanks</div><div class="">Max</div><div class=""><br class=""></div><blockquote type="cite" class=""><br class="">--Sean<br class=""><br class="">On 9/28/18 9:36 AM, Weijun Wang wrote:<br class=""><blockquote type="cite" class="">Webrev updated at<br class=""> <a href="http://cr.openjdk.java.net/~weijun/8076190/webrev.04/" class="">http://cr.openjdk.java.net/~weijun/8076190/webrev.04/</a><br class="">Major changes:<br class="">1. Comment out key=value lines in java.security<br class="">2. Fix a bug in PBES2Parameters.java<br class="">3. Test no longer depends on openssl. Instead, use openssl to generate some pkcs12 files and included in the test.<br class="">4. A new test KeyProtAlgCompat.java to ensure compatibility on pkcs12/PKCS12 names<br class="">I haven't made any change to KeyStore.java yet. CSR is also not updated.<br class="">Thanks<br class="">Max</blockquote></blockquote><br class=""><br class=""></div></body></html>