<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">It's a part of @implNote, and I added it there to show this implementation is compliant. I'm OK with removing it. Just like this:<div class=""><br class=""></div><div class=""><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">diff --git a/src/java.base/share/classes/java/security/DrbgParameters.java b/src/java.base/share/classes/java/security/DrbgParameters.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">--- a/src/java.base/share/classes/java/security/DrbgParameters.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(52, 188, 38); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">+++ b/src/java.base/share/classes/java/security/DrbgParameters.java</b></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(213, 59, 211); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -1,5 +1,5 @@</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> /*</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(52, 188, 38); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+ * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> *</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * This code is free software; you can redistribute it and/or modify it</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(213, 59, 211); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -225,10 +225,6 @@</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * <p></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * Calling {@link SecureRandom#generateSeed(int)} will directly read</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * from this system default entropy source.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * <p></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * This implementation has passed all tests included in the 20151104 version of</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * <a href="<a href="http://csrc.nist.gov/groups/STM/cavp/documents/drbg/drbgtestvectors.zip" class="">http://csrc.nist.gov/groups/STM/cavp/documents/drbg/drbgtestvectors.zip</a>"></span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(195, 55, 32); background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- * The DRBG Test Vectors</a>.</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> *</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> * @since 9</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> */</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><br class=""></div>Thanks</div><div class="">Max<br class=""><br class=""><blockquote type="cite" class="">On Oct 25, 2018, at 1:54 AM, Sean Mullan <<a href="mailto:sean.mullan@oracle.com" class="">sean.mullan@oracle.com</a>> wrote:<br class=""><br class="">IMHO, this is kind of an odd thing to include in the javadocs, the fact that it passed a bunch of tests. I'd be more inclined to simply remove this sentence and (maybe) instead include it in the JDK Providers Guide, but even then I am not sure it is really necessary.<br class=""><br class="">--Sean<br class=""><br class="">On 10/23/18 10:27 PM, Weijun Wang wrote:<br class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I'd like to refine the patch a little to<br class="">*diff --git a/src/java.base/share/classes/java/security/DrbgParameters.java b/src/java.base/share/classes/java/security/DrbgParameters.java*<br class="">*--- a/src/java.base/share/classes/java/security/DrbgParameters.java*<br class="">*+++ b/src/java.base/share/classes/java/security/DrbgParameters.java*<br class="">@@ -1,5 +1,5 @@<br class=""> /*<br class="">- * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.<br class="">+ * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.<br class=""> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.<br class=""> *<br class=""> * This code is free software; you can redistribute it and/or modify it<br class="">@@ -226,9 +226,9 @@<br class=""> * Calling {@link SecureRandom#generateSeed(int)} will directly read<br class=""> * from this system default entropy source.<br class=""> * <p><br class="">- * This implementation has passed all tests included in the 20151104 version of<br class="">- * <a href="<a href="http://csrc.nist.gov/groups/STM/cavp/documents/drbg/drbgtestvectors.zip" class="">http://csrc.nist.gov/groups/STM/cavp/documents/drbg/drbgtestvectors.zip</a>"><br class="">- * The DRBG Test Vectors</a>.<br class="">+ * This implementation has passed the DRBG Test Vectors (published on 2015-11-04) in<br class="">+ * <a href="<a href="https://csrc.nist.gov/Projects/Cryptographic-Algorithm-Validation-Program/Random-Number-Generators" class="">https://csrc.nist.gov/Projects/Cryptographic-Algorithm-Validation-Program/Random-Number-Generators</a>"><br class="">+ * CAVP Testing: Random Number Generators</a>.<br class=""> *<br class=""> * @since 9<br class=""> */<br class="">While "Cryptographic Algorithm Validation Program" is the main title shown on the page, it looks like the secondary header "CAVP Testing: Random Number Generators" is more precise and matches the URL. I also change the test vectors name to "DRBG Test Vectors" because the section could contain more links to other RNG test vectors.<br class="">Sorry for the quick update.<br class="">Thanks<br class="">Max<br class=""><blockquote type="cite" class="">On Oct 24, 2018, at 10:18 AM, Weijun Wang <<a href="mailto:weijun.wang@oracle.com" class="">weijun.wang@oracle.com</a> <mailto:weijun.wang@oracle.com>> wrote:<br class=""><br class="">Please take a review at the fix below:<br class=""><br class="">diff --git a/src/java.base/share/classes/java/security/DrbgParameters.java b/src/java.base/share/classes/java/security/DrbgParameters.java<br class="">--- a/src/java.base/share/classes/java/security/DrbgParameters.java<br class="">+++ b/src/java.base/share/classes/java/security/DrbgParameters.java<br class="">@@ -1,5 +1,5 @@<br class=""> /*<br class="">- * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.<br class="">+ * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.<br class=""> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.<br class=""> *<br class=""> * This code is free software; you can redistribute it and/or modify it<br class="">@@ -226,9 +226,9 @@<br class=""> * Calling {@link SecureRandom#generateSeed(int)} will directly read<br class=""> * from this system default entropy source.<br class=""> * <p><br class="">- * This implementation has passed all tests included in the 20151104 version of<br class="">- * <a href="http://csrc.nist.gov/groups/STM/cavp/documents/drbg/drbgtestvectors.zip"><br class="">- * The DRBG Test Vectors</a>.<br class="">+ * This implementation has passed the test vectors (published on 2015-11-04) in<br class="">+ * <a href="https://csrc.nist.gov/Projects/Cryptographic-Algorithm-Validation-Program/Random-Number-Generators"><br class="">+ * Cryptographic Algorithm Validation Program</a>.<br class=""> *<br class=""> * @since 9<br class=""> */<br class=""><br class="">Note that the link does not point to a zip file now. It might be a little rude to link to a 13MB zip file, and a description page is better. The page is quite concise and has a section named "Test Vectors" containing the link to the zip file. The zip file has actually no version info but the content shows the data was generated on 2015-11-04. I'd like to keep the date info in case the test vectors are updated some day.<br class=""><br class="">BTW, the zip file itself is exactly the same as before so there is no need to re-test.<br class=""><br class="">Thanks<br class="">Max<br class=""></blockquote></blockquote></blockquote><br class=""></div></body></html>