<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFCC">
Hi Dean,<br>
<br>
Looks ok, I have no better suggestion.<br>
<br>
Roger<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/05/2018 01:51 PM,
<a class="moz-txt-link-abbreviated" href="mailto:dean.long@oracle.com">dean.long@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4942fe9f-8f79-38f1-454b-d8bdc3700fd5@oracle.com">Hi
Roger. Thanks for looking at this.
<br>
<br>
On 11/5/18 7:21 AM, Roger Riggs wrote:
<br>
<blockquote type="cite">Hi Dean,
<br>
<br>
typo AccessController line788: "annocations"
<br>
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
<blockquote type="cite">The implementations of
<br>
<br>
doPrivileged(PrivilegedExceptionAction<T> action) and
<br>
doPrivileged(PrivilegedAction<T> action)
<br>
<br>
Could be a bit more similar since except for the exception
wrapping they are the same.
<br>
<br>
</blockquote>
<br>
I was trying to make
doPrivileged(PrivilegedExceptionAction<T> action) look like
<br>
doPrivileged(PrivilegedExceptionAction<T> action,
AccessControlContext context), but I didn't see the point in doing
that with
<br>
doPrivileged(PrivilegedAction<T> action). Do you have a
suggestion on how to improve it?
<br>
<br>
<blockquote type="cite">309 return executePrivileged(action, null,
Reflection.getCallerClass()); vs. AccessControlContext context =
null;
<br>
548 Class <?> caller = Reflection.getCallerClass();
<br>
549 try {
<br>
550 return executePrivileged(action, context, caller);
<br>
<br>
The context and caller locals aren't needed.
<br>
<br>
</blockquote>
<br>
I agree, if no exception is thrown, but just in case I'd rather
not do any extra work inside the "try" that might cause
<br>
an exception to be wrapped that shouldn't.
<br>
<br>
dl
<br>
<br>
<blockquote type="cite">Thanks, Roger
<br>
<br>
On 11/03/2018 04:00 PM, <a class="moz-txt-link-abbreviated" href="mailto:dean.long@oracle.com">dean.long@oracle.com</a> wrote:
<br>
<blockquote type="cite">I made a pass at improving the comments
based on feedback I've received. I updated webrev.4 in place,
along with an incremental diff:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dlong/8212605/webrev.4.update/">http://cr.openjdk.java.net/~dlong/8212605/webrev.4.update/</a>
<br>
<br>
dl
<br>
<br>
On 10/31/18 9:39 PM, Bernd Eckenfels wrote:
<br>
<blockquote type="cite">I find the tail call optimization
comment in wrapException adds only confusion to an otherwise
clear helper. But maybe it’s just me who does not understand
it.
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>