<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 07/11/18 13:12, Lars Francke wrote:<br>
</div>
<blockquote
cite="mid:CAD-Ua_gs-fnOEmgL_1EP95qpbA=Qbg+kTs+Zxbd3HdGPM54N-A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Seán,</div>
<div dir="ltr"><br>
</div>
<div>thank you!</div>
<div><br>
</div>
<div>I've already sent the OCA and am in the process of
getting it filed.</div>
<div>According to the docs[0] the next step would be to
provide a patch to this mailing list.</div>
<div><br>
</div>
<div>I have to admit that I'm a bit overwhelmed still (having
never built OpenJDK myself) so it'll take a while.</div>
<div><br>
</div>
<div>Would this patch also require a test?</div>
</div>
</div>
</blockquote>
you might get away without a test and add the noreg-trivial to the
eventual bug report. However, it might be no harm to examine the
current test code to see if the debug flag is exercised. If it is,
it might be the case of a simple edit to an existing test.<br>
<br>
regards,<br>
Sean.<br>
<blockquote
cite="mid:CAD-Ua_gs-fnOEmgL_1EP95qpbA=Qbg+kTs+Zxbd3HdGPM54N-A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>Assuming it's just of the form</div>
<div>if (debug) {</div>
<div> System.out.println(...);;</div>
<div>}</div>
<div><br>
</div>
<div>Cheers,</div>
<div>Lars</div>
<div><br>
</div>
<div><<a moz-do-not-send="true"
href="https://openjdk.java.net/contribute/">https://openjdk.java.net/contribute/</a>></div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Nov 7, 2018 at 1:44 PM Seán Coffey <<a
moz-do-not-send="true" href="mailto:sean.coffey@oracle.com">sean.coffey@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Looks like a
reasonable minor enhancement to me.<br>
<br>
To contribute, you'll need to sign the OCA first. More
information at :<br>
<br>
<a moz-do-not-send="true"
href="https://openjdk.java.net/contribute/" rel="noreferrer"
target="_blank">https://openjdk.java.net/contribute/</a><br>
<br>
Regards,<br>
Sean.<br>
<br>
On 07/11/18 11:40, Lars Francke wrote:<br>
> Hi,<br>
><br>
> I have to preface this by saying that this would be my
first <br>
> contribution to OpenJDK and I'm still learning the ways.
Not sure for <br>
> example if this is the correct mailing list or if a more
generic JDK <br>
> one would be appropriate.<br>
><br>
> While working on Hadoop based systems I frequently need
to debug <br>
> Kerberos related issues. And while there are
sun.security.krb5.debug <br>
> and sun.security.spnego.debug the error messages could be
more helpful <br>
> at times.<br>
><br>
> One of these instance <br>
> is
sun.security.krb5.internal.ktab.Keytab#readServiceKeys.<br>
><br>
> It logs that it's looking for keys but (at least for me)
it would be <br>
> very helpful if it also logged how many keys it found
after the for-loop.<br>
><br>
> If it finds keys it also logs them but if it can't find
any then <br>
> there's no message so it's easy to miss.<br>
><br>
> What do you think?<br>
><br>
> Cheers,<br>
> Lars<br>
<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>