<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Xuelei,<br>
<br>
A little wordsmithing, nit picky stuff (sorry for not seeing this
earlier):<br>
<ul>
<li>@apiNote for setSessionCacheSize: The sentence beginning, "It
is not recommended to use too big..." needs a slight grammatical
change</li>
<ul>
<li>Suggestion: "It is recommended that applications tune their
timeout and cache size values so they are neither too small
nor too large."</li>
<li>If you decide to change the language in the CSR then change
it in SSLSessionContext.java, too.<br>
</li>
</ul>
<li>@implNote for getSessionCacheSize: bring the closing brace in
from "{@code setSessionCacheSize method}" to put the word method
outside the braces.</li>
<ul>
<li>This should change in the code review,
SSLSessionContext.java:143</li>
</ul>
</ul>
<p>The rest is fine.<br>
</p>
--Jamil<br>
<br>
<div class="moz-cite-prefix">On 11/16/2018 10:30 AM, Xuelei Fan
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:228516ab-aaca-5a4e-f709-3b4f44a82101@oracle.com">It's
time to use the systemProperty tag as it is ready.
<br>
<br>
As we are already there, I also update the setSessionCacheSize()
for more clarification.
<br>
<br>
Please review both CSR and webrev:
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8213577">https://bugs.openjdk.java.net/browse/JDK-8213577</a>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8210985/webrev.02/">http://cr.openjdk.java.net/~xuelei/8210985/webrev.02/</a>
<br>
<br>
Thanks,
<br>
Xuelei
<br>
<br>
On 11/16/2018 8:19 AM, Sean Mullan wrote:
<br>
<blockquote type="cite">On 11/15/18 3:37 PM, Xuelei Fan wrote:
<br>
<blockquote type="cite">Hi Sean,
<br>
<br>
Are you OK if we do it later? I'm waiting for the
@systemProperty tag, proposed within JDK-5076751. I will file
a bug to use the tag for more cleanup.
<br>
</blockquote>
<br>
JDK-5076751 is completed and pushed to JDK 12, so you can use
the new tag now.
<br>
<br>
I think it would be easier to do it now, it seems pretty simple
and that way there is no need to worry about it later.
<br>
<br>
--Sean
<br>
<br>
<blockquote type="cite">
<br>
Thanks,
<br>
Xuelei
<br>
<br>
On 11/15/2018 11:55 AM, Sean Mullan wrote:
<br>
<blockquote type="cite">This is a good opportunity to document
the javax.net.ssl.sessionCacheSize system property in the
SSLSessionContext API (and use the new @systemProperty tag)
in an @implNote, for example:
<br>
<br>
/**
<br>
* Returns the size of the cache used for storing
<br>
* <code>SSLSession</code> objects grouped
under this
<br>
* <code>SSLSessionContext</code>.
<br>
*
<br>
* @implNote The JDK implementation returns the cache
size as set by
<br>
* the {@code setSessionCacheSize method}, or if not
set, the value
<br>
* of the {@systemProperty
javax.net.ssl.sessionCacheSize} system
<br>
* property. If neither is set, it returns a default
value of 20480.
<br>
*
<br>
* @return size of the session cache; zero means there
is no size limit.
<br>
* @see #setSessionCacheSize
<br>
*/
<br>
public int getSessionCacheSize();
<br>
<br>
On 11/14/18 11:59 AM, Xuelei Fan wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Please review this simple update:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8210985/webrev.00/">http://cr.openjdk.java.net/~xuelei/8210985/webrev.00/</a>
<br>
<br>
The default value for the maximum number of entries in the
SSL session cache
(SSLSessionContext.getSessionCacheSize()) is infinite
now. In the request, the default value is updated to
20480 for performance consideration.
<br>
<br>
For the detailed behavior update, please refer to CSR:
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8213577">https://bugs.openjdk.java.net/browse/JDK-8213577</a>
<br>
<br>
Thanks,
<br>
Xuelei
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<br>
</body>
</html>