<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.ms-outlook-ios-reference-expand, li.ms-outlook-ios-reference-expand, div.ms-outlook-ios-reference-expand
{mso-style-name:ms-outlook-ios-reference-expand;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:#999999;}
p.ms-outlook-ios-availability-container, li.ms-outlook-ios-availability-container, div.ms-outlook-ios-availability-container
{mso-style-name:ms-outlook-ios-availability-container;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
border:none;
padding:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.ms-outlook-ios-mention, li.ms-outlook-ios-mention, div.ms-outlook-ios-mention
{mso-style-name:ms-outlook-ios-mention;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
background:#F1F1F1;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:#333333;}
p.ms-outlook-ios-mention-external, li.ms-outlook-ios-mention-external, div.ms-outlook-ios-mention-external
{mso-style-name:ms-outlook-ios-mention-external;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
background:#FDF7E7;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:#BA8F0D;}
p.ms-outlook-ios-mention-external-clear-design, li.ms-outlook-ios-mention-external-clear-design, div.ms-outlook-ios-mention-external-clear-design
{mso-style-name:ms-outlook-ios-mention-external-clear-design;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
background:#F1F1F1;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:#BA8F0D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Bernd,
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I agree to both of your comments and will update my code with the changes.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Smita<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Bernd Eckenfels [mailto:ecki@zusammenkunft.net]
<br>
<b>Sent:</b> Monday, November 19, 2018 2:27 PM<br>
<b>To:</b> Kamath, Smita <smita.kamath@intel.com>; 'Vladimir Kozlov' <vladimir.kozlov@oracle.com><br>
<b>Cc:</b> core-libs-dev@openjdk.java.net; security-dev@openjdk.java.net<br>
<b>Subject:</b> Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Hello,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">What is the purpose of setting some of them to 0 twice? (It’s a new array which should be all-0 anyway.)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">+ for (int i = 1; i < 9 ; i++) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ subkeyHtbl[2*i] = 0;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ subkeyHtbl[2*i+1] = 0;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ }<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Also, is the subkeyH no longer be needed (or can be redesigned to use subkeyHtbl[0] and 1?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">Gruss<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Bernd<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">-- <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="http://bernd.eckenfels.net">http://bernd.eckenfels.net</a><o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="3" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">Von:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"> core-libs-dev <</span><a href="mailto:core-libs-dev-bounces@openjdk.java.net"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">core-libs-dev-bounces@openjdk.java.net</span></a><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">>
im Auftrag von Kamath, Smita <</span><a href="mailto:smita.kamath@intel.com"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">smita.kamath@intel.com</span></a><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">><br>
<b>Gesendet:</b> Montag, November 19, 2018 10:52 PM<br>
<b>An:</b> 'Vladimir Kozlov'<br>
<b>Cc:</b> Anthony Scarpino; </span><a href="mailto:core-libs-dev@openjdk.java.net"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">core-libs-dev@openjdk.java.net</span></a><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">;
hotspot compiler<br>
<b>Betreff:</b> RFR(S)JDK-8214074: Ghash optimization using AVX instructions <o:p>
</o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"> <o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Vladimir, <br>
<br>
I'd like to contribute an optimization for GHASH Algorithm using AVX Instructions. I have tested this optimization on SKX x86_64 platform and it shows ~20-30% performance improvement for larger message sizes (for example 8k).
<br>
<br>
I, <a href="mailto:smita.kamath@intel.com%3cmailto:smita.kamath@intel.com">smita.kamath@intel.com<mailto:smita.kamath@intel.com</a>> , Shay Gueuron, (<a href="mailto:shay.gueron@intel.com%3cmailto:shay.gueron@intel.com">shay.gueron@intel.com<mailto:shay.gueron@intel.com</a>>)
and Regev Shemy (<a href="mailto:regev.shemy@intel.com%3cmailto:regev.shemy@intel.com">regev.shemy@intel.com<mailto:regev.shemy@intel.com</a>>) are contributors to this code.
<br>
<br>
Link to Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8214074">https://bugs.openjdk.java.net/browse/JDK-8214074</a>
<br>
<br>
Link to webrev: <a href="http://cr.openjdk.java.net/~svkamath/ghash/webrev/">http://cr.openjdk.java.net/~svkamath/ghash/webrev/</a>
<br>
<br>
For testing the implementation, I have executed TestAESMain.java. I have executed Jtreg tests and tested this code on 64 bit Windows and Linux platforms.
<br>
<br>
Please review and let me know if you have any comments. <br>
<br>
Thanks and Regards, <br>
Smita <o:p></o:p></p>
</div>
</div>
</body>
</html>