<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 07/01/2019 11:13, Langer, Christoph wrote:<br>
<blockquote type="cite"
cite="mid:7b513a34196141f595cd5d194fb9d8a2@sap.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI Emoji";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US">I’ve amended the jdk.zipfs module documentation
in src/jdk.zipfs/share/classes/module-info.java to document
the new behavior (e.g. support of PosixFileAttributeView) as
requested by Alan. I’ve also updated the CSR.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Webrev: <a
href="http://cr.openjdk.java.net/~clanger/webrevs/8213031.4/"
moz-do-not-send="true">
http://cr.openjdk.java.net/~clanger/webrevs/8213031.4/</a><o:p></o:p></span></p>
<p class="MsoNormal">CSR: <a
href="https://bugs.openjdk.java.net/browse/JDK-8213082"
moz-do-not-send="true">
https://bugs.openjdk.java.net/browse/JDK-8213082</a><o:p></o:p></p>
<br>
</div>
</blockquote>
I think this is on the right path now. I'll start with the javadoc
as that will take a few iterations and you'll need to get that
agreed before finalizing the CSR.<br>
<br>
The proposed update starts out "Path objects residing in a zip file
system ..." isn't quite right. I think you want start with something
like "File systems created by the zip file system provider support
the POSIX file attributes defined by the {@link
PosixFileAttributeView}".<br>
<br>
I think the main issue that will need to be worked out is how the
bulk read PosixFileAttributeView::readAttributes behaves when the
zip entry doesn't have the external file attributes. UOE isn't right
because UOE should be thrown or not thrown based on
concrete/implementation type. One option is to throw IOE, another is
to have it return a PosixFileAttributes that contains an empty
permission set. The latter has the advantage that you can pass the
object to anything that excepts a BasicFileAttributes. Having
set/getOwner throw UOE is okay. Once we have agreement on how the
bulk read behaves then it should be easy to agree the javadoc
change.<br>
<br>
-Alan.<br>
</body>
</html>