<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Valerie, looks good, I only had one comment and it's more of a
nit than anything else.<br>
</p>
<ul>
<li>P11KeyPairGenerator.java</li>
<ul>
<li>122-124: I think those lines could be safely moved under the
algorithm.equals("RSA") clause up at line 113 and get rid of
the extra check at line 121.</li>
</ul>
</ul>
<p>--Jamil<br>
</p>
<div class="moz-cite-prefix">On 2/22/19 1:14 PM, Valerie Peng wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0197236a-1efb-606d-b1d4-504a23362084@oracle.com">
<br>
Anyone can help reviewing this fix? According to the bug report,
some vendors return 0 for both min/max key size range when queried
which leads to unexpected errors when SunPKCS11 provider validates
key sizes. So, I modified the code to work around this. No new
regression test as this is vendor specific and not an issue for
the current PKCS11 libraries used in regression testing.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8183107">https://bugs.openjdk.java.net/browse/JDK-8183107</a>
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/8183107/webrev.00/">http://cr.openjdk.java.net/~valeriep/8183107/webrev.00/</a>
<br>
<br>
Mach5 run is clean.
<br>
<br>
Thanks,
<br>
Valerie
<br>
</blockquote>
</body>
</html>