<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Lucida Console";
panose-1:2 11 6 9 4 5 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:DE;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">as was already discussed and requested on the mailing lists ([0], [1]), I hereby propose a change to add the root certificates of upstream OpenJDK to OpenJDK 8 updates.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The main bug that (initially) brought the Oracle certificates to OpenJDK is 8189131: Open-source the Oracle JDK Root Certificates [2]. My proposed change will also backport all updates to the contents of cacerts since
then:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8191844: Remove SECOM root (secomevrootca1)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8189949: Remove Baltimore Cybertrust Code Signing CA<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8191031: Remove several Symantec Root CAs<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8196141: Add GoDaddy root certificates<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8204923: Restore Symantec root verisignclass2g2ca<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8195774: Add Entrust root certificates<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8199779: Add T-Systems, GlobalSign and Starfield services root certificates<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8209506: Add Google Trust Services GlobalSign root certificates<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8210432: Add additional TeliaSonera root certificate<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8195793: Remove GTE CyberTrust Global Root<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8216577: Add GlobalSign's R6 Root certificate<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">8222137: Remove T-Systems root CA certificate<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please find the webrev here: <a href="http://cr.openjdk.java.net/~clanger/webrevs/8189131.8u/">
http://cr.openjdk.java.net/~clanger/webrevs/8189131.8u/</a> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I took the current state of cacerts from the jdk/jdk repo along with the provided testcases and brought them down to the jdk8 repository layout.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">To make the test run in JDK8, I had to<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">a) modify test/sun/security/lib/cacerts/VerifyCACerts.java:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.0pt;font-family:"Courier New";mso-fareast-language:DE"> 240 private static final HashSet<String> EXPIRY_EXC_ENTRIES = new HashSet<String>() {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I needed to add the String type to the constructor of the HashSet, since the JDK8 java compiler will not accept <> in that place.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">b) modify test/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java<o:p></o:p></span></p>
<pre><span lang="EN-US"> 60 private static final String CACERTS_STORE = System.getProperty("test.jdk")<o:p></o:p></span></pre>
<pre><span lang="EN-US"> 61 + FS + "jre" + FS + "lib" + FS + "security" + FS + "cacerts";<o:p></o:p></span></pre>
<p class="MsoNormal"><span lang="EN-US">I needed to adapt the path to cacerts in a JDK8 JDK/JRE as it is located in subdirectory jre there.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Out of the tests in test/security/infra/java/security/cert/CertPathValidator/certification, there are 2 failing:
<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Lucida Console"">FAILED: security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java<o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US" style="font-size:9.0pt;font-family:"Lucida Console"">FAILED: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">However, for jdk/jdk it is the same. JBS Issues for these tests exist and are yet unresolved: JDK-8202651 and JDK-8215546.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Since the tests don’t seem to be part of any tier, I propose to include them in this backport and later on also backport possible fixes to them.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks<o:p></o:p></span></p>
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[0] <a href="https://mail.openjdk.java.net/pipermail/security-dev/2019-March/019557.html">
https://mail.openjdk.java.net/pipermail/security-dev/2019-March/019557.html</a><o:p></o:p></p>
<p class="MsoNormal">[1] <a href="https://mail.openjdk.java.net/pipermail/security-dev/2019-April/019733.html">
https://mail.openjdk.java.net/pipermail/security-dev/2019-April/019733.html</a><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal">[2] <a href="https://bugs.openjdk.java.net/browse/JDK-8189131">
https://bugs.openjdk.java.net/browse/JDK-8189131</a> <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>