<html><head></head><body><div>Hi Max,</div><div><br></div><div>You are right. An explicit manifest is not necessary. I don't remember why I added it in the first place. It works also without it.</div><div><br></div><div>Regards,</div><div>Philipp</div><div><br></div><div><br></div><div>On Thu, 2019-05-09 at 16:44 +0800, Weijun Wang wrote:</div><blockquote type="cite"><pre>Hi Philipp,
I've posted your patch at
<a href="http://cr.openjdk.java.net/~weijun/8221719/webrev.00/">http://cr.openjdk.java.net/~weijun/8221719/webrev.00/</a>
Everyone please take a review.
I think it looks fine. Just one question: why do you need to create the Manifest in the test. Can you just create a jar without MANIFEST.MF and let jarsigner add it?
Thanks,
Max
<blockquote type="cite">
On May 1, 2019, at 10:14 PM, Philipp Kunz <<a href="mailto:philipp.kunz@paratix.ch">philipp.kunz@paratix.ch</a>> wrote:
Hi Max and everyone,
With respect to the previous patch, parentheses moved from storeHash to printCert, bug number added, and some comments added and clarified.
Regards,
Philipp
</blockquote>
</pre></blockquote></body></html>