<html><head></head><body><div>Hi Max,</div><div><br></div><div>Thanks for removing the unnecessary imports.</div><div><br></div><div>Before moving the @test comment block above the imports, my Eclipse picked it up as a JavaDoc comment and I could follow the link to JKS by clicking it in the JavaDoc view of Eclipse without any further configuration. Because I did not want to repeat the same text once as @summary and once as JavaDoc class comment, I enclosed the comment block with /** and moved it below the imports. Now I compared with other existing tests and found none with exactly such a structure. Closest examples could be test/jdk/java/awt/Mixing/AWT_Mixing/JButtonInGlassPaneOverlapping.java, test/jdk/java/lang/annotation/AnnotationType/AnnotationTypeRuntimeAssumptionTest.java or test/jdk/java/util/jar/Manifest/LineBreakLineWidth.java. But I found none really supporting the structure with @test inside /** after imports and a @link. If I may, I'm not sure what my role as a contributor entitles to, I agree to your change moving the comment block up and hope that helps to get the patch accepted. Just in case it helps, I don't know but maybe you prefer not to review your own moving a comment block, I attach the latest version, same as yours, again as a patch.</div><div><br></div><div>Regards,</div><div>Philipp</div><div><br></div><div><br></div><div><br></div><div>On Sat, 2019-05-11 at 23:27 +0800, Weijun Wang wrote:</div><blockquote type="cite"><pre>Hi Phillip,
I've posted the updated patch to
<a href="https://cr.openjdk.java.net/~weijun/8221719/webrev.01">https://cr.openjdk.java.net/~weijun/8221719/webrev.01</a>
after making 2 tiny changes. 1) move @test above imports. 2) remove 2 useless imports.
I'm fine with the change. If there's no one else with any extra comment, I'll push it.
Thanks,
Max
</pre></blockquote></body></html>