<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,<br>
Because Siba has to be offline for some days, now I take over this
task.<br>
<br>
Please review this updated webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jjiang/8224650/webrev.01/">http://cr.openjdk.java.net/~jjiang/8224650/webrev.01/</a><br>
It covers more cipher suites, and changes SSLSocketTemplate.java
on creating SSL context.<br>
Now, SSLSocketTemplate.java contains new ECDSA certificates on
curves secp384r1 and secp521r1.<br>
But these new certificates are not used by default.<br>
<br>
Run all tests in test/jdk/javax/net/ssl and
test/jdk/sun/security/ssl, no failure raised.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2019/6/21 16:22,
<a class="moz-txt-link-abbreviated" href="mailto:sha.jiang@oracle.com">sha.jiang@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7ab0c117-23f0-48ff-88ec-52e5e3db6bd1@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<p>Hi Siba,<br>
I have some minor comments.<br>
<br>
Now that JDK-8225766 has been fixed, I suppose this test can
cover some ECDHE_ECDSA cipher suites.<br>
<br>
48 private static volatile int index;<br>
...<br>
56 for (String c : getCiphers(protocols[index],
args[0])) {<br>
...<br>
66 String[] ps = new String[]{protocols[index]};<br>
Could it directly use the protocol value, but not the index in
the protocol array?<br>
Could these cases run concurrently? Otherwise, volatile may be
unnecessary.<br>
In fact, I think both of parameters cipher and index (or
directly protocol) would not be static.<br>
They would be the members of class NamedGroupsWithCipherSuite,
and can be passed to the class constructor.<br>
Then, every case run, say "new
NamedGroupsWithCipherSuite(cipher, protocol).run()", could not
concern these TLS parameters are modified by others.<br>
<br>
123 /**<br>
124 * Get some TLSv1.1 supported ciphers.<br>
125 */<br>
126 private static List<String> tlsCiphers() {<br>
...<br>
131 <br>
132 /**<br>
133 * Get some TLSv1.1 supported ciphers.<br>
134 */<br>
135 private static List<String> dheCiphers() {<br>
The above methods would have different docs.<br>
<br>
More spaces would be needed in the array initialization
statements, for example,<br>
66 String[] ps = new String[]{protocols[index]};<br>
71 socket.setEnabledCipherSuites(new
String[]{cipher});<br>
Of course, this point is trivial.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2019/6/21 14:59, Sibabrata Sahoo
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2e0eea89-dc72-4a5c-a43e-38a56bdc2c39@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi Xuelei/Brad,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the patch for,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">JBS: <a
href="https://bugs.openjdk.java.net/browse/JDK-8224650"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8224650</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a
href="http://cr.openjdk.java.net/~ssahoo/8224650/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~ssahoo/8224650/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is a small Test inherited from
“SSLSocketTemplate” and reuse most part of it. The only
difference is, it uses supported named groups along with a
fixed set of ciphers supported with different TLS protocols.
Though there are large number of supported ciphers but I
have selected few to ensure the Test does not take much time
to complete the execution. Please let me know if you have
any suggestion for improvement.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Siba<o:p></o:p></p>
</div>
</blockquote>
</blockquote>
</body>
</html>