<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body class=""><div>Hi Max,</div><div><br></div><div>Glad to see SignTwice being taken from ProblemList. Is it working now with the timeout added or does it still fail on windows?</div><div><br></div><div><span style="font-family: monospace; white-space: normal;">> I just ran a test job: SignTwice.java failed on Windows with `failed to clean up files after test`. Most likely a file is not closed.</span></div><div><br></div><div>For the key algs, "-DkeyAlgs=EC;" or "-DkeyAlgs=EC" might be shorter for the same effect, but "-DkeyAlgs=EC;0" is all right as well.</div><div><br></div><div>However, "-DdigestAlgs=SHA-256" will (far as I remember) not result in a digest that exceeds the maximum manifest line width in its encoded form as a base64 string and makes a difference. I strongly suggest to keep "-DdigestAlgs=SHA-512" or any other digest algorithm that tests line breaking of digests in signed jar file manifests.</div><div><br></div><div>Regards,</div><div>Philipp</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div>On Tue, 2019-07-23 at 14:28 +0800, Weijun Wang wrote:</div><blockquote type="cite">Please review the patch below. This test signs the same jar multiple times. It's mainly about making sure the manifest and signature file can be updated correctly. There is no need to try different key algorithms. We can also use a faster digest algorithm.<div class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Max<br class=""><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""><b class="">diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(252, 85, 85); background-color: rgb(255, 255, 255);" class=""><b class="">--- a/test/jdk/ProblemList.txt</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(85, 255, 85); background-color: rgb(255, 255, 255);" class=""><b class="">+++ b/test/jdk/ProblemList.txt</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 187); background-color: rgb(255, 255, 255);" class="">@@ -661,7 +661,6 @@</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> sun/security/tools/keytool/KeyToolTest.java 8224644 solaris-all</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> sun/security/tools/keytool/WeakAlg.java 8224644 solaris-all</div><p style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255); min-height: 13px;" class=""> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 4); background-color: rgb(255, 255, 255);" class="">-sun/security/tools/jarsigner/compatibility/SignTwice.java 8228341 windows-all</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java 8026393 generic-all</div><p style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255); min-height: 13px;" class=""> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java 8212096 generic-all</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""><b class="">diff --git a/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java b/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(252, 85, 85); background-color: rgb(255, 255, 255);" class=""><b class="">--- a/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(85, 255, 85); background-color: rgb(255, 255, 255);" class=""><b class="">+++ b/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java</b></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 187); background-color: rgb(255, 255, 255);" class="">@@ -36,7 +36,7 @@</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * @test</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * @library /test/lib ../warnings</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * @compile Compatibility.java</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 4); background-color: rgb(255, 255, 255);" class="">- * @run main/othervm</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(25, 187, 3); background-color: rgb(255, 255, 255);" class="">+ * @run main/othervm/timeout=600</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -Djava.security.properties=./java.security</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -Duser.language=en</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -Duser.country=US</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 187); background-color: rgb(255, 255, 255);" class="">@@ -46,8 +46,8 @@</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -DtestComprehensiveJarContents=true</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -DtestJarUpdate=true</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * -Dstrict=true</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 4); background-color: rgb(255, 255, 255);" class="">- * -DkeyAlgs=EC;#RSA;#DSA;</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(187, 0, 4); background-color: rgb(255, 255, 255);" class="">- * -DdigestAlgs=SHA-512</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(25, 187, 3); background-color: rgb(255, 255, 255);" class="">+ * -DkeyAlgs=EC;0</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; color: rgb(25, 187, 3); background-color: rgb(255, 255, 255);" class="">+ * -DdigestAlgs=SHA-256</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> * SignTwice</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> */</div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: "SF Mono"; background-color: rgb(255, 255, 255);" class=""> public class SignTwice {</div></div><div class=""><br class=""></div></div></div></blockquote></body></html>