<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFCC">
Looks good, <br>
<br>
Thanks, Roger<br>
<br>
<br>
<div class="moz-cite-prefix">On 8/15/19 11:22 AM, Claes Redestad
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:ba43af09-0e66-615c-242c-8dedcd079c8f@oracle.com">(adding
back core-libs-dev)
<br>
<br>
Hi Roger,
<br>
<br>
seems easy enough to add a writeReplace:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~redestad/8229773/webrev.02">http://cr.openjdk.java.net/~redestad/8229773/webrev.02</a>
<br>
<br>
/Claes
<br>
<br>
On 2019-08-15 16:54, Roger Riggs wrote:
<br>
<blockquote type="cite">Hi Claes,
<br>
<br>
I would recommend using writeReplace to serialize the
PermissionCollection so the serialized form does not change.
<br>
Though these are unlikely to be serialized, it will be less
likely to trigger some interoperability issue between different
version. It may need to be documented that
serializing/deserializing does not retain the lazyness.
<br>
<br>
Roger
<br>
<br>
<br>
On 8/15/19 10:30 AM, Claes Redestad wrote:
<br>
<blockquote type="cite">Hi Sean,
<br>
<br>
On 2019-08-15 15:07, Sean Mullan wrote:
<br>
<blockquote type="cite">Hi Claes,
<br>
<br>
I already reviewed an earlier version of this and this is
pretty similar. I did have a question about whether the
default serialization was ok - did you look into that more?
<br>
</blockquote>
<br>
ah, yes.. all the constituents are serializable (whether we
wrap the
<br>
CodeSource or its URL) so the new Lazy..Collection should be
too. I was
<br>
entertaining the idea that we could writeReplace the lazy
collection
<br>
with a PermissionCollection to avoid polluting serialization
use cases
<br>
with new type, but couldn't think of any real upside to that.
<br>
<br>
/Clae
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>