<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Great, the update looks good.</p>
    Thanks,<br>
    Valerie<br>
    <div class="moz-cite-prefix">On 9/24/2019 5:49 PM, Hohensee, Paul
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:EF3D973F-7A3F-4CA1-BCA1-840E6744F59A@amazon.com">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <meta name="Generator" content="Microsoft Word 15 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:#0563C1;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:#954F72;
        text-decoration:underline;}
pre
        {mso-style-priority:99;
        mso-style-link:"HTML Preformatted Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:10.0pt;
        font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
        {mso-style-name:msonormal;
        mso-margin-top-alt:auto;
        margin-right:0in;
        mso-margin-bottom-alt:auto;
        margin-left:0in;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;}
span.HTMLPreformattedChar
        {mso-style-name:"HTML Preformatted Char";
        mso-style-priority:99;
        mso-style-link:"HTML Preformatted";
        font-family:"Courier New";}
span.EmailStyle21
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
span.EmailStyle22
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
span.EmailStyle23
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style>
      <div class="WordSection1">
        <p class="MsoNormal"><span style="font-size:11.0pt">Thank you,
            Valerie. :) <o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt">The patch
            needs a test, however, so I added a slightly modified
            version of Tianmin’s reproducer. New webrev at<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt"><a
              href="http://cr.openjdk.java.net/~phh/8231387/webrev.01/"
              moz-do-not-send="true">http://cr.openjdk.java.net/~phh/8231387/webrev.01/</a><o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt">The test
            fails without the fix.<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
        <div style="border:none;border-top:solid #B5C4DF
          1.0pt;padding:3.0pt 0in 0in 0in">
          <p class="MsoNormal"><b><span style="color:black">From: </span></b><span
              style="color:black">Valerie Peng
              <a class="moz-txt-link-rfc2396E" href="mailto:valerie.peng@oracle.com"><valerie.peng@oracle.com></a><br>
              <b>Organization: </b>Oracle Corporation<br>
              <b>Date: </b>Tuesday, September 24, 2019 at 3:03 PM<br>
              <b>To: </b>"Hohensee, Paul" <a class="moz-txt-link-rfc2396E" href="mailto:hohensee@amazon.com"><hohensee@amazon.com></a>,
              <a class="moz-txt-link-rfc2396E" href="mailto:security-dev@openjdk.java.net">"security-dev@openjdk.java.net"</a>
              <a class="moz-txt-link-rfc2396E" href="mailto:security-dev@openjdk.java.net"><security-dev@openjdk.java.net></a><br>
              <b>Subject: </b>Re: RFR (XS) JDK-8231387
              "java.security.Provider.getService returns random result
              due to race condition with mutating methods in the same
              class"<o:p></o:p></span></p>
        </div>
        <div>
          <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
        </div>
        <p>I am the security reviewer that you need. One should be
          enough. ;)<o:p></o:p></p>
        <p>Valerie<o:p></o:p></p>
        <div>
          <p class="MsoNormal">On 9/24/2019 2:37 PM, Hohensee, Paul
            wrote:<o:p></o:p></p>
        </div>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoNormal"><span style="font-size:11.0pt">Yes, I’ll
              sponsor. Though it looks ok to me, I’m not a security
              expert, so do we need another security reviewer?</span><o:p></o:p></p>
          <p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
          <div style="border:none;border-top:solid #B5C4DF
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span style="color:black">From: </span></b><span
                style="color:black">security-dev
                <a href="mailto:security-dev-bounces@openjdk.java.net"
                  moz-do-not-send="true"><security-dev-bounces@openjdk.java.net></a>
                on behalf of Valerie Peng
                <a href="mailto:valerie.peng@oracle.com"
                  moz-do-not-send="true"><valerie.peng@oracle.com></a><br>
                <b>Organization: </b>Oracle Corporation<br>
                <b>Date: </b>Tuesday, September 24, 2019 at 2:17 PM<br>
                <b>To: </b><a
                  href="mailto:security-dev@openjdk.java.net"
                  moz-do-not-send="true">"security-dev@openjdk.java.net"</a>
                <a href="mailto:security-dev@openjdk.java.net"
                  moz-do-not-send="true"><security-dev@openjdk.java.net></a><br>
                <b>Subject: </b>Re: RFR (XS) JDK-8231387
                "java.security.Provider.getService returns random result
                due to race condition with mutating methods in the same
                class"</span><o:p></o:p></p>
          </div>
          <div>
            <p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
          </div>
          <p> <o:p></o:p></p>
          <p>Changes look fine. I suppose Paul will help sponsoring the
            fix as he is listed as the RE for 8231387?<o:p></o:p></p>
          <p class="MsoNormal">Thanks,<br>
            Valerie<o:p></o:p></p>
          <div>
            <p class="MsoNormal">On 9/24/2019 12:36 PM, Shi, Tianmin
              wrote:<o:p></o:p></p>
          </div>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black">Hi</span><o:p></o:p></pre>
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black"> </span><o:p></o:p></pre>
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black">Can someone help reviewing this fix?</span><o:p></o:p></pre>
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black"> </span><o:p></o:p></pre>
            <p class="MsoNormal"><span style="color:black">Bug: </span><a
                href="https://bugs.openjdk.java.net/browse/JDK-8231387"
                moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8231387</a><o:p></o:p></p>
            <p class="MsoNormal"><span style="color:black">Webrev: </span><a
href="http://cr.openjdk.java.net/~phh/8231387/webrev.00/"
                moz-do-not-send="true">http://cr.openjdk.java.net/~phh/8231387/webrev.00/</a><o:p></o:p></p>
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black"> </span><o:p></o:p></pre>
            <pre><span style="font-size:12.0pt;font-family:"Calibri",sans-serif;color:black">Thank you,</span><o:p></o:p></pre>
            <p class="MsoNormal">Tianmin Shi<o:p></o:p></p>
          </blockquote>
        </blockquote>
      </div>
    </blockquote>
  </body>
</html>