<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thank you Joe for checking it!<br>
</p>
<div class="moz-cite-prefix">On 10/2/19 4:38 PM, Joe Darcy wrote:<br>
</div>
<blockquote type="cite"
cite="mid:81df8c76-c7da-b61c-a88a-d7429e77a1bd@oracle.com">Hello,
<br>
<br>
At least from a quick reading, either the spec change or the
behavior change would seem to merit a CSR.
<br>
<br>
</blockquote>
<p>Sigh. I was hopping it'll be a quick fix :-)<br>
</p>
<p>So, I filed CSR: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8231805">https://bugs.openjdk.java.net/browse/JDK-8231805</a>
to cover the addition of @throws paragraph in the javadoc of
SocketPermission.</p>
<p>I would really appreciate it, if someone helped to review it.</p>
<p>W.r.t the behavior change, I don't think the fix has to be
counted as such. Current implementation already would throw
IllegalArgumentException if the action list were malformed (for
example if it were " , accept", or "connect,,accept", or
"connect,", etc.) The only case when it would <b>not</b> throw
IAE is when the argument <b>immediately</b> starts with a comma,
and that's what the fix is about.</p>
<p>It's not like if we used to allow commas in arbitrary places and
stopped doing that. Instead, it just turned out that the code
fails to catch one specific pattern of malformed action list.<br>
</p>
<p>With kind regards,</p>
<p>Ivan</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:81df8c76-c7da-b61c-a88a-d7429e77a1bd@oracle.com">Cheers,
<br>
<br>
-Joe
<br>
<br>
On 10/2/2019 4:26 PM, Ivan Gerasimov wrote:
<br>
<blockquote type="cite">Hi Chris!
<br>
<br>
Thank you very much for review!
<br>
<br>
I agree that it makes sense to update the javadoc for
consistency.
<br>
<br>
I don't think CSR is required in this case, is it? (IAE is
unchecked anyway, and the fix doesn't really change the
behavior.)
<br>
<br>
Here's the updated webrev:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~igerasim/8230407/01/webrev/">http://cr.openjdk.java.net/~igerasim/8230407/01/webrev/</a>
<br>
<br>
With kind regards,
<br>
<br>
Ivan
<br>
<br>
<br>
On 10/2/19 6:44 AM, Chris Hegarty wrote:
<br>
<blockquote type="cite">Ivan,
<br>
<br>
On 01/10/2019 21:26, Ivan Gerasimov wrote:
<br>
<blockquote type="cite">Hello!
<br>
<br>
The constructors of SocketPermission and FilePermission
expect a String argument with comma-separated list of
actions.
<br>
<br>
If the list is malformed, then the constructors throw
IllegalArgumentException.
<br>
<br>
It turns out that the current implementation fails to throw
IAE if the list starts with a leading comma.
<br>
<br>
Would you please help review a simple fix, which will make
the behavior more consistent?
<br>
<br>
BUGURL: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8230407">https://bugs.openjdk.java.net/browse/JDK-8230407</a>
<br>
WEBREV:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~igerasim/8230407/00/webrev/">http://cr.openjdk.java.net/~igerasim/8230407/00/webrev/</a>
<br>
</blockquote>
<br>
The implementation changes look ok.
<br>
<br>
The SocketPermission constructor should be updated to specify
IAE too, right?
<br>
<br>
-Chris.
<br>
<br>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
<pre class="moz-signature" cols="72">--
With kind regards,
Ivan Gerasimov</pre>
</body>
</html>