<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Xuelei,<br>
</p>
<p>Updated webrev looks good.</p>
<p>If we have a failing test to verify the changes, perhaps you can
try disabling the <span class="st">CKM_RSA_PKCS_PSS in the PKCS11
provider configuration file. Or, you can always comment out the
PSS Signature entry registration in SunPKCS11 provider.</span></p>
<span class="st">Thanks,</span><br>
<span class="st">Valerie<br>
</span>
<div class="moz-cite-prefix">On 11/4/2019 7:27 PM, Xuelei Fan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:030f4f18-7be1-e7cb-542b-789bb021471a@oracle.com">Hi
Valerie,
<br>
<br>
Thanks for the review.
<br>
<br>
On 11/4/2019 6:36 PM, Valerie Peng wrote:
<br>
<blockquote type="cite">Hi Xuelei,
<br>
<br>
Overall changes look good.
<br>
<br>
A nit: SignatureScheme.java:552, "Ignore unsupport..." instead
of "Ignore the unsupported..."
<br>
<br>
</blockquote>
Good catch!
<br>
<br>
<blockquote type="cite">It seems that the SignatureScheme
selection is always selected with PrivateKey first?
<br>
</blockquote>
Yes.
<br>
<br>
<blockquote type="cite">It'd be nice to have some comments explain
the different handling between getSigner(PrivateKey) and
getVerifier(PublicKey), i.e. former returns null vs later passes
up the exception.
<br>
<br>
</blockquote>
Yes, better to have some words for the difference. Here is the
updated webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8223940/webrev.01/">http://cr.openjdk.java.net/~xuelei/8223940/webrev.01/</a>
<br>
<br>
Comparing to the previous version, only the SignatureScheme.java
is updated.
<br>
<br>
Thanks,
<br>
Xuelei
<br>
<br>
<blockquote type="cite">Thanks,
<br>
Valerie
<br>
<br>
<br>
On 10/24/2019 1:56 PM, Xuelei Fan wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Could I get the following update reviewed?
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8223940/webrev.00/">http://cr.openjdk.java.net/~xuelei/8223940/webrev.00/</a>
<br>
<br>
For signature algorithms, the update will fail back to use the
supported signature algorithm for the specific private key.
Previously, the first preferred signature algorithm get used
ad the private key may not be able to work with the signature
algorithm however.
<br>
<br>
No new regression test as RSASSA-PSS has been supported in the
SunPKCS11 provider currently. Can I get a help for the test
if you are running a provider that does not support RSASSA-PSS
yet?
<br>
<br>
Thanks & Regards,
<br>
Xuelei
<br>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>