<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Thanks for review Sean, I will add test changes.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Prasad.K<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Seán Coffey <br><b>Sent:</b> Friday, February 7, 2020 6:20 PM<br><b>To:</b> Prasadrao Koppula <prasadarao.koppula@oracle.com>; security-dev@openjdk.java.net<br><b>Subject:</b> Re: RFR[jdk] 8237474: Default SSLEngine should create in server role<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>Looks ok to me Prasad. This may also be worthy of highlighting via release note. You might be able to expand test coverage to capture the TLSContext scenario. Something like below patch might work ?<span style='font-size:12.0pt'><o:p></o:p></span></p><p><o:p> </o:p></p><p style='margin-bottom:12.0pt'>--- a/test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java<br>+++ b/test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java<br>@@ -1,5 +1,5 @@<br> /*<br>- * Copyright (c) 2004, 2018, Oracle and/or its affiliates. All rights reserved.<br>+ * Copyright (c) 2004, 2020, Oracle and/or its affiliates. All rights reserved.<br> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.<br> *<br> * This code is free software; you can redistribute it and/or modify it<br>@@ -28,7 +28,7 @@<br> <br> /*<br> * @test<br>- * @bug 4980882 8207250<br>+ * @bug 4980882 8207250 8237474<br> * @summary SSLEngine should enforce setUseClientMode<br> * @run main/othervm EngineEnforceUseClientMode<br> * @author Brad R. Wetmore<br>@@ -87,6 +87,9 @@<br> * Note, these are not initialized to client/server<br> */<br> ssle3 = sslc.createSSLEngine();<br>+ if (ssle3.getUseClientMode()) {<br>+ throw new RuntimeException("Expected default role to be server");<br>+ }<br> ssle4 = sslc.createSSLEngine();<br> ssle5 = sslc.createSSLEngine();<br> }<o:p></o:p></p><pre>Regards,<o:p></o:p></pre><pre>Sean.<o:p></o:p></pre><div><p class=MsoNormal>On 07/02/20 11:32, Prasadrao Koppula wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi,<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Could you please review this patch. Default server role mode was flipped in SSLEngine, to client role mode as part of SSL package code refactoring for TLSv1.3, this patch flips back default client role to server role in SSLEngine.<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>webrev: <a href="http://cr.openjdk.java.net/%7Epkoppula/8237474/webrev.00/">http://cr.openjdk.java.net/~pkoppula/8237474/webrev.00/</a><o:p></o:p></p><p class=MsoPlainText>issue: <a href="https://bugs.openjdk.java.net/browse/JDK-8237474">https://bugs.openjdk.java.net/browse/JDK-8237474</a><o:p></o:p></p><p class=MsoPlainText>CSR: <a href="https://bugs.openjdk.java.net/browse/JDK-8238593">https://bugs.openjdk.java.net/browse/JDK-8238593</a><o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Thanks,<o:p></o:p></p><p class=MsoNormal>Prasad.K<o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></div></body></html>