<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Looks ok to me Prasad. This may also be worthy of highlighting
via release note. You might be able to expand test coverage to
capture the TLSContext scenario. Something like below patch might
work ?</p>
<p><br>
</p>
<p>---
a/test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java<br>
+++
b/test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java<br>
@@ -1,5 +1,5 @@<br>
/*<br>
- * Copyright (c) 2004, 2018, Oracle and/or its affiliates. All
rights reserved.<br>
+ * Copyright (c) 2004, 2020, Oracle and/or its affiliates. All
rights reserved.<br>
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.<br>
*<br>
* This code is free software; you can redistribute it and/or
modify it<br>
@@ -28,7 +28,7 @@<br>
<br>
/*<br>
* @test<br>
- * @bug 4980882 8207250<br>
+ * @bug 4980882 8207250 8237474<br>
* @summary SSLEngine should enforce setUseClientMode<br>
* @run main/othervm EngineEnforceUseClientMode<br>
* @author Brad R. Wetmore<br>
@@ -87,6 +87,9 @@<br>
* Note, these are not initialized to client/server<br>
*/<br>
ssle3 = sslc.createSSLEngine();<br>
+ if (ssle3.getUseClientMode()) {<br>
+ throw new RuntimeException("Expected default role to
be server");<br>
+ }<br>
ssle4 = sslc.createSSLEngine();<br>
ssle5 = sslc.createSSLEngine();<br>
}<br>
<br>
</p>
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 07/02/20 11:32, Prasadrao Koppula
wrote:<br>
</div>
<blockquote cite="mid:939a2142-60b6-49e8-873f-3f3888293342@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Could you please review this patch.
Default server role mode was flipped in SSLEngine, to client
role mode as part of SSL package code refactoring for TLSv1.3,
this patch flips back default client role to server role in
SSLEngine.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epkoppula/8237474/webrev.00/">http://cr.openjdk.java.net/~pkoppula/8237474/webrev.00/</a><o:p></o:p></p>
<p class="MsoPlainText">issue: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8237474">https://bugs.openjdk.java.net/browse/JDK-8237474</a><o:p></o:p></p>
<p class="MsoPlainText">CSR: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8238593">https://bugs.openjdk.java.net/browse/JDK-8238593</a><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Prasad.K<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>