<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Looks good. I like how this will simplify OID object generation
for our internal uses.</p>
<p>Nits:</p>
<ul>
<li>V3Certificate.java: Copyright should use 2020.</li>
<li>AvaEqualsHashCode: Copyright should use 2020.</li>
<li>OidEquals & OidFormat: 2020</li>
</ul>
<p>--Jamil<br>
</p>
<div class="moz-cite-prefix">On 2/17/2020 2:04 PM, Xuelei Fan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:04515ab0-4c1b-88bf-760b-06e47c86257a@oracle.com">Hi,
<br>
<br>
Could I get the following update reviewed?
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8239264/webrev.00/">http://cr.openjdk.java.net/~xuelei/8239264/webrev.00/</a>
<br>
<br>
For historic reason, the JDK internal ObjectIdentifier instances
are used to constructed with int arrays
(ObjectIdentifier(int[])). It is not a performance and user
friendly constructor. Removing this constructor could have a more
clear coding style, and better performance, by using alternative
constructors.
<br>
<br>
Thanks,
<br>
Xuelei
<br>
</blockquote>
</body>
</html>