<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks! looks good.<div class=""><br class=""><div class="">
<div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div>Thanks,</div><div>Rajan</div></div>
</div>
<div style=""><br class=""><blockquote type="cite" class=""><div class="">On Feb 25, 2020, at 10:24 PM, Amy Lu <<a href="mailto:amy.lu@oracle.com" class="">amy.lu@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div class="">
<div class="moz-cite-prefix"><tt class="">Removed othervm: </tt><tt class=""><a href="http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html" class="">http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html</a></tt><tt class=""><br class="">
</tt><tt class=""><br class="">
</tt><tt class="">Thanks,</tt><tt class=""><br class="">
</tt><tt class="">Amy</tt><tt class=""><br class="">
</tt><tt class=""><br class="">
</tt><tt class="">On 2/26/20 11:02 AM, Rajan Halade wrote:</tt><tt class=""><br class="">
</tt></div>
<blockquote type="cite" cite="mid:DC44816A-964B-4085-B5CA-71E344DF4109@ORACLE.COM" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<tt class="">Thanks Amy for the fix! </tt>
<div class=""><tt class=""><br class="">
</tt></div>
<div class=""><tt class="">Any reason for using othervm to run this test?
Otherwise your fix looks good to me.</tt></div>
<div class=""><tt class=""><br class="">
</tt>
<div class="">
<div dir="auto" style="caret-color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<div class=""><tt class="">Thanks,</tt></div>
<div class=""><tt class="">Rajan</tt></div>
</div>
</div>
<div class=""><tt class=""><br class="">
</tt>
<blockquote type="cite" class="">
<div class=""><tt class="">On Feb 25, 2020, at 6:48 PM, Amy Lu <</tt><tt class=""><a href="mailto:amy.lu@oracle.com" class="" moz-do-not-send="true">amy.lu@oracle.com</a></tt><tt class="">>
wrote:</tt></div>
<tt class=""><br class="Apple-interchange-newline">
</tt>
<div class="">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252" class="">
<div class=""> <tt class=""><span class="">sun/security/tools/keytool/ExtOptionCamelCase.java</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">This is not a
compile-only test, but due to the missed @run tag,
test is not run.</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">Please review the patch
to fix this issue.</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">The patch also fixed
@modules. Test performs deep reflection
setAccessible(true) on a non-public member, `open`
added to the module.</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8239979" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8239979</a></span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~amlu/8239979/webrev.00/index.html" moz-do-not-send="true">http://cr.openjdk.java.net/~amlu/8239979/webrev.00/index.html</a></span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">Thanks,</span></tt><tt class=""><span class=""><br class="">
</span></tt><tt class=""><span class="">Amy</span></tt><tt class=""><span class=""><br class="">
<br class="">
</span></tt><tt class=""><br class="">
</tt>
<pre style="font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; overflow-wrap: break-word; white-space: pre-wrap;" class="">--- old/test/jdk/sun/security/tools/keytool/ExtOptionCamelCase.java 2020-02-26 10:36:19.000000000 +0800
+++ new/test/jdk/sun/security/tools/keytool/ExtOptionCamelCase.java 2020-02-26 10:36:18.000000000 +0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -24,11 +24,13 @@
/*
* @test
* @bug 8231950
+ * @summary keytool -ext camel-case shorthand not working
* @modules java.base/sun.security.tools.keytool
+ * java.base/sun.security.tools.keytool:open
* java.base/sun.security.util
* java.base/sun.security.x509
* @compile -XDignore.symbol.file ExtOptionCamelCase.java
- * @summary keytool -ext camel-case shorthand not working
+ * @run main/othervm ExtOptionCamelCase
*/
import sun.security.tools.keytool.Main;</pre>
<tt class=""><span class=""> </span></tt><tt class=""><span class=""> </span></tt>
</div>
</div>
</blockquote>
</div>
<tt class=""><br class="">
</tt></div>
</blockquote>
<tt class=""><br class="">
</tt>
</div>
</div></blockquote></div><br class=""></div></body></html>