<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
Hi Alexey - I was trying to understand the fix for the <span style="caret-color: rgb(43, 46, 47); color: rgb(43, 46, 47);" class="">"Unexpected number of plaintext bytes</span><font color="#2b2e2f" class=""><span style="caret-color: rgb(43, 46, 47);" class="">”
issue.</span></font>
<div class=""><font color="#2b2e2f" class=""><span style="caret-color: rgb(43, 46, 47);" class=""><br class="">
</span></font>
<div class=""><font color="#2b2e2f" class="">But it appears that the earlier iterations of the webrevs have disappeared, only webrev.5 is available in [1]</font></div>
<div class=""><font color="#2b2e2f" class="">In the future it would be a good practice, to retain all the webrevs for sometime.</font></div>
<div class=""><font color="#2b2e2f" class=""><br class="">
</font></div>
<div class=""><font color="#2b2e2f" class="">Thanks</font></div>
<div class=""><br class="">
</div>
<div class=""><font color="#2b2e2f" class=""><span style="caret-color: rgb(43, 46, 47);" class="">Kumar</span></font></div>
<div class=""><br class="">
</div>
<div class="">[1] <a href="http://cr.openjdk.java.net/~dcherepanov/8239788/" class="">
http://cr.openjdk.java.net/~dcherepanov/8239788/</a></div>
<div class="">
<div><br class="">
</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Mar 11, 2020, at 8:53 AM, Xuelei Fan <<a href="mailto:xuelei.fan@oracle.com" class="">xuelei.fan@oracle.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Hi
Alexey,</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I
had run the testing for you, no surprise. Please commit to JDK 15, and backport accordingly.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Thanks,</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Xuelei</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On
3/11/2020 7:16 AM, Alexey Bakhtin wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
Hello Xuelei,<br class="">
Thank you for review.<br class="">
Can I commit it to JDK15 and create backports to JDK 14, 13 and 11 ?<br class="">
Thank you<br class="">
Alexey<br class="">
<blockquote type="cite" class="">On 10 Mar 2020, at 20:59, Xuelei Fan <<a href="mailto:xuelei.fan@oracle.com" class="">xuelei.fan@oracle.com</a>> wrote:<br class="">
<br class="">
Looks fine to me.<br class="">
<br class="">
Thanks,<br class="">
Xuelei<br class="">
<br class="">
On 3/5/2020 8:50 AM, Alexey Bakhtin wrote:<br class="">
<blockquote type="cite" class="">Hello Xuelei,<br class="">
I have renamed inputBuffer to recordBody.<br class="">
Also, as you suggested, recordBody is not removed but used for multiple records. So, it should be better for performance.<br class="">
JDK15 webrev:<span class="Apple-converted-space"> </span><a href="https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~dcherepanov%2F8239788%2Fwebrev.v5%2F&data=02%7C01%7Ckusrinivasan%40vmware.com%7C322b64d367df4ad239db08d7c5d4901e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637195389056395429&sdata=y2sJbDyL8DmumCrlY3tF35BVyfs1k7Ikmr2l3ypMXDg%3D&reserved=0" class="">https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~dcherepanov%2F8239788%2Fwebrev.v5%2F&data=02%7C01%7Ckusrinivasan%40vmware.com%7C322b64d367df4ad239db08d7c5d4901e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637195389056395429&sdata=y2sJbDyL8DmumCrlY3tF35BVyfs1k7Ikmr2l3ypMXDg%3D&reserved=0</a><br class="">
Regards<br class="">
Alexey<br class="">
<blockquote type="cite" class="">On 4 Mar 2020, at 21:23, Xuelei Fan <<a href="mailto:xuelei.fan@oracle.com" class="">xuelei.fan@oracle.com</a>> wrote:<br class="">
<br class="">
<blockquote type="cite" class=""><a href="https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~bae%2F8239788%2Fwebrev.v4%2F&data=02%7C01%7Ckusrinivasan%40vmware.com%7C322b64d367df4ad239db08d7c5d4901e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637195389056395429&sdata=dAjTwfyW8tbCErqNc2URUVJdou8Aun3m9G%2FQ56N9PwA%3D&reserved=0" class="">https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~bae%2F8239788%2Fwebrev.v4%2F&data=02%7C01%7Ckusrinivasan%40vmware.com%7C322b64d367df4ad239db08d7c5d4901e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637195389056395429&sdata=dAjTwfyW8tbCErqNc2URUVJdou8Aun3m9G%2FQ56N9PwA%3D&reserved=0</a><br class="">
</blockquote>
<br class="">
SSLSocketInputRecord:<br class="">
54 // Cache for incomplete input record.<br class="">
55 private ByteBuffer inputBuffer = null;<br class="">
This variable is used for record body, I may use a instinctive name, for example recordBody.<br class="">
<br class="">
Otherwise, looks good to me.<br class="">
<br class="">
I think, for performance, it may be possible to reuse this buffer for multiple records. I'd appreciate if you want to make an improvement in this update as well.<br class="">
<br class="">
Thanks,<br class="">
Xuelei</blockquote>
</blockquote>
</blockquote>
</blockquote>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>