<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi John,<div class=""><br class=""></div><div class="">Thanks for taking care of this fix. Your changes look good me. </div><div class=""><br class=""></div><div class="">I have couple of suggestions:</div><div class=""><br class=""></div><div class="">- consider changing header for last column from “Why negative case” to “Reason”</div><div class="">- for a failed test case (a testcase that succeeds when expected to fail or a testcase that fails when expected to succeed) code will not have any reason listed and we will need to click hyperlink in the report to find out root cause. May I suggest to pass in status to TestCase.negativeCaseReason() method call and use reason as “Refer to log at test hyperlink for details…” for such cases.</div><div class=""><br class=""><div class="">
<div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div>Thanks,</div><div>Rajan</div></div>
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On Mar 24, 2020, at 6:50 PM, <a href="mailto:sha.jiang@oracle.com" class="">sha.jiang@oracle.com</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi,<br class="">This patch updates the manual test javax/net/ssl/compatibility/Compatibility.java on the following points:<br class="">1. Covers SSLv3<br class="">2. The server side doesn't limit/specify protocols and cipher suites anymore. Only the client side specifies these parameters.<br class="">3. Only focus on the testing JDK specified by jtreg option "-jdk", and not run the cases between the JDKs builds in jdkList. This would save much execution time.<br class="">4. The report has a new column that clarifying why a case is a negative case.<br class=""><br class="">Issue: <a href="https://bugs.openjdk.java.net/browse/JDK-8237977" class="">https://bugs.openjdk.java.net/browse/JDK-8237977</a><br class="">Webrev: <a href="http://cr.openjdk.java.net/~jjiang/8237977/webrev.00/" class="">http://cr.openjdk.java.net/~jjiang/8237977/webrev.00/</a><br class=""><br class="">Best regards,<br class="">John Jiang<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>