<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Looks pretty good, a couple questions/comments:</p>
<ul>
<li>SSLConfiguration.java</li>
<ul>
<li>Line 471-473: Does the call to
SignatureScheme.nameOf(String) ever throw IAE? I don't see
anything in the for-each loop in that method that would.</li>
</ul>
<li>CustomizedClientSchemes and CustomizedServerSchemes</li>
<ul>
<li>Line 44 (both): Just a nit, but the comment looks like it
was lifted from a different test and should be changed to
reflect that your forcing a single signature scheme.</li>
</ul>
</ul>
<p>--Jamil<br>
</p>
<div class="moz-cite-prefix">On 4/14/2020 8:42 PM, Xuelei Fan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:b9140dc0-f380-f971-7ee6-1682ac7a6036@oracle.com">ping
...
<br>
<br>
On 4/3/2020 4:13 PM, Xuelei Fan wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Could I get the following update reviewed?
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8242145/webrev.00/">http://cr.openjdk.java.net/~xuelei/8242145/webrev.00/</a>
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8242141">https://bugs.openjdk.java.net/browse/JDK-8242141</a>
<br>
CSR: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8242145">https://bugs.openjdk.java.net/browse/JDK-8242145</a>
<br>
Release-note: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8242147">https://bugs.openjdk.java.net/browse/JDK-8242147</a>
<br>
<br>
A third party's TLS implementation may not be able to handle a
certain signature schemes, and cannot interop with JDK.
Although the implementation does not comply to TLS
specifications, the impact could be significant if an
application that uses the implementation is popular.
<br>
<br>
Thanks,
<br>
Xuelei
<br>
</blockquote>
</blockquote>
</body>
</html>