<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p>Hi, Siba,</p>
<p>Here are my comments:</p>
<p><SerializedPSSKey.java></p>
<p>- Typos: Initialisation -> Initialization.</p>
<p>- the 2nd algorithm specific initialization using reflection
doesn't seem too useful. The code path should be exactly the same
as the non-reflection one. Maybe just remove it.</p>
<p>Rest looks fine.</p>
Thanks,<br>
Valerie<br>
<div class="moz-cite-prefix">On 4/28/2020 12:38 AM,
<a class="moz-txt-link-abbreviated" href="mailto:sibabrata.sahoo@oracle.com">sibabrata.sahoo@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:DAE3FB0F-1356-4A2A-8B5F-56E5E8942BB7@oracle.com">
<div class="">Hi Valerie,</div>
<div class=""><br class="">
</div>
<div class="">Please review the patch for,</div>
<div class="">JBS: <a
href="https://bugs.openjdk.java.net/browse/JDK-8242335"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8242335</a></div>
<div class="">Webrev: <a
href="http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/</a></div>
<div class=""><br class="">
</div>
<div class="">These are additional Tests developed to support
RSASSA-PSS algorithm. One is key compatibility with OpenSSL
generated while the other one is the API Tests for serialized
keys.</div>
<br class="">
<div class="">
<div>Thanks,<br class="">
Siba</div>
<div class=""><br class="">
</div>
<br class="Apple-interchange-newline">
</div>
<br class="">
</blockquote>
</body>
</html>