<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Valerie,<div class=""><br class=""></div><div class="">Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature instance.</div><div class=""><br class=""></div><div class="">Webrev: <a href="http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/" class="">http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/</a></div><div class=""><br class=""><div class="">
<div>Thanks,<br class="">Siba</div><div class=""><br class=""></div><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On 01-May-2020, at 4:58 AM, Valerie Peng <<a href="mailto:valerie.peng@oracle.com" class="">valerie.peng@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div class=""><p class="">Hi, Siba,</p><p class="">Here are my comments:</p><p class=""><SerializedPSSKey.java></p><p class="">- Typos: Initialisation -> Initialization.</p><p class="">- the 2nd algorithm specific initialization using reflection
doesn't seem too useful. The code path should be exactly the same
as the non-reflection one. Maybe just remove it.</p><p class="">Rest looks fine.</p>
Thanks,<br class="">
Valerie<br class="">
<div class="moz-cite-prefix">On 4/28/2020 12:38 AM,
<a class="moz-txt-link-abbreviated" href="mailto:sibabrata.sahoo@oracle.com">sibabrata.sahoo@oracle.com</a> wrote:<br class="">
</div>
<blockquote type="cite" cite="mid:DAE3FB0F-1356-4A2A-8B5F-56E5E8942BB7@oracle.com" class="">
<div class="">Hi Valerie,</div>
<div class=""><br class="">
</div>
<div class="">Please review the patch for,</div>
<div class="">JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8242335" class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8242335</a></div>
<div class="">Webrev: <a href="http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/" class="" moz-do-not-send="true">http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/</a></div>
<div class=""><br class="">
</div>
<div class="">These are additional Tests developed to support
RSASSA-PSS algorithm. One is key compatibility with OpenSSL
generated while the other one is the API Tests for serialized
keys.</div>
<br class="">
<div class="">
<div class="">Thanks,<br class="">
Siba</div>
<div class=""><br class="">
</div>
<br class="Apple-interchange-newline">
</div>
<br class="">
</blockquote>
</div>
</div></blockquote></div><br class=""></div></body></html>