<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi John,</p>
<p>- line 125, typo: "<span class="new">aliaes" should be "aliases"
<br>
</span></p>
<p><span class="new">- line 132: if aliases is not null, check its
length is </span><span class="changed">certStrs.length</span></p>
<p><span class="new"></span></p>
<p><span class="new">- line 152, use the specified type instead of
DEFAULT_TYPE?</span></p>
<p><span class="new">- line 176, maybe it's better to just supply
the type, clearer and less dependency.<br>
</span></p>
<p><span class="new">With this extra aliases argument, number of
createTrustStore(...) methods doubled from 2 to 4, number of
createKeyStore(...) methods also doubled from 4 to 8. Isn't it a
bit much to have 8 methods doing the same thing? Especially in
the case of createKeyStore(...), quite a few of them have long
list of arguments with the same type, combining this with the
large number of methods, it can get confusing on which method is
called. How often do you think the aliases are supplied? Maybe
we only add methods which will be used instead of adding all
possible combinations.<br>
</span></p>
<span class="new">Thanks,</span><br>
<span class="new">Valerie<br>
</span>
<div class="moz-cite-prefix">On 5/15/2020 11:40 PM,
<a class="moz-txt-link-abbreviated" href="mailto:sha.jiang@oracle.com">sha.jiang@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:92a827d8-1cb3-01a2-763b-65f3ae06baaa@oracle.com">Hi,
<br>
This patch adds some new createTrustStore() and createKeyStore()
methods to test
<br>
lib class jdk.test.lib.security.KeyStoreUtils.
<br>
These new methods allow to pass trust/key store aliases in.
<br>
<br>
Issue: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8245134">https://bugs.openjdk.java.net/browse/JDK-8245134</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jjiang/8245134/webrev.00/">http://cr.openjdk.java.net/~jjiang/8245134/webrev.00/</a>
<br>
<br>
Best regards,
<br>
John Jiang
<br>
<br>
</blockquote>
</body>
</html>