<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Looks good. Cleaner and shorter this way~</p>
Thanks,<br>
Valerie<br>
<div class="moz-cite-prefix">On 5/21/2020 8:18 PM,
<a class="moz-txt-link-abbreviated" href="mailto:sha.jiang@oracle.com">sha.jiang@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7579bb12-d03a-81ea-08fc-75e4a9a599ad@oracle.com">
<p>Hi Valerie,<br>
Thanks for your clarification!<br>
<br>
Could you please review this updated webrev:<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~jjiang/8245134/webrev.01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jjiang/8245134/webrev.01/</a><br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 2020/5/22 06:08, Valerie Peng
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:875e8f7f-b94a-19a6-a90a-a6bde65c2295@oracle.com">
<p><br>
</p>
<div class="moz-cite-prefix">On 5/20/2020 7:38 PM, <a
class="moz-txt-link-abbreviated"
href="mailto:sha.jiang@oracle.com" moz-do-not-send="true">sha.jiang@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:023b046e-83d1-32ec-f8bd-b1a886be0ef4@oracle.com"> <br>
<blockquote type="cite"
cite="mid:295193c9-d389-a04c-f143-44a80d47431e@oracle.com">
<p><span class="new">- line 176, maybe it's better to just
supply the type, clearer and less dependency.<br>
</span></p>
</blockquote>
Not get this point.<br>
Could you please describe some more?<br>
</blockquote>
<p>I mean to change line 176 as below (see the added text in
blue):<br>
</p>
<pre><span class="changed"> 176 return createTrustStore(</span><span class="changed"><span class="changed">DEFAULT_TYPE, </span>certStrs, null);</span></pre>
<p><br>
</p>
<blockquote type="cite"
cite="mid:023b046e-83d1-32ec-f8bd-b1a886be0ef4@oracle.com">
<blockquote type="cite"
cite="mid:295193c9-d389-a04c-f143-44a80d47431e@oracle.com">
<p><span class="new"> </span></p>
<p><span class="new">With this extra aliases argument,
number of createTrustStore(...) methods doubled from 2
to 4, number of createKeyStore(...) methods also doubled
from 4 to 8. Isn't it a bit much to have 8 methods doing
the same thing? Especially in the case of
createKeyStore(...), quite a few of them have long list
of arguments with the same type, combining this with the
large number of methods, it can get confusing on which
method is called. How often do you think the aliases are
supplied? Maybe we only add methods which will be used
instead of adding all possible combinations.<br>
</span></p>
</blockquote>
I'll remove 4 <span class="new">createKeyStore(...) methods
(like the below one) that have </span>long list of
arguments.<br>
createKeyStore(String type, String[] keyAlgos,<br>
String[] keyStrs, String[] passwords, String[]
certStrs,<br>
String[] aliases)<br>
It looks no test is using them. My tests also won't use them.<br>
</blockquote>
<p>Sounds good. <br>
</p>
Thanks,<br>
Valerie<br>
<blockquote type="cite"
cite="mid:023b046e-83d1-32ec-f8bd-b1a886be0ef4@oracle.com"> <br>
Best regards,<br>
John Jiang<br>
<blockquote type="cite"
cite="mid:295193c9-d389-a04c-f143-44a80d47431e@oracle.com">
<p><span class="new"> </span></p>
<span class="new">Thanks,</span><br>
<span class="new">Valerie<br>
</span>
<div class="moz-cite-prefix">On 5/15/2020 11:40 PM, <a
class="moz-txt-link-abbreviated"
href="mailto:sha.jiang@oracle.com"
moz-do-not-send="true">sha.jiang@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:92a827d8-1cb3-01a2-763b-65f3ae06baaa@oracle.com">Hi,
<br>
This patch adds some new createTrustStore() and
createKeyStore() methods to test <br>
lib class jdk.test.lib.security.KeyStoreUtils. <br>
These new methods allow to pass trust/key store aliases
in. <br>
<br>
Issue: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8245134"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8245134</a>
<br>
Webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~jjiang/8245134/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~jjiang/8245134/webrev.00/</a>
<br>
<br>
Best regards, <br>
John Jiang <br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>