<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Thanks Lance.<br>
</p>
<p>During the CSR review, a suggestion was made to have jarsigner
preserve such attributes by default. Warnings about these
attributes will also be added during signing and verify operations
(if detected).</p>
<p>webrev:
<a class="moz-txt-link-freetext" href="https://cr.openjdk.java.net/~coffeys/webrev.8218021.v4/webrev/">https://cr.openjdk.java.net/~coffeys/webrev.8218021.v4/webrev/</a></p>
<p>regards,<br>
Sean.</p>
<div class="moz-cite-prefix">On 22/06/2020 17:17, Lance Andersen
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:E832FEA3-3CE1-4E46-A55B-B3C1B5CC80A2@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
HI Sean,
<div class=""><br class="">
</div>
<div class="">Looks OK based on our exchanges. Thank you for your
time on this one!</div>
<div class=""><br class="">
</div>
<div class="">Best</div>
<div class="">Lance<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Jun 22, 2020, at 7:22 AM, Seán Coffey <<a
href="mailto:sean.coffey@oracle.com" class=""
moz-do-not-send="true">sean.coffey@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<div class="">
<p class="">Thanks Lance.</p>
<p class="">I've updated the patch with some extra
offline feedback from yourself and Max.<br class="">
A new warning is printed with use of the new flag. A
warning is also printed when file posix permissions
are detected on resources being signed. Test updated
for that also.</p>
<p class=""><a
href="https://cr.openjdk.java.net/~coffeys/webrev.8218021.v3/webrev/"
class="" moz-do-not-send="true">https://cr.openjdk.java.net/~coffeys/webrev.8218021.v3/webrev/</a></p>
<p class="">regards,<br class="">
Sean.<br class="">
</p>
<div class="moz-cite-prefix">On 12/06/2020 17:05, Lance
Andersen wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:22AD74BE-6E90-45CA-AEEF-73E5FCCC0BF5@oracle.com"
class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
Hi Sean,
<div class=""><br class="">
</div>
<div class="">I think your changes look fine so all
good FMPOV.</div>
<div class=""><br class="">
</div>
<div class="">Best</div>
<div class="">Lance</div>
<div class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Jun 12, 2020, at 6:21 AM, Seán
Coffey <<a
href="mailto:sean.coffey@oracle.com"
class="" moz-do-not-send="true">sean.coffey@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Hi,<br class="">
<br class="">
I'd like to reboot this jarsigner
enhancement request[1]. I've removed the
problem references to zip file name
extensions. Instead, there's a new JDK
implementation specific jarsigner option:
-keepposixperms<br class="">
<br class="">
<a
href="https://bugs.openjdk.java.net/browse/JDK-8218021"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8218021</a><br
class="">
<a class="moz-txt-link-freetext"
href="https://cr.openjdk.java.net/~coffeys/webrev.8218021.v2/webrev/"
moz-do-not-send="true">https://cr.openjdk.java.net/~coffeys/webrev.8218021.v2/webrev/</a><br
class="">
<br class="">
regards,<br class="">
Sean.<br class="">
<br class="">
[1]
<a class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/security-dev/2020-January/021141.html"
moz-do-not-send="true">http://mail.openjdk.java.net/pipermail/security-dev/2020-January/021141.html</a><br
class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
<div class="">
<div class=""><span class="Apple-style-span"
style="border-collapse: separate;
border-spacing: 0px; "><span
class="Apple-style-span" style="color:
rgb(102, 102, 102); font-family: Verdana,
Arial, Helvetica, sans-serif; font-size:
small; "><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span
class=""><span
id="cid:part4.55D05D93.A38F50FB@oracle.com"><oracle_sig_logo.gif></span></span></a>
<div style="font-family: Helvetica;
font-size: 15px; font-style: normal;
font-variant-ligatures: normal;
font-variant-caps: normal;
font-variant-east-asian: normal;
font-variant-position: normal;
font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: 2;
text-align: -webkit-auto; text-indent:
0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px;" class=""><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><span
class="Apple-style-span"
style="border-collapse: separate;
border-spacing: 0px; "><span
class="Apple-style-span"
style="color: rgb(102, 102, 102);
font-family: Verdana, Arial,
Helvetica, sans-serif; font-size:
small; "></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span
class="Apple-style-span"
style="border-collapse: separate;
font-family: Helvetica;
border-spacing: 0px;
-webkit-text-decorations-in-effect:
none;"><span class="Apple-style-span"
style="color: rgb(102, 102, 102);
font-family: Verdana, Arial,
Helvetica, sans-serif; font-size:
small; "><span
class="Apple-style-span"
style="border-collapse: separate;
font-family: Helvetica;
border-spacing: 0px;
-webkit-text-decorations-in-effect:
none;"></span></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><br class="">
</a><span style="color: rgb(102, 102,
102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small;
" class="">Lance Andersen| Principal
Member of Technical Staff |
+1.781.442.2037</span><br style="color:
rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">
<font style="font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small;
" class="" color="#FF0000">Oracle</font><span
style="color: rgb(102, 102, 102);
font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class=""> Java
Engineering </span><br style="color:
rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">
<span style="color: rgb(102, 102, 102);
font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">1
Network Drive </span><br style="color:
rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">
<span style="color: rgb(102, 102, 102);
font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">Burlington,
MA 01803</span><br style="color:
rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">
<a href="mailto:Lance.Andersen@oracle.com"
style="font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small;
" class="" moz-do-not-send="true">Lance.Andersen@oracle.com</a></div>
<div style="font-family: Helvetica;
font-style: normal;
font-variant-ligatures: normal;
font-variant-caps: normal;
font-variant-east-asian: normal;
font-variant-position: normal;
font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: 2;
text-align: -webkit-auto; text-indent:
0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px;" class=""><br
class="">
</div>
<br class="Apple-interchange-newline">
</span></span></div>
</div>
<br class="">
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
<div class="">
<div class=""><span class="Apple-style-span"
style="border-collapse: separate; border-spacing: 0px; "><span
class="Apple-style-span" style="color: rgb(102, 102,
102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; "><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span><img
apple-inline="yes"
id="4CEB6D70-4EA6-41DE-BA71-CEDFCA445AC6"
src="cid:part12.2E8BF4BF.0ECA9A8A@oracle.com"
class=""></span></a>
<div style="color: rgb(0, 0, 0); font-family: Helvetica;
font-size: medium; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; " class=""><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span
class="Apple-style-span" style="border-collapse:
separate; border-spacing: 0px; "><span
class="Apple-style-span" style="color: rgb(102,
102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; "></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><span
class="Apple-style-span" style="border-collapse:
separate; color: rgb(0, 0, 0); font-family:
Helvetica; border-spacing: 0px;
-webkit-text-decorations-in-effect: none; "><span
class="Apple-style-span" style="color: rgb(102,
102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; "><span
class="Apple-style-span"
style="border-collapse: separate; color:
rgb(0, 0, 0); font-family: Helvetica;
border-spacing: 0px;
-webkit-text-decorations-in-effect: none; "></span></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><br class="">
</a><span style="color: rgb(102, 102, 102);
font-family: Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">Lance Andersen|
Principal Member of Technical Staff |
+1.781.442.2037</span><br style="color: rgb(102,
102, 102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">
<font style="font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class=""
color="#FF0000">Oracle</font><span style="color:
rgb(102, 102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; " class=""> Java
Engineering </span><br style="color: rgb(102, 102,
102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">
<span style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">1 Network Drive </span><br
style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">
<span style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">Burlington, MA 01803</span><br
style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">
<a href="mailto:Lance.Andersen@oracle.com"
style="font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class=""
moz-do-not-send="true">Lance.Andersen@oracle.com</a></div>
<div style="color: rgb(0, 0, 0); font-family: Helvetica;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent:
0px; text-transform: none; white-space: normal;
widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; " class=""><br
class="">
</div>
<br class="Apple-interchange-newline">
</span></span></div>
</div>
<br class="">
</div>
</blockquote>
</body>
</html>