<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Thanks for the review Hai-May. I've implemented all your
suggestions.</p>
<p>The CSR was approved late on Friday so I'll now submit this via
PR on github infra.</p>
<p>regards,<br>
Sean.<br>
</p>
<div class="moz-cite-prefix">On 28/08/2020 21:08, Hai-May Chao
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:8946D5E0-8438-43EC-A987-4FEBF5779343@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
JarSigner.java #953: The output debug message can be removed from
the code.
<div class="">JavaUtilZipFileAccess.java #44: Change posixPerms to
extraAttrs.</div>
<div class="">ZipFile.java #661: Suggest to keep the comment and
update it with the additional 4 bits for symlink.</div>
<div class=""><br class="">
</div>
<div class="">The rest of code changes and CSR look good.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Hai-May</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Aug 28, 2020, at 7:17 AM, Seán Coffey
<<a href="mailto:sean.coffey@oracle.com" class=""
moz-do-not-send="true">sean.coffey@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
<div class="">
<p class="">I've been poking around the zip
internals and am now able to locate the 16 bits of
interest. The position of these actual bits does
appear to move around from one test run to
another. For now, I guess it's sufficient to look
for the pattern of interest in the signed zip
file. New testcase added.</p>
<p class=""><a
href="http://cr.openjdk.java.net/~coffeys/webrev.8250968.v4/webrev/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~coffeys/webrev.8250968.v4/webrev/</a></p>
<p class="">regards,<br class="">
Sean.<br class="">
</p>
<div class="moz-cite-prefix">On 27/08/2020 15:58,
Weijun Wang wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:1582051D-5EDD-4F16-88D3-A064683023D3@ORACLE.COM"
class="">
<blockquote type="cite" style="" class="">
<pre class="moz-quote-pre" wrap="">Looks like it was a conscious design decision to only allow recording of POSIX permission bits for this field (& 0xFFF). I don't see anything about symlink support in zipfs docs.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">As long as that <b class="moz-txt-star"><span class="moz-txt-tag">*</span>byte<span class="moz-txt-tag">*</span></b> is there and it’s not difficult to locate, we can manually add the <b class="moz-txt-star"><span class="moz-txt-tag">*</span>bit<span class="moz-txt-tag">*</span></b> for symlink and see if jarsigner can keep it.
—Max
</pre>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</body>
</html>