<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi Götz,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">thanks for the review!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Martin<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="mso-fareast-language:DE"> Lindenmaier, Goetz <goetz.lindenmaier@sap.com>
<br>
<b>Sent:</b> Montag, 8. Februar 2021 14:18<br>
<b>To:</b> Doerr, Martin <martin.doerr@sap.com>; security-dev <security-dev@openjdk.java.net>; jdk-updates-dev@openjdk.java.net<br>
<b>Cc:</b> Langer, Christoph <christoph.langer@sap.com><br>
<b>Subject:</b> RE: [11u] RFR: 8244683: A TSA server used by tests<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN">Hi Martin,
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN">Thanks for downporting this.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN">Nice documentation of the changes! Looks good.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN"> Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:ZH-CN">From:</span></b><span lang="EN-US" style="mso-fareast-language:ZH-CN"> Doerr, Martin <<a href="mailto:martin.doerr@sap.com">martin.doerr@sap.com</a>>
<br>
<b>Sent:</b> Tuesday, February 2, 2021 9:28 PM<br>
<b>To:</b> security-dev <<a href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a>>;
<a href="mailto:jdk-updates-dev@openjdk.java.net">jdk-updates-dev@openjdk.java.net</a><br>
<b>Cc:</b> Langer, Christoph <<a href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>>; Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com">goetz.lindenmaier@sap.com</a>><br>
<b>Subject:</b> [11u] RFR: 8244683: A TSA server used by tests<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">JDK-8244683 is backported to 11.0.11-oracle. I'd like to backport it for parity.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">It doesn't apply cleanly.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">TimestampCheck.java:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- The parts which get removed contain minor differences (see [1])<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- Resolution: Take new version.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">TsaHandler.java and TsaSigner.java:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- New code contains usages of KnownOIDs which don't exist in 11u.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- Resolution: Translate them (see [2])<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">TsaSigner.java:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- New code uses ObjectIdentifier.of<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- Resolution: Change back to "new ObjectIdentifier" according to [1]<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- Uses HexPrinter (for debug code) which doesn't exist in 11u.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- Resolution: Use HexDumpEncoder instead: System.out.println(new HexDumpEncoder().encode(bytes));<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">An additional testfix is needed:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://bugs.openjdk.java.net/browse/JDK-8246709">https://bugs.openjdk.java.net/browse/JDK-8246709</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">which applies cleanly except that it needs an import change (see [3]).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">That change is not included in the webrev. I just want to push 11u backport of 8244683 together with 8246709 (including [3]) together.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Bug:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://bugs.openjdk.java.net/browse/JDK-8244683">https://bugs.openjdk.java.net/browse/JDK-8244683</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Original change:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://hg.openjdk.java.net/jdk/jdk/rev/56bda3e6d148">https://hg.openjdk.java.net/jdk/jdk/rev/56bda3e6d148</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">11u backport:<o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~mdoerr/8244683_TSA_11u/webrev.00/">http://cr.openjdk.java.net/~mdoerr/8244683_TSA_11u/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Please review.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Martin<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">[1] diff JDK11u:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java JDK16:TimestampCheck_before_8244683.java<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">65a66<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">> * 8242151<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">137c138<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">< ObjectIdentifier policyId = new ObjectIdentifier(defaultPolicyId);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">> ObjectIdentifier policyId = ObjectIdentifier.of(defaultPolicyId);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">161c162<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">< policyId = new ObjectIdentifier(defaultPolicyId);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">> policyId = ObjectIdentifier.of(defaultPolicyId);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">233c234<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">< ContentInfo contentInfo = new ContentInfo(new ObjectIdentifier(<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">> ContentInfo contentInfo = new ContentInfo(ObjectIdentifier.of(<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">[2] KnownOIDs Translation:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://github.com/openjdk/jdk/commit/080b3b83ebffe5149fbc9ac48e921fb51e9c3c63#diff-e6d5bd6b166be4737084473fcf55b0f101a710263c899c19b0df2a702c89a30e">https://github.com/openjdk/jdk/commit/080b3b83ebffe5149fbc9ac48e921fb51e9c3c63#diff-e6d5bd6b166be4737084473fcf55b0f101a710263c899c19b0df2a702c89a30e</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">[3] diff JDK16:TSA_testfix_orig.patch resolved_JDK11u:8246709_TSA.patch<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">< import jdk.test.lib.process.OutputAnalyzer;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">> import jdk.testlibrary.OutputAnalyzer;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</div>
</body>
</html>