<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 4/11/2022 9:34 PM, Valerie Peng
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:wdEJQ_q7Jqk04agwTYi7BoVXagCflQWdzqDoiczLvsM=.691c7ff7-1f75-4023-9354-9315dc3051ac@github.com">
<pre class="moz-quote-pre" wrap="">This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring.
The CSR will be filed once review is somewhat finished.
Thanks,
Valerie
-------------
Commit messages:
- 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec
Changes: <a class="moz-txt-link-freetext" href="https://git.openjdk.java.net/jdk/pull/8191/files">https://git.openjdk.java.net/jdk/pull/8191/files</a>
Webrev: <a class="moz-txt-link-freetext" href="https://webrevs.openjdk.java.net/?repo=jdk&pr=8191&range=00">https://webrevs.openjdk.java.net/?repo=jdk&pr=8191&range=00</a>
Issue: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8284553">https://bugs.openjdk.java.net/browse/JDK-8284553</a>
Stats: 42 lines in 1 file changed: 13 ins; 10 del; 19 mod
Patch: <a class="moz-txt-link-freetext" href="https://git.openjdk.java.net/jdk/pull/8191.diff">https://git.openjdk.java.net/jdk/pull/8191.diff</a>
Fetch: git fetch <a class="moz-txt-link-freetext" href="https://git.openjdk.java.net/jdk">https://git.openjdk.java.net/jdk</a> pull/8191/head:pull/8191
PR: <a class="moz-txt-link-freetext" href="https://git.openjdk.java.net/jdk/pull/8191">https://git.openjdk.java.net/jdk/pull/8191</a>
</pre>
</blockquote>
<p>Hi Valerie - <br>
</p>
<p>I think deprecating DEFAULT is wrong. RFC8017 still has this
definition:</p>
<p>
<blockquote type="cite">
<pre>RSAES-OAEP-params ::= SEQUENCE {
hashAlgorithm [0] HashAlgorithm DEFAULT sha1,
maskGenAlgorithm [1] MaskGenAlgorithm DEFAULT mgf1SHA1,
pSourceAlgorithm [2] PSourceAlgorithm DEFAULT pSpecifiedEmpty
}</pre>
</blockquote>
and DEFAULT is what you should be getting if you see an empty
sequence in the param field. It's DEFAULT in ASN1 terms, not
DEFAULT in terms of what you should use going forward to create
signatures, and the ASN1 DEFAULT won't change.<br>
</p>
<p>In any event, I can't find where RFC8017 says anything about
deprecating the defaults. AFAICT, although there's general
guidance to go away from SHA1, the math suggests that SHA1 is
still sufficient for OAEP, and there's no guidance specific to
OAEP's use of SHA1 that I can find other than the requirement in
NIST SP800-56B rev 2 to use "Approved Hash Functions" for OAEP.
If there's a section in 8017 that you're looking at for this
guidance that I missed, you may want to update your comment to
point to it.</p>
<p>Take care - Mike</p>
<p><br>
</p>
<p><br>
</p>
</body>
</html>