From Mandy.Chung at Sun.COM Thu Feb 14 14:51:17 2008 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Thu, 14 Feb 2008 14:51:17 -0800 Subject: Patch submission advice: use webrev, jtreg tests where, cmd line test? In-Reply-To: <47B455DE.6040705@ki.se> References: <47B455DE.6040705@ki.se> Message-ID: <47B4C5E5.1010309@Sun.com> Hi Lars, Thanks for getting a fix for 6523160. You can use serviceability-dev at openjdk.java.net alias for submitting the patch and I believe the change in the hotspot code is local to serviceability. My comment is inlined.... Lars Westergren wrote: > Hello, > > I have a fix ready for bug 6523160 - "RuntimeMXBean.getUptime() returns > negative values". Mandy Chung long ago suggested I use this mailing list > rather than the management mailinglist for this bug since the fix > involves changes in Hotspot code. > > > Before I submit, I wanted to clarify three things - > > 1. Should I include diff files as attachments as is recommended here: > http://openjdk.java.net/contribute/ > or do you now prefer that I use Webrev for OpenJDK as Jean-Christophe > Collet describes, so I include a link to my webrev pages in the mail > instead? > http://blogs.sun.com/jcc/ It would be great if you can use webrev. It's a very useful code-review generating tool and I'm sure you will like it. You can either include a link to your webrev (public accessible) or include the tarball of the webrev pages which is also fine with me. > 2. My jtreg tests, would you prefer them included as standalone files > attachments to the mail so you yourselves can decide where to put them, > or should I place them in the correct package in jdk/test so they become > a part of the webrev? You can just include the jtreg tests in the jdk/test/java/lang/management/RuntimeMXBean directory since the test will be specific for testing that API. I'll be able to get a copy of the test from the webrev generated. FYI. The source and test location for the serviceability project are listed at: http://openjdk.java.net/groups/serviceability/svcjdk.html > 3. Provoking the bug involves setting back the OS clock. Is it ok if I > use the command line "date" command (making the test platform dependent) > to set back the clock in the test? Or should I prefer user interaction > as is done in some other tests I've seen - i.e. popping up a window that > says "Set back the OS clock an hour now, click 'ok' when done to continue"? The jtreg tests have to be fully automated and can be run on machines that may be used by others for various purposes. In addition, changing the clock on a shared machine might cause unexpected problems to other applications/testing running on the same machine. The Java SE Quality team has several functional tests that fail due to this bug. I can help run those tests to verify your fix. We can work together. Mandy P.S. I'll be on vacation next week and return on 1/25. > > Thanks in advance, > Lars From matty91 at gmail.com Tue Feb 19 17:35:06 2008 From: matty91 at gmail.com (Matty) Date: Tue, 19 Feb 2008 20:35:06 -0500 Subject: JSDT probe documentation Message-ID: <8bfce36e0802191735n3f689f24lde88c63d22c473d8@mail.gmail.com> Howdy, Does anyone happen to know if there is any documentation on adding JSDT probes to applications? Is this functionality part of the latest openjdk source drop? Thanks, - Ryan -- UNIX Administrator http://prefetch.net From Keith.McGuigan at Sun.COM Wed Feb 20 07:12:34 2008 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Wed, 20 Feb 2008 10:12:34 -0500 Subject: [Fwd: JSDT probe documentation] In-Reply-To: <47BB856A.1000008@sun.com> References: <47BB856A.1000008@sun.com> Message-ID: <47BC4362.4010807@sun.com> ------------------------------------------------------------------------ > > Subject: > JSDT probe documentation > From: > Matty > Date: > Tue, 19 Feb 2008 20:35:06 -0500 > To: > serviceability-dev at openjdk.java.net > > To: > serviceability-dev at openjdk.java.net > > > Howdy, > > Does anyone happen to know if there is any documentation on adding > JSDT probes to applications? Is this functionality part of the latest > openjdk source drop? > > Thanks, > - Ryan Hello, The functionality hasn't gotten into the openjdk source drop quite yet. I'm hoping to get it there sometime in the next month. When I get it into the source, there are examples and information in the javadoc, and I'll probably put together an example in the samples directory as well. -- - Keith From lars.westergren at gmail.com Thu Feb 21 10:31:10 2008 From: lars.westergren at gmail.com (Lars Westergren) Date: Thu, 21 Feb 2008 19:31:10 +0100 Subject: [PATCH] 6523160: RuntimeMXBean.getUptime() returns negative values Message-ID: <7cf9cdd90802211031v42a76063q92aa24a035eca220@mail.gmail.com> Hello, First attempt at posting a solution. Sorry about the "nbproject/project.xml" in the webrev index page, a bit embarrassed that I can't seem to get Mercurial to ignore it. The test is OS dependent, and of course requires that the process that executes jtreg is root or at least has the right to set back the OS clock. Cheers, Lars -------------- next part -------------- A non-text attachment was scrubbed... Name: webrev.zip Type: application/zip Size: 392679 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20080221/70b087c1/attachment.zip From Mandy.Chung at Sun.COM Mon Feb 25 16:37:49 2008 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Mon, 25 Feb 2008 16:37:49 -0800 Subject: [PATCH] 6523160: RuntimeMXBean.getUptime() returns negative values In-Reply-To: <7cf9cdd90802211031v42a76063q92aa24a035eca220@mail.gmail.com> References: <7cf9cdd90802211031v42a76063q92aa24a035eca220@mail.gmail.com> Message-ID: <47C35F5D.2040801@sun.com> Hi Lars, Thanks for submitting the patch. Your change looks good. Some minor nits: jdk/src/share/classes/sun/management/RuntimeImpl.java The previous VM startup time in milliseconds is no longer needed in this version. You can remove the vmStartupTime variable and getStartTime method from this class. jdk/src/share/classes/sun/management/VMManagement.java jdk/src/share/classes/sun/management/VMManagementImpl.java jdk/src/share/native/sun/management/VMManagementImpl.c Similar to the comment above, you can remove the getStartupTime method. jdk/src/share/native/sun/management/VMManagementImpl.c line 194: need one additional space to align with the word "env" in the above line. jdk/test/java/lang/management/RuntimeMXBean/NegativeUptime.java This test would be useful if someone wants to verify this manually. We can attach this test in the bug report to be available for others to use. This test would not be appropriate for our test harness since the tests are run with non-privilege mode. In addition, changing the date on a test machine might be problematic to other tests running on the system which we should avoid. There are some functionality tests testing this API. I will run those tests on our machines and see if this fixes the problem. Can you send me a tarball of these modified files so that I can build a JDK with your fix? I'll let you know when I'm done testing to proceed with the hg push. Thanks Mandy Lars Westergren wrote: >Hello, > >First attempt at posting a solution. Sorry about the >"nbproject/project.xml" in the webrev index page, a bit embarrassed >that I can't seem to get Mercurial to ignore it. > >The test is OS dependent, and of course requires that the process that >executes jtreg is root or at least has the right to set back the OS >clock. > >Cheers, >Lars > From mr at sun.com Fri Feb 29 22:07:45 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:07:45 +0000 Subject: hg: jdk7/hotspot-svc: 2 new changesets Message-ID: <20080301060745.B17E326F06@hg.openjdk.java.net> Changeset: 0a5c5386a678 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/rev/0a5c5386a678 Added tag jdk7-b24 for changeset cfeea66a3fa8 + .hgtags Changeset: c57bef8dda9c Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/rev/c57bef8dda9c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:07:52 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:07:52 +0000 Subject: hg: jdk7/hotspot-svc/corba: 2 new changesets Message-ID: <20080301060754.D36C926F0D@hg.openjdk.java.net> Changeset: 474c23b174e9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/corba/rev/474c23b174e9 Added tag jdk7-b24 for changeset 55540e827aef + .hgtags Changeset: fec639c69db2 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/corba/rev/fec639c69db2 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:08:15 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:08:15 +0000 Subject: hg: jdk7/hotspot-svc/hotspot: 2 new changesets Message-ID: <20080301060821.4013F26F14@hg.openjdk.java.net> Changeset: 92489cdc94d1 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/92489cdc94d1 Added tag jdk7-b24 for changeset a61af66fc99e + .hgtags Changeset: 7836be3e92d0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/7836be3e92d0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:09:03 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:09:03 +0000 Subject: hg: jdk7/hotspot-svc/jaxp: 2 new changesets Message-ID: <20080301060907.9749C26F1B@hg.openjdk.java.net> Changeset: 9e3c1ad7cdb9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jaxp/rev/9e3c1ad7cdb9 Added tag jdk7-b24 for changeset 6ce5f4757bde + .hgtags Changeset: 49a4bc7b0aa0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jaxp/rev/49a4bc7b0aa0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:09:18 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:09:18 +0000 Subject: hg: jdk7/hotspot-svc/jaxws: 2 new changesets Message-ID: <20080301060922.467C126F22@hg.openjdk.java.net> Changeset: 7d53d3bd7879 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jaxws/rev/7d53d3bd7879 Added tag jdk7-b24 for changeset 0961a4a21176 + .hgtags Changeset: 018781e80410 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jaxws/rev/018781e80410 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:09:34 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:09:34 +0000 Subject: hg: jdk7/hotspot-svc/jdk: 2 new changesets Message-ID: <20080301061011.BA85D26F29@hg.openjdk.java.net> Changeset: 99a06bc7fdb5 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jdk/rev/99a06bc7fdb5 Added tag jdk7-b24 for changeset 37a05a11f281 + .hgtags Changeset: 8266cb7549d3 Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/jdk/rev/8266cb7549d3 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 22:12:01 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:12:01 +0000 Subject: hg: jdk7/hotspot-svc/langtools: 2 new changesets Message-ID: <20080301061205.4CC7726F30@hg.openjdk.java.net> Changeset: e4dae1993f8b Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/langtools/rev/e4dae1993f8b Added tag jdk7-b24 for changeset 9a66ca7c79fa + .hgtags Changeset: e5e9fa6fa29c Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/langtools/rev/e5e9fa6fa29c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:01:06 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:06 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20080301070106.D21DF260EE@hg.openjdk.java.net> Changeset: 0a5c5386a678 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/0a5c5386a678 Added tag jdk7-b24 for changeset cfeea66a3fa8 + .hgtags Changeset: c57bef8dda9c Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c57bef8dda9c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:01:20 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:20 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20080301070122.5C23C260F5@hg.openjdk.java.net> Changeset: 474c23b174e9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/474c23b174e9 Added tag jdk7-b24 for changeset 55540e827aef + .hgtags Changeset: fec639c69db2 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/fec639c69db2 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:01:48 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:48 +0000 Subject: hg: jdk7/tl/hotspot: 2 new changesets Message-ID: <20080301070153.C9D70260FC@hg.openjdk.java.net> Changeset: 92489cdc94d1 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/92489cdc94d1 Added tag jdk7-b24 for changeset a61af66fc99e + .hgtags Changeset: 7836be3e92d0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7836be3e92d0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:02:39 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:02:39 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20080301070242.F009126103@hg.openjdk.java.net> Changeset: 9e3c1ad7cdb9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/9e3c1ad7cdb9 Added tag jdk7-b24 for changeset 6ce5f4757bde + .hgtags Changeset: 49a4bc7b0aa0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/49a4bc7b0aa0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:02:58 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:02:58 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20080301070301.9CAA22610A@hg.openjdk.java.net> Changeset: 7d53d3bd7879 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/7d53d3bd7879 Added tag jdk7-b24 for changeset 0961a4a21176 + .hgtags Changeset: 018781e80410 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/018781e80410 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:03:17 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:03:17 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080301070353.B6CF526111@hg.openjdk.java.net> Changeset: 99a06bc7fdb5 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99a06bc7fdb5 Added tag jdk7-b24 for changeset 37a05a11f281 + .hgtags Changeset: 8266cb7549d3 Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8266cb7549d3 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Fri Feb 29 23:05:35 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:05:35 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20080301070539.3717326118@hg.openjdk.java.net> Changeset: e4dae1993f8b Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e4dae1993f8b Added tag jdk7-b24 for changeset 9a66ca7c79fa + .hgtags Changeset: e5e9fa6fa29c Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e5e9fa6fa29c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf