Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

Alan Bateman Alan.Bateman at Sun.COM
Fri Aug 21 09:35:01 PDT 2009


Kelly O'Hair wrote:
> Kelly O'Hair wrote:
>>
>> Still need reviewer ...
>>
>>   6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project
>>
>>   
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ 
>>
>>
>> Pretty harmless code cleanup on the tool used to generate
>> some of the JDWP code for the debugger.
>
> The webrev has been updated.
>
> The field constantMap is now final.
>
> The throw in Main.java usage() is gone and use of usage() is now 
> followed by
> a simple return from main().
>
> Thanks for the reviews from Andrew, Alan, and Tim.
>
> Let me know if this looks ok now.
The updated webrev looks good to me.

-Alan.


More information about the serviceability-dev mailing list