Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

swamy Swamy.Venkataramanappa at Sun.COM
Fri Aug 21 09:44:44 PDT 2009


Looks good to me. 

In this file:

http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/make/netbeans/jdwpgen/nbproject/project.properties.html

   1 application.title=jdwpgen
   2 application.vendor=ohair

Shouldn't this be Sun Microsystems or ...

-Swamy


Andrew John Hughes wrote:
> 2009/8/21 Kelly O'Hair <Kelly.Ohair at sun.com>:
>   
>> Kelly O'Hair wrote:
>>     
>>> Still need reviewer ...
>>>
>>>  6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project
>>>
>>>
>>>  http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/
>>>
>>> Pretty harmless code cleanup on the tool used to generate
>>> some of the JDWP code for the debugger.
>>>       
>> The webrev has been updated.
>>
>> The field constantMap is now final.
>>
>> The throw in Main.java usage() is gone and use of usage() is now followed by
>> a simple return from main().
>>
>> Thanks for the reviews from Andrew, Alan, and Tim.
>>
>> Let me know if this looks ok now.
>>
>> -kto
>>
>>     
>
> Looks ok to me.
>   



More information about the serviceability-dev mailing list