Allow Java's ELF symtab reader to use separate debuginfo files

[Andrew John Hughes]

2009/12/9 Andrew Haley <aph at redhat.com>:
> Andrew John Hughes wrote:
>> 2009/12/9 Andrew Haley <aph at redhat.com>:
>>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548
>>> The symptom is that jmap doesn't work because target libraries are stripped.
>>> The fix is to allow the symtab reader to use the separate debuginfo files
>>> that are available for all (AFAIK) GNU/Linux distributions.
>>>
>>> I'll commit this to the IcedTea repo, with a view to pushing it upstream
>>> to OpenJDK if it works on all distros.
>>
>> It would be good to see this upstream.  The obvious compatibility
>> issue I can see is hardcoding /usr/lib/debug.  Passing that in from
>> the Makefile, thus allowing to be overridden if necessary, might be
>> better.
>> i.e.
>>
>> static const char debug_file_directory[] = "/usr/lib/debug";
>>
>> becomes
>>
>> #ifndef DEBUG_FILE_DIRECTORY
>> #define DEBUG_FILE_DIRECTORY "/usr/lib/debug"
>> #endif
>>
>> with apppropriate logic in the OpenJDK makefile(s).
>
> I think this directory is generally assumed to be hard-coded everywhere.  I
> will make such a change if this patch won't be committed otherwise, but I do
> not believe that it will ever be used.
>

Ah, ok.  This was the only possibly distro-specific issue I could see
in the patch.

>> Only other comment is that your ChangeLog should refer to openjdk, not
>> openjdk-ecj as we want this for all builds. The patch itself is
>> correct, it's just the ChangeLog.
>
> Yeah, I noticed this already.
>
> Thanks,
> Andrew.
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8