Need reviewers - 3 bugs

[Andrew John Hughes]

2009/12/10 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
>
> Andrew John Hughes wrote:
>>
>> 2009/11/18 Kelly O'Hair <Kelly.Ohair at sun.com>:
>>>
>>> Need a reviewer.
>>>
>>> The jhat change is from keith.randall at gmail.com. I wasn't able to
>>> come up with a testcase for that change.
>>>
>>> The other two just fix a couple of broken tests and remove them from
>>> the ProblemList.
>>>
>>> 6892742: Improve root set used by jhat
>>> 6902323: Fix testcase sun/tools/native2ascii/NativeErrors.java
>>> 6902325: Fix testcase sun/tools/jhat/HatHeapDump1Test.java
>>>
>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jhat-6892742/webrev/
>>>
>>> -kto
>>>
>>>
>>>
>>
>> Pretty much the same fix for the JHat issue was filed by one of our
>> Red Hat interns in March:
>>
>> http://bugs.openjdk.java.net/show_bug.cgi?id=100026
>>
>> but sadly completely ignored by anyone at Sun (at least it seems so
>> from the bug report).  This is one reason why I've tended to not
>> bother with the OpenJDK bug system...
>>
>
> Sorry. I already have to deal with Sun's internal bug tracking system,
> and also JIRA for JavaFX. Learning my way around bugzilla has not been
> high my list. I get lost and tired of waiting every time I get into
> the bugzilla pages. :^(  I suspect most Sun people may be in the same boat.
>

I didn't mean it as a personal attack, and I apologise if it sounded
like that.  Anyway, we're equally guilty for not following up on the
lack of response :)

It was more a comment on the usefulness of the OpenJDK bug DB.  I
don't feel it's really helped anything, but just added another thing
to check on both for those of us working on IcedTea (who already have
the IcedTea bug DB and various distro-specific ones) and Sun
engineers, who as you also point out already have to check the Sun bug
DB and other project DBs.   Moreover,  to actually push the bug, it
has to have a Sun bug ID anyway.  So I can empathise with you because
we're in the same boat here.

I am glad that this thread has inspired people to go and look at the
DB and hopefully resurrect some of them from this graveyard.

> How could I at least see some email on these bugs?
> Aren't they connected to the various openjdk email aliases?
>
> Sorry I'm not bugzilla-savy. :^(
>
>> Anyway, coming to merge that with the version now in OpenJDK6 version
>> I found that the upstream doesn't update the comment.  So perhaps we
>> could push:
>>
>> http://cr.openjdk.java.net/~andrew/jhat/webrev.01/
>>
>> given a bug ID for this small change.
>
> 6909442: Fix comments in test/sun/tools/jhat/HatRun.java
>

Cheers.  Is tl ok for this one?  That seems to be the one for
serviceability issues now.

> -kto
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8