Need reviewer - two fixes for one

Tim Bell Tim.Bell at Sun.COM
Tue Jul 7 16:56:03 PDT 2009


Hi Kelly
> Need reviewer.
> 
> 6855551: java -Xrunhprof crashes when running with classes compiled with 
> targed=7
>   Related to 6855180, assert logic could get segv, investigation found 
> next one.
> 
> 6858127: Missing -DNDEBUG on Linux and Windows native code compiles
>   The C/C++ macro NDEBUG when defined turns assert() macros into 
> nothingness.
>   These assert() macros are for debug builds, not product builds, when
>   an assert fails, it prints out information and typically exits the 
> process.
> 
> Webrev:
>   http://cr.openjdk.java.net/~ohair/jdk7/jdk7-tl-6855551%2b6858127/webrev/

Looks good to me - Approved!

Tim



More information about the serviceability-dev mailing list