JVMTI OOM handling when arrays / objects are too large

[Alan Bateman]

Martin Buchholz wrote:
> Alright, I have a new simple version of the hotspot part of the
> jvmti-oom fix that should make Alan happy.
>
> ...Except for the usual problem that the code is screaming
> for a bit of refactoring, and it's not quite clear what file
> and function name it should be refactored to.  I'll do the
> easy refactoring if you give me the names to use.
> Or simply give me thumbs up and I will commit.
>
> http://cr.openjdk.java.net/~martin/jvmti-oom/ 
> <http://cr.openjdk.java.net/%7Emartin/jvmti-oom/>
> http://cr.openjdk.java.net/~martin/jvmti-oom-test/ 
> <http://cr.openjdk.java.net/%7Emartin/jvmti-oom-test/>
>
> Thanks,
>
> Martin
The changes you have are simple and address the need. As I said 
previously, I'm not working in this area regularly now so it would be 
good to have someone from runtime to review too, as I'm sure they will 
have better ideas for refactoring this. Clearly the hooks in 
collectedHeap.inline.hpp could be improved (these functions have grown, 
and I wonder if they are still inlined now).

I meant to ask, but did you consider adding a test in the hotspot 
repository rather than updating the ProcessBuilder test in the jdk 
repository? I realize its a bit of extra work to do this.

-Alan.