Need reviewers - 3 bugs
Kelly O'Hair
Kelly.Ohair at Sun.COM
Wed Nov 18 11:06:42 PST 2009
Daniel D. Daugherty wrote:
> Kelly O'Hair wrote:
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jhat-6892742/webrev/
> Thumbs up.
>
> src/share/classes/com/sun/tools/hat/internal/model/JavaStatic.java
> No comments.
>
> test/ProblemList.txt
> No comments. Is this file automatically or manually updated?
>
manually.
> test/sun/tools/jhat/HatRun.java
> No content comments. I'm presuming that cdir is the current dir.
>
cdir is test.classes or the directory where the classes built land.
My experience has been that with samevm, it's not necessarily the same
as the current directory.
> test/sun/tools/native2ascii/NativeErrors.java
> No content comments. I wonder if there are any other Teamware
> assumptions like this.
I bet there are, but unless people start investigating why the tests
are failing, we will never know. So this may take some time.
-kto
More information about the serviceability-dev
mailing list