Need reviewer - jdi tests fixes

Daniel D. Daugherty Daniel.Daugherty at Sun.COM
Tue Nov 24 13:46:06 PST 2009


Kelly O'Hair wrote:
> Need reviewer on changes to the com/sun/jdi tests.
>
> 6904183: Fix jdk/test/com/sun/jdi tests to run with -samevm
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes/webrev/
>
> The com/sun/jdi tests can run with 'jtreg -samevm' with these changes.
> Although not all these changes had to do with -samevm.
>
> Multiple issues fixed:
>   * Solaris amd64 not being tested in multiple places
>   * Assumptions that the current directory was also the classes dir
>     (Added "-classpath test.classes" in multiple places).
>   * Made a few tests permanently 'othervm'
>   * Removed SimulResumerTest.java and RedefineException.sh from the
>     problem list for now. (No jdi tests would be on the problem list)

None of these comments are "must do".

test/Makefile
    No comments.

test/ProblemList.txt
    Why comment out the entries instead of removing them?

test/com/sun/jdi/BadHandshakeTest.java
    This alternate architecture stuff is screaming for a
    refactoring. Can you file a new bug to document that
    we need to do that?

test/com/sun/jdi/DoubleAgentTest.java
    No comments.

test/com/sun/jdi/ExclusiveBind.java
    No comments.

test/com/sun/jdi/JITDebug.sh
    No comments.

test/com/sun/jdi/RepStep.java
    You might want to add a comment about why this has
    to be an "othervm" test.

test/com/sun/jdi/RunToExit.java
    You might want to add a comment about why this has
    to be an "othervm" test. Although, if the test name
    is a good clue, then...

test/com/sun/jdi/SimulResumerTest.java
    You might want to add a comment about why this has
    to be an "othervm" test.

test/com/sun/jdi/Solaris32AndSolaris64Test.sh
    No comments.

test/com/sun/jdi/VMConnection.java
    No comments.

test/com/sun/jdi/connect/spi/DebugUsingCustomConnector.java
    You might want to add a comment about why this has
    to be an "othervm" test.

test/com/sun/jdi/connect/spi/GeneratedConnectors.java
    You might want to add a comment about why this has
    to be an "othervm" test.

test/com/sun/jdi/connect/spi/SimpleLaunchingConnector.java
    Did the original test really have an empty string as
    part of the command?

test/com/sun/jdi/redefine/RedefineTest.java
    You might want to add a comment about why this has
    to be an "othervm" test. Although, I suspect that all
    "redefine" tests have to be "othervm".


More information about the serviceability-dev mailing list