From Ulf.Zibis at gmx.de Tue Sep 1 01:29:53 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 01 Sep 2009 10:29:53 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <20090831221217.2CEFA12912@hg.openjdk.java.net> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> Message-ID: <4A9CDB81.1050500@gmx.de> Martin, I like how you have enhanced javadoc for Character class. Some coments: - You more like uppercased hex literals, so we are 2. :-) - you have mixed value and {@code value}. I more like the latter, it's compact and better readable - you have mixed U+1234 and \u1234 style. Why? - often you use '\' for '\', but not ever (e.g. '\t'). I think we can use always '\'. There should not be so much developers in the world who can't decode ISO-8859-1 or UTF-xx. (aren't there many places in the JDK's javadoc where others have used ISO-8859-1 characters ?) - there are many "Character#xYz" or even "java.lang.Character#xYz" or " "java.lang.Abc#xYz" " links left. They could be truncated for better readability and smaller source size - I would like to see backwards-referring like: public static final int MIN_CODE_POINT = MIN_VALUE; public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; -Ulf Am 01.09.2009 00:11, martinrb at google.com schrieb: > Changeset: db5d6b4cbc11 > Author: martin > Date: 2009-08-31 15:00 -0700 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5d6b4cbc11 > > 6860431: Character.isSurrogate(char ch) > Summary: Add new method Character.isSurrogate(char ch) > Reviewed-by: sherman, darcy, okutsu > > From maurizio.cimadamore at sun.com Tue Sep 1 07:01:43 2009 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 01 Sep 2009 14:01:43 +0000 Subject: hg: jdk7/tl/langtools: 6650759: Inference of formal type parameter (unused in formal parameters) is not performed Message-ID: <20090901140148.62F2C12978@hg.openjdk.java.net> Changeset: dda7e13f09fb Author: mcimadamore Date: 2009-09-01 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dda7e13f09fb 6650759: Inference of formal type parameter (unused in formal parameters) is not performed Summary: propagate inference constraints from 15.12.2.7 to 15.12.2.8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/generics/inference/6302954/T6476073.java ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712e.out + test/tools/javac/generics/inference/6650759/T6650759a.java + test/tools/javac/generics/inference/6650759/T6650759b.java + test/tools/javac/generics/inference/6650759/T6650759c.java + test/tools/javac/generics/inference/6650759/T6650759d.java + test/tools/javac/generics/inference/6650759/T6650759e.java + test/tools/javac/generics/inference/6650759/T6650759f.java + test/tools/javac/generics/inference/6650759/T6650759g.java + test/tools/javac/generics/inference/6650759/T6650759h.java + test/tools/javac/generics/inference/6650759/T6650759i.java + test/tools/javac/generics/inference/6650759/T6650759j.java + test/tools/javac/generics/inference/6650759/T6650759k.java + test/tools/javac/generics/inference/6650759/T6650759l.java + test/tools/javac/generics/inference/6650759/T6650759m.java + test/tools/javac/generics/inference/6650759/T6650759m.out From jonathan.gibbons at sun.com Tue Sep 1 11:43:17 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 01 Sep 2009 18:43:17 +0000 Subject: hg: jdk7/tl/langtools: 6877763: update langtools/test/Makefile for JPRT Message-ID: <20090901184328.8E6481298A@hg.openjdk.java.net> Changeset: 40a1327a5283 Author: jjg Date: 2009-09-01 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40a1327a5283 6877763: update langtools/test/Makefile for JPRT Reviewed-by: ohair ! test/Makefile From Ulf.Zibis at gmx.de Tue Sep 1 18:55:16 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 03:55:16 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9CDB81.1050500@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> Message-ID: <4A9DD084.6010406@gmx.de> I have separated the "cosmetics": https://bugs.openjdk.java.net/attachment.cgi?id=140&action=diff https://bugs.openjdk.java.net/attachment.cgi?id=141&action=diff -Ulf Am 01.09.2009 10:29, Ulf Zibis schrieb: > Martin, > > I like how you have enhanced javadoc for Character class. > > Some comments: > - You more like uppercased hex literals, so we are 2. :-) > - you have mixed value and {@code value}. I more like the > latter, it's compact and better readable > - you have mixed U+1234 and \u1234 style. Why? > - often you use '\' for '\', but not ever (e.g. '\t'). I think we > can use always '\'. There should not be so much developers in the > world who can't decode ISO-8859-1 or UTF-xx. > (aren't there many places in the JDK's javadoc where others have used > ISO-8859-1 characters ?) > - there are many "Character#xYz" or even "java.lang.Character#xYz" or > " "java.lang.Abc#xYz" " links left. They could be truncated for better > readability and smaller source size > - I would like to see backwards-referring like: > public static final int MIN_CODE_POINT = MIN_VALUE; > public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; > > -Ulf > > > Am 01.09.2009 00:11, martinrb at google.com schrieb: >> Changeset: db5d6b4cbc11 >> Author: martin >> Date: 2009-08-31 15:00 -0700 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5d6b4cbc11 >> >> 6860431: Character.isSurrogate(char ch) >> Summary: Add new method Character.isSurrogate(char ch) >> Reviewed-by: sherman, darcy, okutsu >> >> > > From martinrb at google.com Tue Sep 1 20:21:12 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 1 Sep 2009 20:21:12 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9CDB81.1050500@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> Message-ID: <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote: > Martin, > > I like how you have enhanced javadoc for Character class. > > Some coments: > - You more like uppercased hex literals, so we are 2. :-) I like consistency more than I like either uppercase or lowercase. > > - you have mixed value and {@code value}. I more like the > latter, it's compact and better readable {@code is now the preferred way. I tried to modify the methods I changed, but didn't try to change the whole file. A brave person such as yourself could try to become "code janitor" for the whole jdk. - you have mixed U+1234 and \u1234 style. Why? They are different things. U+1234 describes a Unicode character or codepoint, while '\u1234' is a char (code unit, not code point). See Unicode glossary. > - often you use '\' for '\', but not ever (e.g. '\t'). I think we can > use always '\'. There should not be so much developers in the world who > can't decode ISO-8859-1 or UTF-xx. We try hard to keep source code ASCII. Sorry, the world is adopting UTF-8, but the transition is rather slow. Maybe in 10 years we can go UTF-8 everywhere. (aren't there many places in the JDK's javadoc where others have used > ISO-8859-1 characters ?) > - there are many "Character#xYz" or even "java.lang.Character#xYz" or " > "java.lang.Abc#xYz" " links left. They could be truncated for better > readability and smaller source size I agree. > > - I would like to see backwards-referring like: > public static final int MIN_CODE_POINT = MIN_VALUE; > public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; Those would work, but would add to the confusion between code points and UTF-16 code units. Notice how "MAX_VALUE + 1" looks like an oxymoron. Martin > > > -Ulf > > > Am 01.09.2009 00:11, martinrb at google.com schrieb: > >> Changeset: db5d6b4cbc11 >> Author: martin >> Date: 2009-08-31 15:00 -0700 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5d6b4cbc11 >> >> 6860431: Character.isSurrogate(char ch) >> Summary: Add new method Character.isSurrogate(char ch) >> Reviewed-by: sherman, darcy, okutsu >> >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090901/f1d83648/attachment.html From Ulf.Zibis at gmx.de Wed Sep 2 01:07:27 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 10:07:27 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> Message-ID: <4A9E27BF.8000905@gmx.de> Am 02.09.2009 05:21, Martin Buchholz schrieb: > > > On Tue, Sep 1, 2009 at 01:29, Ulf Zibis > wrote: > > > {@code is now the preferred way. I tried to modify the methods I changed, > but didn't try to change the whole file. You also have added old style, so I asked why you have mixed it: /** - * The minimum value of a Unicode surrogate code unit in the UTF-16 encoding. + * The minimum value of a Unicode surrogate code unit in the + * UTF-16 encoding, constant '\uD800'. * * @since 1.5 */ public static final char MIN_SURROGATE = MIN_HIGH_SURROGATE; > A brave person such as yourself could try to > become "code janitor" for the whole jdk. In this case it should be simple to replace ... against {@code ...} on the whole JDK. My problem is, that I don't have the CPU-power to build the JDK, and check the whole javadoc if it would have broken. > > > - you have mixed U+1234 and \u1234 style. Why? > > > They are different things. U+1234 describes a Unicode character or > codepoint, > while '\u1234' is a char (code unit, not code point). > See Unicode glossary. Yes, after a closer look I can see the point, so I corrected their usage where I thought, it was wrong. But what's about using {@code U+10000}, found for MIN_SUPPLEMENTARY_CODE_POINT javadoc ? "U+10000" is not valid java code, but I must admit, that it looks better than "0x010000" Maybe we must use U+10000 here. > > > - often you use '\' for '\', but not ever (e.g. '\t'). I think > we can use always '\'. There should not be so much developers in > the world who can't decode ISO-8859-1 or UTF-xx. > > > We try hard to keep source code ASCII. Sorry, the world is adopting > UTF-8, > but the transition is rather slow. Maybe in 10 years we can go UTF-8 > everywhere. I have been fallen into a trap: '\' *is* ASCII, it's '\u005C'. so is there any reason remaining on '\' ??? > > > > > - I would like to see backwards-referring like: > public static final int MIN_CODE_POINT = MIN_VALUE; > public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE > + 1; > > > Those would work, but would add to the confusion > between code points and UTF-16 code units. > Notice how "MAX_VALUE + 1" looks like an oxymoron. > ;-) But I don't have any problem as I don't have using Byte.MAX_VALUE + 1. The real source of the confusion is elsewhere, i.e. imagine we would have class Integer managing 16 + 32 bit values. Maybe it would become more clear adding MAX_SUPPLEMENTARY_CODE_POINT for *consistency* and having following order: (Note that I added " of type {@code int}", similar to description of MIN_VALUE.) /** * The minimum value of a * * Unicode code point, constant {@code U+0000} * of type {@code int}. * * @since 1.5 */ public static final int MIN_CODE_POINT = MIN_VALUE; /** * The minimum value of a * * Unicode supplementary code point, constant {@code U+10000} * of type {@code int}. * * @since 1.5 */ public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; /** * The maximum value of a * * Unicode code point, constant {@code U+10FFFF} * of type {@code int}. * * @since 1.5 */ public static final int MAX_CODE_POINT = 0X10FFFF; /** * The maximum value of a * * Unicode supplementary code point, constant {@code U+10FFFF} * of type {@code int}. * * @since 1.7 */ public static final int MAX_SUPPLEMENTARY_CODE_POINT = MAX_CODE_POINT; -Ulf > Martin > > > > > -Ulf > > > Am 01.09.2009 00:11, martinrb at google.com > schrieb: > > Changeset: db5d6b4cbc11 > Author: martin > Date: 2009-08-31 15:00 -0700 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5d6b4cbc11 > > 6860431: Character.isSurrogate(char ch) > Summary: Add new method Character.isSurrogate(char ch) > Reviewed-by: sherman, darcy, okutsu > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090902/432dc62b/attachment.html From poonam.bajaj at sun.com Wed Sep 2 02:25:53 2009 From: poonam.bajaj at sun.com (poonam.bajaj at sun.com) Date: Wed, 02 Sep 2009 09:25:53 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6858208: jvm crash when specifying TypeProfileWidth=0 on jdk 6.0 Message-ID: <20090902092603.598FB12A1D@hg.openjdk.java.net> Changeset: 6918603297f7 Author: poonam Date: 2009-09-01 23:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6918603297f7 6858208: jvm crash when specifying TypeProfileWidth=0 on jdk 6.0 Summary: Add an explicit check for TypeProfileWidth == 0 in record_klass_in_profile_helper() functions. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp From Ulf.Zibis at gmx.de Wed Sep 2 02:42:26 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 11:42:26 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> Message-ID: <4A9E3E02.6050503@gmx.de> Am 02.09.2009 05:21, Martin Buchholz schrieb: > > > - I would like to see backwards-referring like: > public static final int MIN_CODE_POINT = MIN_VALUE; > public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE > + 1; > > > Those would work, but would add to the confusion > between code points and UTF-16 code units. > Notice how "MAX_VALUE + 1" looks like an oxymoron. > ;-) But I don't have any problem as I don't have using Byte.MAX_VALUE + 1. The real source of the confusion is elsewhere, i.e. imagine we would have class Integer managing 16 + 32 bit values. Maybe it would become more clear adding MAX_SUPPLEMENTARY_CODE_POINT for *consistency* and having following order: (Note that I added " of type {@code int}", similar to description of MIN_VALUE.) /** * The minimum value of a * * Unicode code point, constant {@code U+0000} * of type {@code int}. * * @since 1.5 */ public static final int MIN_CODE_POINT = MIN_VALUE; /** * The minimum value of a * * Unicode supplementary code point, constant {@code U+10000} * of type {@code int}. * * @since 1.5 */ public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; /** * The maximum value of a * * Unicode code point, constant {@code U+10FFFF} * of type {@code int}. * * @since 1.5 */ public static final int MAX_CODE_POINT = 0X10FFFF; /** * The maximum value of a * * Unicode supplementary code point, constant {@code U+10FFFF} * of type {@code int}. * * @since 1.7 */ public static final int MAX_SUPPLEMENTARY_CODE_POINT = MAX_CODE_POINT; Having following would be useful too: public static final byte MIN_ASCII = MIN_VALUE; public static final byte MAX_ASCII = Byte.MAX_VALUE; -Ulf -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090902/05756d5f/attachment-0001.html From martinrb at google.com Wed Sep 2 09:27:39 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Sep 2009 09:27:39 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9E27BF.8000905@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> Message-ID: <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> On Wed, Sep 2, 2009 at 01:07, Ulf Zibis wrote: > Am 02.09.2009 05:21, Martin Buchholz schrieb: > > > > On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote: > > > {@code is now the preferred way. I tried to modify the methods I changed, > but didn't try to change the whole file. > > > You also have added old style, so I asked why you have mixed it: > > /** > - * The minimum value of a Unicode surrogate code unit in the UTF-16 encoding. > + * The minimum value of a Unicode surrogate code unit in the > + * UTF-16 encoding, constant '\uD800'. > * > * @since 1.5 > */ > public static final char MIN_SURROGATE = MIN_HIGH_SURROGATE; > > I would have used {@code here if I could figure out how to make it work ("\" shows up literally in the generated output). > > A brave person such as yourself could try to > become "code janitor" for the whole jdk. > > > In this case it should be simple to replace ... against {@code > ...} on the whole JDK. My problem is, that I don't have the CPU-power to > build the JDK, and check the whole javadoc if it would have broken. > Building the javadoc requires a lot of memory - a javadoc bug - someone could try to fix that... - you have mixed U+1234 and \u1234 style. Why? They are different things. U+1234 describes a Unicode character or codepoint, while '\u1234' is a char (code unit, not code point). See Unicode glossary. Yes, after a closer look I can see the point, so I corrected their usage > where I thought, it was wrong. > But what's about using {@code U+10000}, found for > MIN_SUPPLEMENTARY_CODE_POINT javadoc ? > "U+10000" is not valid java code, but I must admit, that it looks better > than "0x010000" > Maybe we must use U+10000 here. > > > >> - often you use '\' for '\', but not ever (e.g. '\t'). I think we can >> use always '\'. There should not be so much developers in the world who >> can't decode ISO-8859-1 or UTF-xx. > > > We try hard to keep source code ASCII. Sorry, the world is adopting UTF-8, > but the transition is rather slow. Maybe in 10 years we can go UTF-8 > everywhere. > > > I have been fallen into a trap: '\' *is* ASCII, it's '\u005C'. so is > there any reason remaining on '\' ??? > \uXXXX has special meaning in java source files, even in comments. - I would like to see backwards-referring like: public static final int MIN_CODE_POINT = MIN_VALUE; > public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; Those would work, but would add to the confusion between code points and UTF-16 code units. Notice how "MAX_VALUE + 1" looks like an oxymoron. ;-) > But I don't have any problem as I don't have using Byte.MAX_VALUE + 1. > The real source of the confusion is elsewhere, i.e. imagine we would have > class Integer managing 16 + 32 bit values. > > Maybe it would become more clear adding MAX_SUPPLEMENTARY_CODE_POINT for > *consistency* and having following order: > MAX_SUPPLEMENTARY_CODE_POINT would not be a bad thing to have, but not compelling enough for the effort involved with any change to java se. People who use these constants anyways have to understand the model - that code points are divided into bmp and supplementary. Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090902/8dd2100d/attachment.html From david.lloyd at redhat.com Wed Sep 2 09:40:09 2009 From: david.lloyd at redhat.com (David M. Lloyd) Date: Wed, 02 Sep 2009 11:40:09 -0500 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> Message-ID: <4A9E9FE9.7060107@redhat.com> On 09/02/2009 11:27 AM, Martin Buchholz wrote: > On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > wrote: > Am 02.09.2009 05:21, Martin Buchholz schrieb: >> On Tue, Sep 1, 2009 at 01:29, Ulf Zibis > > wrote: >> >> {@code is now the preferred way. I tried to modify the methods I >> changed, >> but didn't try to change the whole file. > > You also have added old style, so I asked why you have mixed it: > > /** > - * The minimum value of a Unicode surrogate code unit in the UTF-16 > encoding. > + * The minimum value of a Unicode surrogate code unit in the > + * UTF-16 encoding, constant '\uD800'. > * > * @since 1.5 > */ > public static final char MIN_SURROGATE = MIN_HIGH_SURROGATE; > > I would have used {@code here if I could figure out > how to make it work > ("\" shows up literally in the generated output). Why not just do {@code \uD800}? I'm like 60% sure that would work just fine. :-) - DML From martinrb at google.com Wed Sep 2 10:03:42 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Sep 2009 10:03:42 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9E9FE9.7060107@redhat.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> Message-ID: <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd wrote: > On 09/02/2009 11:27 AM, Martin Buchholz wrote: > >> On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > Ulf.Zibis at gmx.de>> wrote: >> Am 02.09.2009 05:21, Martin Buchholz schrieb: >> >>> On Tue, Sep 1, 2009 at 01:29, Ulf Zibis >> > wrote: >>> >>> {@code is now the preferred way. I tried to modify the methods I >>> changed, >>> but didn't try to change the whole file. >>> >> >> You also have added old style, so I asked why you have mixed it: >> >> /** >> - * The minimum value of a Unicode surrogate code unit in the UTF-16 >> encoding. >> + * The minimum value of a Unicode surrogate code unit in the >> + * UTF-16 encoding, constant '\uD800'. >> * >> * @since 1.5 >> */ >> public static final char MIN_SURROGATE = MIN_HIGH_SURROGATE; >> >> I would have used {@code here if I could figure out >> how to make it work >> ("\" shows up literally in the generated output). >> > > Why not just do {@code \uD800}? I'm like 60% sure that would work just > fine. :-) > I'm pretty sure it would fail. Prove me wrong! Searching the JDK sources for regex ^ *\*.*\\u[0-9a-fA-F]{4} is a good way to find javadoc bugs, e.g. http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() Martin > - DML > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090902/2d3399cb/attachment.html From david.lloyd at redhat.com Wed Sep 2 10:11:53 2009 From: david.lloyd at redhat.com (David M. Lloyd) Date: Wed, 02 Sep 2009 12:11:53 -0500 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> Message-ID: <4A9EA759.3050804@redhat.com> On 09/02/2009 12:03 PM, Martin Buchholz wrote: > On Wed, Sep 2, 2009 at 09:40, David M. Lloyd > wrote: > Why not just do {@code \uD800}? I'm like 60% sure that would work > just fine. :-) > > > I'm pretty sure it would fail. Prove me wrong! > Searching the JDK sources for regex > ^ *\*.*\\u[0-9a-fA-F]{4} > is a good way to find javadoc bugs, e.g. > http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() Ah, you're right. It worked in my previewer but not in the actual javadoc. It's pretty bad that that sequence has special meaning but you can't escape a \ with another \. I guess in the worst case you could always do \u005CD800 or something like that. - DML From jonathan.gibbons at sun.com Wed Sep 2 10:29:18 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 02 Sep 2009 17:29:18 +0000 Subject: hg: jdk7/tl/langtools: 6874249: Check has duplicate local variable and field for "source" Message-ID: <20090902172924.4036112A6E@hg.openjdk.java.net> Changeset: 8d999cb7ec09 Author: jjg Date: 2009-09-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8d999cb7ec09 6874249: Check has duplicate local variable and field for "source" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java From Ulf.Zibis at gmx.de Wed Sep 2 12:46:36 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 21:46:36 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> Message-ID: <4A9ECB9C.9060105@gmx.de> Am 02.09.2009 18:27, Martin Buchholz schrieb: > > > On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > wrote: > > Am 02.09.2009 05:21, Martin Buchholz schrieb: > > /** > - * The minimum value of a Unicode surrogate code unit in the > UTF-16 encoding. > + * The minimum value of a Unicode surrogate code unit in the > + * UTF-16 encoding, constant '\uD800'. > * > * @since 1.5 > */ > public static final char MIN_SURROGATE = MIN_HIGH_SURROGATE; > > > I would have used {@code here if I could figure out > how to make it work > ("\" shows up literally in the generated output). Could this be seen as a bug? IMHO the {@code construct should be a 100% replaceable for . Any Bug Id ? > > > >> A brave person such as yourself could try to >> become "code janitor" for the whole jdk. > > In this case it should be simple to replace ... > against {@code ...} on the whole JDK. My problem is, that I don't > have the CPU-power to build the JDK, and check the whole javadoc > if it would have broken. > > > Building the javadoc requires a lot of memory - > a javadoc bug - someone could try to fix that... ... but as we see, simply replacing ... against {@code ...} in the whole JDK would not work. :-( > > Yes, after a closer look I can see the point, so I corrected their > usage where I thought, it was wrong. > But what's about using {@code U+10000}, found for > MIN_SUPPLEMENTARY_CODE_POINT javadoc ? > "U+10000" is not valid java code, but I must admit, that it looks > better than "0x010000" > Maybe we must use U+10000 here. > No answer. Does that mean, {@code U+10000} is valid? > >> - I would like to see backwards-referring like: public static final >> int MIN_CODE_POINT = MIN_VALUE; >> >> public static final int MIN_SUPPLEMENTARY_CODE_POINT = >> MAX_VALUE + 1; >> >> >> Those would work, but would add to the confusion >> between code points and UTF-16 code units. >> Notice how "MAX_VALUE + 1" looks like an oxymoron. >> > ;-) > But I don't have any problem as I don't have using Byte.MAX_VALUE + 1. > The real source of the confusion is elsewhere, i.e. imagine we > would have class Integer managing 16 + 32 bit values. > > Maybe it would become more clear adding > MAX_SUPPLEMENTARY_CODE_POINT for *consistency* and having > following order: > > > MAX_SUPPLEMENTARY_CODE_POINT would not be a bad thing to have, > but not compelling enough for the effort involved with any change to > java se. :-( ... but changing the order would decrease the confusion ? -Ulf -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090902/0eeedd83/attachment.html From Ulf.Zibis at gmx.de Wed Sep 2 12:46:52 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 21:46:52 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9EA759.3050804@redhat.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> Message-ID: <4A9ECBAC.7060303@gmx.de> Am 02.09.2009 19:11, David M. Lloyd schrieb: > On 09/02/2009 12:03 PM, Martin Buchholz wrote: >> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd > > wrote: >> Why not just do {@code \uD800}? I'm like 60% sure that would work >> just fine. :-) >> >> >> I'm pretty sure it would fail. Prove me wrong! >> Searching the JDK sources for regex >> ^ *\*.*\\u[0-9a-fA-F]{4} >> is a good way to find javadoc bugs, e.g. >> http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() >> > > Ah, you're right. It worked in my previewer but not in the actual > javadoc. It's pretty bad that that sequence has special meaning but > you can't escape a \ with another \. I guess in the worst case you > could always do \u005CD800 or something like that. > Looks little better, but not much. Did somebody tried it (Martin)? If it works in a previewer, is there any chance to change the javadoc spec, staying backwards compatible? -Ulf From Ulf.Zibis at gmx.de Wed Sep 2 13:12:10 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 22:12:10 +0200 Subject: hg: jdk7/tl/jdk: 16 new changesets In-Reply-To: <20090830070022.D6A6B12820@hg.openjdk.java.net> References: <20090830070022.D6A6B12820@hg.openjdk.java.net> Message-ID: <4A9ED19A.7050608@gmx.de> Am 30.08.2009 08:54, tim.bell at sun.com schrieb: > Changeset: 4c6a5ea563ba > Author: peytoia > Date: 2009-07-30 14:45 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4c6a5ea563ba > > 6866243: Javadoc for java.lang.Character still refers to Unicode 4 instead of 5 > Reviewed-by: okutsu > > ! src/share/classes/java/lang/Character.java > There is still a reference to Unicode 4. See comment in method toUpperCaseCharArray(int codePoint). -Ulf From martinrb at google.com Wed Sep 2 13:29:16 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Sep 2009 13:29:16 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9ECBAC.7060303@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> Message-ID: <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: > Am 02.09.2009 19:11, David M. Lloyd schrieb: >> >> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>> >>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >> > wrote: >>> ? ?Why not just do {@code \uD800}? ?I'm like 60% sure that would work >>> ? ?just fine. :-) >>> >>> >>> I'm pretty sure it would fail. ? Prove me wrong! >>> Searching the JDK sources for regex >>> ^ *\*.*\\u[0-9a-fA-F]{4} >>> is a good way to find javadoc bugs, e.g. >>> http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() >> >> Ah, you're right. ?It worked in my previewer but not in the actual >> javadoc. ?It's pretty bad that that sequence has special meaning but you >> can't escape a \ with another \. ?I guess in the worst case you could always >> do \u005CD800 or something like that. >> > > Looks little better, but not much. Did somebody tried it (Martin)? Well.... learn something new every day. Let's turn this into a fix. It's yet another "turkish i" bug. http://cr.openjdk.java.net/~martin/webrevs/openjdk7/javadoc-unicode-escapes/ Xueming, please file a bug and review. Synopsis: Unreadable \uXXXX in javadoc Description: Replace \uXXXX by \u005CXXXX, or simply delete Martin > If it works in a previewer, is there any chance to change the javadoc spec, > staying backwards compatible? > > -Ulf > > > From Ulf.Zibis at gmx.de Wed Sep 2 14:58:25 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 02 Sep 2009 23:58:25 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> Message-ID: <4A9EEA81.8000501@gmx.de> Am 02.09.2009 22:29, Martin Buchholz schrieb: > On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: > >> Am 02.09.2009 19:11, David M. Lloyd schrieb: >> >>> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>> >>>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >>> > wrote: >>>> Why not just do {@code \uD800}? I'm like 60% sure that would work >>>> just fine. :-) >>>> >>>> >>>> I'm pretty sure it would fail. Prove me wrong! >>>> Searching the JDK sources for regex >>>> ^ *\*.*\\u[0-9a-fA-F]{4} >>>> is a good way to find javadoc bugs, e.g. >>>> http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() >>>> >>> Ah, you're right. It worked in my previewer but not in the actual >>> javadoc. It's pretty bad that that sequence has special meaning but you >>> can't escape a \ with another \. I guess in the worst case you could always >>> do \u005CD800 or something like that. >>> >>> >> Looks little better, but not much. Did somebody tried it (Martin)? >> > > Well.... learn something new every day. > Let's turn this into a fix. > It's yet another "turkish i" bug. > > http://cr.openjdk.java.net/~martin/webrevs/openjdk7/javadoc-unicode-escapes/ > > Xueming, please file a bug and review. > > Synopsis: Unreadable \uXXXX in javadoc > Description: Replace \uXXXX by \u005CXXXX, or simply delete > Doesn't {@code "t\u005Cu0131tle"} work too ? If not, can this be seen as a bug ? > Searching the JDK sources for regex > ^ *\*.*\\u[0-9a-fA-F]{4} Doesn't it make sense to cover all occurrences in JDK ? -Ulf From martinrb at google.com Wed Sep 2 15:10:04 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Sep 2009 15:10:04 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9EEA81.8000501@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9EEA81.8000501@gmx.de> Message-ID: <1ccfd1c10909021510y41649b2ep650885c17a41ace5@mail.gmail.com> On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: > Am 02.09.2009 22:29, Martin Buchholz schrieb: > Doesn't {@code "t\u005Cu0131tle"} work too ? I think so. This would make it easier to globally replace with {@code. Here's a bit of Emacs Lisp to get you started: (defun tt-code () (interactive) (query-replace-regexp "<\\(tt\\|code\\)>\\([^<>\\\\]+\\)" "{@code \\2}")) >> Searching the JDK sources for regex >> ^ *\*.*\\u[0-9a-fA-F]{4} > > > Doesn't it make sense to cover all occurrences in JDK ? In non-public javadoc (that is, javadoc which is usually read directly instead of via the generated html) it is mostly harmless, and more readable as well. Martin From Ulf.Zibis at gmx.de Wed Sep 2 15:46:24 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 03 Sep 2009 00:46:24 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909021510y41649b2ep650885c17a41ace5@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9EEA81.8000501@gmx.de> <1ccfd1c10909021510y41649b2ep650885c17a41ace5@mail.gmail.com> Message-ID: <4A9EF5C0.60509@gmx.de> Am 03.09.2009 00:10, Martin Buchholz schrieb: > On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: > >> Doesn't {@code "t\u005Cu0131tle"} work too ? >> > > I think so. So can I securely replace all occurrences of ... by {@code ...} using \u005CuXXXX in Character.java ? -Ulf From Ulf.Zibis at gmx.de Thu Sep 3 06:22:33 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 03 Sep 2009 15:22:33 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9CDB81.1050500@gmx.de> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> Message-ID: <4A9FC319.3030508@gmx.de> Am 02.09.2009 22:29, Martin Buchholz schrieb: > On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: > >> Am 02.09.2009 19:11, David M. Lloyd schrieb: >> >>> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>> >>>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >>> > wrote: >>>> Why not just do {@code \uD800}? I'm like 60% sure that would work >>>> just fine. :-) >>>> >>>> >>>> I'm pretty sure it would fail. Prove me wrong! >>>> Searching the JDK sources for regex >>>> ^ *\*.*\\u[0-9a-fA-F]{4} >>>> is a good way to find javadoc bugs, e.g. >>>> http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() >>>> >>> Ah, you're right. It worked in my previewer but not in the actual >>> javadoc. It's pretty bad that that sequence has special meaning but you >>> can't escape a \ with another \. I guess in the worst case you could always >>> do \u005CD800 or something like that. >>> >>> >> Looks little better, but not much. Did somebody tried it (Martin)? >> > > Well.... learn something new every day. > Let's turn this into a fix. > It's yet another "turkish i" bug. > > http://cr.openjdk.java.net/~martin/webrevs/openjdk7/javadoc-unicode-escapes/ > > Xueming, please file a bug and review. > > Synopsis: Unreadable \uXXXX in javadoc > Description: Replace \uXXXX by \u005CXXXX, or simply delete > > BTW regarding javadoc of class String: - replace(char,char) and replace(CharSequence,CharSequence) should refer to one another by @see.... - replace(CharSequence,CharSequence) should state, if original is returned in case of no match. -Ulf From Alan.Bateman at Sun.COM Thu Sep 3 08:09:49 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 03 Sep 2009 16:09:49 +0100 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <4A96FFEA.6030909@sun.com> References: <4A96FFEA.6030909@sun.com> Message-ID: <4A9FDC3D.8090101@sun.com> Sorry for the delay getting back to this one. I've updated the webrev to address the comments, except for snprintf. The reason is that snprintf isn't in the Windows CRT. We usually use jio_snprintf (implemented on vsnprintf or _vsnprintf on Windows) but this is a transport library for the debugger agent and so isn't linked against the VM. We could extend its transport platform dependent code to add a function for this, but it hardly seems worth it for this one case. http://cr.openjdk.java.net/~alanb/6432567/webrev.00/ Thanks, Alan. From Daniel.Daugherty at Sun.COM Thu Sep 3 08:21:49 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Thu, 03 Sep 2009 09:21:49 -0600 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <4A9FDC3D.8090101@sun.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> Message-ID: <4A9FDF0D.5040902@sun.com> Alan Bateman wrote: > Sorry for the delay getting back to this one. I've updated the webrev > to address the comments, except for snprintf. The reason is that > snprintf isn't in the Windows CRT. We usually use jio_snprintf > (implemented on vsnprintf or _vsnprintf on Windows) but this is a > transport library for the debugger agent and so isn't linked against > the VM. We could extend its transport platform dependent code to add a > function for this, but it hardly seems worth it for this one case. > > http://cr.openjdk.java.net/~alanb/6432567/webrev.00/ In the following: sprintf(msg, "handshake failed - received >%s< - helloLen >%s<", b, hello); the "helloLen" above should probably be "hello". Otherwise, thumbs up... Dan From Alan.Bateman at Sun.COM Thu Sep 3 08:47:36 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 03 Sep 2009 16:47:36 +0100 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <4A9FDF0D.5040902@sun.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> <4A9FDF0D.5040902@sun.com> Message-ID: <4A9FE518.80707@sun.com> Daniel D. Daugherty wrote: > > : > In the following: > > sprintf(msg, "handshake failed - received >%s< - helloLen >%s<", b, > hello); > > the "helloLen" above should probably be "hello". > > Otherwise, thumbs up... Thanks Dan. Good catch, fixed! -Alan. From martinrb at google.com Thu Sep 3 11:10:42 2009 From: martinrb at google.com (Martin Buchholz) Date: Thu, 3 Sep 2009 11:10:42 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4A9FC319.3030508@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> Message-ID: <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> I agree that the spec can be clarified. Another case is the similar http://java.sun.com/javase/6/docs/api/java/lang/String.html#replace(char, char) which states "Returns a new string", but then goes on to contradict itself, although the meaning is clear. Webrev please. Martin On Thu, Sep 3, 2009 at 06:22, Ulf Zibis wrote: > > > Am 02.09.2009 22:29, Martin Buchholz schrieb: >> >> On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: >> >>> >>> Am 02.09.2009 19:11, David M. Lloyd schrieb: >>> >>>> >>>> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>>> >>>>> >>>>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >>>> > wrote: >>>>> ? Why not just do {@code \uD800}? ?I'm like 60% sure that would work >>>>> ? just fine. :-) >>>>> >>>>> >>>>> I'm pretty sure it would fail. ? Prove me wrong! >>>>> Searching the JDK sources for regex >>>>> ^ *\*.*\\u[0-9a-fA-F]{4} >>>>> is a good way to find javadoc bugs, e.g. >>>>> >>>>> http://java.sun.com/javase/6/docs/api/java/lang/String.html#toLowerCase() >>>>> >>>> >>>> Ah, you're right. ?It worked in my previewer but not in the actual >>>> javadoc. ?It's pretty bad that that sequence has special meaning but you >>>> can't escape a \ with another \. ?I guess in the worst case you could >>>> always >>>> do \u005CD800 or something like that. >>>> >>>> >>> >>> Looks little better, but not much. Did somebody tried it (Martin)? >>> >> >> Well.... learn something new every day. >> Let's turn this into a fix. >> It's yet another "turkish i" bug. >> >> >> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/javadoc-unicode-escapes/ >> >> Xueming, please file a bug and review. >> >> Synopsis: Unreadable \uXXXX in javadoc >> Description: Replace \uXXXX by \u005CXXXX, or simply delete >> >> > > BTW regarding javadoc of class String: > - replace(char,char) and replace(CharSequence,CharSequence) should refer to > one another by @see.... > - replace(CharSequence,CharSequence) should state, if original is returned > in case of no match. > > -Ulf > > > > From gnu_andrew at member.fsf.org Thu Sep 3 11:24:15 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 3 Sep 2009 19:24:15 +0100 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <4A9FDC3D.8090101@sun.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> Message-ID: <17c6771e0909031124i2b30e97fkb7351bec16493e97@mail.gmail.com> 2009/9/3 Alan Bateman : > Sorry for the delay getting back to this one. I've updated the webrev to > address the comments, except for snprintf. The reason is that snprintf isn't > in the Windows CRT. We usually use jio_snprintf (implemented on vsnprintf or > _vsnprintf on Windows) but this is a transport library for the debugger > agent and so isn't linked against the VM. We could extend its transport > platform dependent code to add a function for this, but it hardly seems > worth it for this one case. > > ?http://cr.openjdk.java.net/~alanb/6432567/webrev.00/ > > Thanks, > Alan. > Isn't there some way to test for snprintf and use it on platforms that aren't broken? It seems a bad idea to leave a potential security hole open for the sake of one legacy platform. snprintf is part of C99 according to its manpage, so it should be available on all compilers that implement this standard. This is one reason why it would be better if OpenJDK used autoconf; it has a test for this exact issue, but sadly that needs to be run prior to the build. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Ulf.Zibis at gmx.de Thu Sep 3 12:51:39 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 03 Sep 2009 21:51:39 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> Message-ID: <4AA01E4B.8020500@gmx.de> Am 03.09.2009 20:10, Martin Buchholz schrieb: > I agree that the spec can be clarified. > Another case is the similar > > http://java.sun.com/javase/6/docs/api/java/lang/String.html#replace(char, char) > > which states "Returns a new string", but then goes on to contradict itself, > although the meaning is clear. > > Webrev please. > > Martin, I was in the assumption, that you could add this clarification to your CR as you are involved anyway on finishing the javadoc of String. As you may be know, webrev script is a pain for me, as I'm on Windows. CYGWIN is buggy in that case, so each 2nd time I try this, Windows comes to hang because of C heap overflow. I like to finish the Character class and file the changes via patch on https://bugs.openjdk.java.net. So I would be happy If you could answer my question, if replacing all occurrences of ... by {@code ...} using \u005CuXXXX is secure. -Ulf From martinrb at google.com Thu Sep 3 15:15:33 2009 From: martinrb at google.com (Martin Buchholz) Date: Thu, 3 Sep 2009 15:15:33 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4AA01E4B.8020500@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> Message-ID: <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> On Thu, Sep 3, 2009 at 12:51, Ulf Zibis wrote: > Am 03.09.2009 20:10, Martin Buchholz schrieb: > I like to finish the Character class and file the changes via patch on > https://bugs.openjdk.java.net. So I would be happy If you could answer my > question, if replacing all occurrences of ... by {@code ...} > using ?\u005CuXXXX is secure. Here is my recommendation: I think it is worthwhile to convert => {@code I have been doing this in files that I "own", but have not tried to make a more pervasive change. I support such a more pervasive change, but it should be done with a script that gets a fair amount of scrutiny first, and will have to be restricted to those parts of the jdk that are truly maintained by the openjdk team, not code for which the true master lives elsewhere. I think we could get agreement to change at least core libraries. As part of this project, you would need to be able to run full builds including the javadoc, and verify that the output html is not damaged by the process. You could ignore a particular ... snippet if the text in between contains troublesome characters such as \ & < > @ Martin From Ulf.Zibis at gmx.de Thu Sep 3 18:37:49 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 04 Sep 2009 03:37:49 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> Message-ID: <4AA06F6D.2080809@gmx.de> Am 04.09.2009 00:15, Martin Buchholz schrieb: > On Thu, Sep 3, 2009 at 12:51, Ulf Zibis wrote: > >> Am 03.09.2009 20:10, Martin Buchholz schrieb: >> > > >> I like to finish the Character class and file the changes via patch on >> https://bugs.openjdk.java.net. So I would be happy If you could answer my >> question, if replacing all occurrences of ... by {@code ...} >> using \u005CuXXXX is secure. >> > > Here is my recommendation: > > I think it is worthwhile to convert => {@code > I have tried {@code '\u005CuD800'} in Character.java and thanks NetBeans I easily could create a partly-JDK javadoc (on about 100 classes) in surprising short time. The resulting html works fine / is not damaged (in Firefox). Thanks for your motivation. BTW, in String class there are some warnings: @spec is an unknown tag. In Character class you have inserted a typo: '\u007f'" at method valueOf(char) (the additional " ) > I have been doing this in files that I "own", > but have not tried to make a more pervasive change. > I support such a more pervasive change, > but it should be done with a script that gets a fair amount > of scrutiny first, and will have to be restricted to those > parts of the jdk that are truly maintained by the openjdk team, > not code for which the true master lives elsewhere. > I think we could get agreement to change at least core libraries. > > As part of this project, you would need to be able to run > full builds Yes, I should start working on Linux. I guess it would take me 3-4 week to setup a full running system, which fully satisfies my needs. For this reason I'm hesitating, because I want to progress with my charset ideas as fast as possible. On the other hand, it would be worthwhile there are some people who keep developing on Windows to assure, that java stays working on Windows, even under unusual JDK development. ;-) (BTW, I've found and filed several Windows related bugs regarding NetBeans) -Ulf P.S.: You have the habit to use rare English vocabulary, especially in this post, so I profit in increasing my knowledge in English. From martinrb at google.com Thu Sep 3 18:52:52 2009 From: martinrb at google.com (Martin Buchholz) Date: Thu, 3 Sep 2009 18:52:52 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4AA06F6D.2080809@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> Message-ID: <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> On Thu, Sep 3, 2009 at 18:37, Ulf Zibis wrote: > Am 04.09.2009 00:15, Martin Buchholz schrieb: > In Character class you have inserted a typo: '\u007f'" at method > valueOf(char) (the additional " ) When you say "you", I assume you are using the "royal you". That change was actually made by Joe Darcy. Martin From martinrb at google.com Thu Sep 3 19:05:00 2009 From: martinrb at google.com (Martin Buchholz) Date: Thu, 3 Sep 2009 19:05:00 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> Message-ID: <1ccfd1c10909031905j634b184dy83a17e18558cfb05@mail.gmail.com> Joe, here's a fix for the stray double quote. I've used {@code with \u005C with the hope of making Ulf happy. As usual, we'll need bug filed, etc... diff --git a/src/share/classes/java/lang/Character.java b/src/share/classes/java/lang/Character.java --- a/src/share/classes/java/lang/Character.java +++ b/src/share/classes/java/lang/Character.java @@ -2587,9 +2587,9 @@ * significantly better space and time performance by caching * frequently requested values. * - * This method will always cache values in the range '\u0000' - * to '\u007f'", inclusive, and may cache other values outside - * of this range. + * This method will always cache values in the range {@code + * '\u005Cu0000'} to {@code '\u005Cu007f'}, inclusive, and may + * cache other values outside of this range. * * @param c a char value. * @return a Character instance representing c. From weijun.wang at sun.com Fri Sep 4 00:09:45 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Fri, 04 Sep 2009 07:09:45 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090904071039.9227012BD5@hg.openjdk.java.net> Changeset: ee5300e1835a Author: weijun Date: 2009-09-04 14:58 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee5300e1835a 6876328: different names for the same digest algorithms breaks jarsigner Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java + test/sun/security/tools/jarsigner/nameclash.sh Changeset: 98ad1322051e Author: weijun Date: 2009-09-04 14:59 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98ad1322051e 6871847: AlgorithmId.get("SHA256withECDSA") not available Reviewed-by: vinnie ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/x509/AlgorithmId/SHA256withECDSA.java From john.coomes at sun.com Fri Sep 4 00:10:55 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 07:10:55 +0000 Subject: hg: jdk7/hotspot-rt: 3 new changesets Message-ID: <20090904071056.1754812BD6@hg.openjdk.java.net> Changeset: d8b49b53d8cf Author: wetmore Date: 2009-08-14 17:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/d8b49b53d8cf 6872177: JCE framework and provider builds broken following -target 7 changes Reviewed-by: ohair ! make/Defs-internal.gmk Changeset: 4c36e9853dda Author: tbell Date: 2009-08-24 22:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/4c36e9853dda Merge Changeset: 378f57273f09 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/378f57273f09 Added tag jdk7-b71 for changeset 4c36e9853dda ! .hgtags From john.coomes at sun.com Fri Sep 4 00:19:15 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 07:19:15 +0000 Subject: hg: jdk7/hotspot-rt/corba: 4 new changesets Message-ID: <20090904071919.9DAE412BE7@hg.openjdk.java.net> Changeset: 8001ba2bf10d Author: andrew Date: 2009-08-20 01:28 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/8001ba2bf10d 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and targets of the boot javac Reviewed-by: jjg, ohair ! make/common/shared/Defs-java.gmk Changeset: 04414f276160 Author: xdono Date: 2009-08-24 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/04414f276160 Merge Changeset: 3f1ef7f899ea Author: andrew Date: 2009-09-01 23:44 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/3f1ef7f899ea 6878106: Synchronize CORBA and JDK makefiles where possible Summary: Add recent changes to the JDK makefile to the CORBA makefile Reviewed-by: jjg, never ! make/common/shared/Defs-java.gmk Changeset: c793a3120926 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/c793a3120926 Added tag jdk7-b71 for changeset 3f1ef7f899ea ! .hgtags From john.coomes at sun.com Fri Sep 4 00:33:52 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 07:33:52 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b71 for changeset ff94d8ce0dad Message-ID: <20090904073354.EBA5C12BF8@hg.openjdk.java.net> Changeset: 37c805b6156f Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/37c805b6156f Added tag jdk7-b71 for changeset ff94d8ce0dad ! .hgtags From john.coomes at sun.com Fri Sep 4 00:41:20 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 07:41:20 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b71 for changeset 03314cf56a72 Message-ID: <20090904074123.6F53612BFD@hg.openjdk.java.net> Changeset: 4c990aa99bc0 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/4c990aa99bc0 Added tag jdk7-b71 for changeset 03314cf56a72 ! .hgtags From john.coomes at sun.com Fri Sep 4 00:49:31 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 07:49:31 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 27 new changesets Message-ID: <20090904075628.C2CA412C02@hg.openjdk.java.net> Changeset: 1ff977b938e5 Author: sherman Date: 2009-08-13 10:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1ff977b938e5 6840246: Lightweight implementation of String.split for simple use case Summary: Added a fastpath for simple use case Reviewed-by: alanb, martin ! src/share/classes/java/lang/String.java ! test/java/lang/String/Split.java Changeset: 8c0c96a3f9f6 Author: wetmore Date: 2009-08-13 12:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8c0c96a3f9f6 6870335: Provider numbers need to be bumped to 1.7 Reviewed-by: mullan ! src/share/classes/com/sun/security/sasl/Provider.java ! src/share/classes/sun/security/jgss/SunProvider.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/smartcardio/SunPCSC.java ! src/share/classes/sun/security/ssl/SunJSSE.java Changeset: 6797a2407a50 Author: wetmore Date: 2009-08-13 12:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6797a2407a50 Merge Changeset: 35f32639ee20 Author: sherman Date: 2009-08-13 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/35f32639ee20 6676423: (prefs) Opensource unit/regression tests for java.util.prefs Summary: Moved the existing test cases for prefs to open area Reviewed-by: martin, alanb + test/java/util/prefs/CommentsInXml.java + test/java/util/prefs/ConflictInFlush.java + test/java/util/prefs/ExportNode.java + test/java/util/prefs/ExportSubtree.java + test/java/util/prefs/PrefsSpi.java + test/java/util/prefs/PrefsSpi.sh + test/java/util/prefs/RemoveReadOnlyNode.java + test/java/util/prefs/RemoveUnregedListener.java + test/java/util/prefs/SerializeExceptions.java Changeset: f094eb92a6e0 Author: sherman Date: 2009-08-13 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f094eb92a6e0 Merge Changeset: 7fcdefc99dc4 Author: sherman Date: 2009-08-14 11:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7fcdefc99dc4 6866397: (file) PathMatcher with regex syntax doesn't match as expected (win) Summary: Use unicode_case_insensitive for windows path matcher for now. Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java ! test/java/nio/file/PathMatcher/Basic.java Changeset: 77a1c2056565 Author: sherman Date: 2009-08-14 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/77a1c2056565 6730652: CharsetEncoder.canEncode(char) returns incorrect values for some charsets Summary: override the canEncode() in ISO2022_CN_CNS Reviewed-by: martin ! src/share/classes/sun/nio/cs/ext/ISO2022.java ! src/share/classes/sun/nio/cs/ext/ISO2022_CN_CNS.java ! test/sun/nio/cs/FindCanEncodeBugs.java Changeset: 8414927b41d8 Author: weijun Date: 2009-08-18 10:20 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8414927b41d8 6829785: TextCallbackHandler does not honor PasswordCallback.isEchoOn() Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/callback/TextCallbackHandler.java ! src/share/classes/sun/security/util/Password.java + test/com/sun/security/auth/callback/TextCallbackHandler/Password.java Changeset: 74029d1cf4e4 Author: tbell Date: 2009-08-18 17:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/74029d1cf4e4 Merge Changeset: 5e8986cabdd8 Author: weijun Date: 2009-08-20 11:24 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5e8986cabdd8 6867665: Problem with keytabs with multiple kvno's (key versions) Reviewed-by: valeriep, ohair ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java + test/sun/security/krb5/ktab/HighestKvno.java Changeset: dfece53c600f Author: alanb Date: 2009-08-20 08:39 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dfece53c600f 6595866: File does work with symbolic links (win,vista) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c + test/java/io/File/SymLinks.java Changeset: 70c03e494a68 Author: alanb Date: 2009-08-20 08:42 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/70c03e494a68 6870926: (file) Path.toRealPath performance can be improved (win) Reviewed-by: sherman ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c Changeset: 5cd12b68d09b Author: alanb Date: 2009-08-20 08:48 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5cd12b68d09b 6866804: (file) Path calls checkPermission insteadof checkXXX (sol) Reviewed-by: sherman ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java + test/java/nio/file/Path/CheckPermissions.java ! test/java/nio/file/Path/Misc.java Changeset: 3992a43bb0a5 Author: darcy Date: 2009-08-21 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3992a43bb0a5 6378701: (enum) Unclear purpose of EnumConstantNotPresentException Reviewed-by: lancea, andrew, alanb ! src/share/classes/java/lang/EnumConstantNotPresentException.java ! src/share/classes/java/lang/TypeNotPresentException.java ! src/share/classes/java/lang/annotation/AnnotationFormatError.java ! src/share/classes/java/lang/annotation/AnnotationTypeMismatchException.java ! src/share/classes/java/lang/annotation/IncompleteAnnotationException.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java Changeset: 99a55f6f1cef Author: alanb Date: 2009-08-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/99a55f6f1cef 6874521: Remove @note tags Reviewed-by: andrew, darcy ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/file/FileRef.java ! src/share/classes/java/util/Scanner.java Changeset: cef30252932a Author: alanb Date: 2009-08-23 12:53 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/cef30252932a 6842687: New I/O: Update Asynchronous I/O API to jsr203/nio2-b101 Reviewed-by: sherman ! make/java/nio/FILES_java.gmk ! src/share/classes/java/nio/channels/AsynchronousByteChannel.java ! src/share/classes/java/nio/channels/AsynchronousChannel.java ! src/share/classes/java/nio/channels/AsynchronousDatagramChannel.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/CompletionHandler.java ! src/share/classes/java/nio/channels/exceptions - src/share/classes/sun/nio/ch/AbstractFuture.java ! src/share/classes/sun/nio/ch/AsynchronousChannelGroupImpl.java ! src/share/classes/sun/nio/ch/AsynchronousFileChannelImpl.java ! src/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/CompletedFuture.java ! src/share/classes/sun/nio/ch/Invoker.java ! src/share/classes/sun/nio/ch/PendingFuture.java ! src/share/classes/sun/nio/ch/SimpleAsynchronousDatagramChannelImpl.java ! src/share/classes/sun/nio/ch/SimpleAsynchronousFileChannelImpl.java ! src/solaris/classes/sun/nio/ch/EPollPort.java ! src/solaris/classes/sun/nio/ch/Port.java ! src/solaris/classes/sun/nio/ch/SolarisEventPort.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/windows/classes/sun/nio/ch/Iocp.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousServerSocketChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! src/windows/native/sun/nio/ch/Iocp.c ! test/java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java ! test/java/nio/channels/AsynchronousChannelGroup/Identity.java ! test/java/nio/channels/AsynchronousChannelGroup/Restart.java ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java ! test/java/nio/channels/AsynchronousDatagramChannel/Basic.java ! test/java/nio/channels/AsynchronousFileChannel/Basic.java ! test/java/nio/channels/AsynchronousFileChannel/CustomThreadPool.java ! test/java/nio/channels/AsynchronousFileChannel/Lock.java ! test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java + test/java/nio/channels/AsynchronousSocketChannel/DieBeforeComplete.java ! test/java/nio/channels/AsynchronousSocketChannel/StressLoopback.java ! test/java/nio/channels/FileChannel/ReleaseOnCloseDeadlock.java Changeset: fca3e1a178fd Author: alanb Date: 2009-08-23 17:20 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/fca3e1a178fd Merge Changeset: dbcc1f13e4fd Author: weijun Date: 2009-08-24 18:37 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dbcc1f13e4fd 6875033: regression: test of 6867665 fail Reviewed-by: xuelei ! test/sun/security/krb5/ktab/HighestKvno.java Changeset: d954cd279188 Author: ohair Date: 2009-08-24 09:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d954cd279188 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project Reviewed-by: andrew, alanb, tbell, swamyv ! .hgignore + make/netbeans/jdwpgen/build.xml + make/netbeans/jdwpgen/nbproject/build-impl.xml + make/netbeans/jdwpgen/nbproject/findbugs.settings + make/netbeans/jdwpgen/nbproject/genfiles.properties + make/netbeans/jdwpgen/nbproject/project.properties + make/netbeans/jdwpgen/nbproject/project.xml + make/netbeans/jdwpgen/nbproject/sqe.properties ! make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java ! make/tools/src/build/tools/jdwpgen/AltNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/Main.java ! make/tools/src/build/tools/jdwpgen/Node.java ! make/tools/src/build/tools/jdwpgen/Parse.java ! make/tools/src/build/tools/jdwpgen/RepeatNode.java ! make/tools/src/build/tools/jdwpgen/SelectNode.java Changeset: dd997cc0c823 Author: vinnie Date: 2009-08-24 18:37 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/dd997cc0c823 6872048: bad private keys are generated for 2 specific ECC curves Reviewed-by: wetmore ! src/share/native/sun/security/ec/ec.c ! test/sun/security/ec/TestEC.java Changeset: b71a03c75515 Author: tbell Date: 2009-08-24 22:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b71a03c75515 Merge - src/share/classes/sun/nio/ch/AbstractFuture.java Changeset: 80368890a2a0 Author: andrew Date: 2009-08-18 19:50 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/80368890a2a0 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and targets of the boot javac Reviewed-by: ohair ! make/common/shared/Defs-java.gmk Changeset: 43465920bf47 Author: xdono Date: 2009-08-18 19:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/43465920bf47 Merge - test/java/util/concurrent/ConcurrentLinkedQueue/ConcurrentQueueLoops.java - test/java/util/concurrent/ConcurrentLinkedQueue/LoopHelpers.java Changeset: b3aac0db5586 Author: tbell Date: 2009-08-21 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b3aac0db5586 6705913: freetype_versioncheck.exe - Unable To Locate Component Summary: Update freetype_versioncheck to deal with newer Visual Studio releases Reviewed-by: ohair ! make/tools/freetypecheck/Makefile ! make/tools/freetypecheck/freetypecheck.c Changeset: e0b26d347302 Author: xdono Date: 2009-08-24 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e0b26d347302 Merge Changeset: b3f3240135f0 Author: xdono Date: 2009-09-01 13:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b3f3240135f0 Merge - src/share/classes/sun/nio/ch/AbstractFuture.java Changeset: ce3fde68c495 Author: xdono Date: 2009-09-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ce3fde68c495 Added tag jdk7-b71 for changeset b3f3240135f0 ! .hgtags From john.coomes at sun.com Fri Sep 4 01:10:06 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 04 Sep 2009 08:10:06 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 11 new changesets Message-ID: <20090904081026.A760212C07@hg.openjdk.java.net> Changeset: 8a03f3c7d160 Author: jjg Date: 2009-08-12 07:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8a03f3c7d160 6870706: langtools launcher issues Reviewed-by: mcimadamore ! make/build.xml ! src/share/bin/launcher.sh-template Changeset: 71680973d8ec Author: jjg Date: 2009-08-12 07:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/71680973d8ec 6758471: should be able to set jtreg options in langtools build Reviewed-by: mcimadamore ! make/build.properties ! make/build.xml Changeset: 7dbb79875a63 Author: jjg Date: 2009-08-12 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/7dbb79875a63 6558476: com/sun/tools/javac/Main.compile don't release file handles on return Reviewed-by: darcy + src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/T6558476.java Changeset: b055a5ea0dad Author: tbell Date: 2009-08-18 17:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/b055a5ea0dad Merge Changeset: 2aa3a1cdb094 Author: andrew Date: 2009-08-19 20:44 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2aa3a1cdb094 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk Summary: Set source and target explicitly in pcompile task Reviewed-by: jjg ! make/build.xml Changeset: 2ce3597237f0 Author: darcy Date: 2009-08-19 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2ce3597237f0 6871291: Please clarify javax.tools.JavaCompiler.getTask() "classes" parameter Reviewed-by: jjg ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 61c1f735df67 Author: jjg Date: 2009-08-21 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/61c1f735df67 6873849: suppress notes generated by javac Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6873849.java Changeset: d9febdd5ae21 Author: jjg Date: 2009-08-21 14:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d9febdd5ae21 6873845: refine access to symbol file Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/T6873845.java Changeset: c863e90091ee Author: jjg Date: 2009-08-24 14:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/c863e90091ee 6869216: testgetallmembers should consistently use correct filemanager Reviewed-by: darcy ! test/tools/javac/processing/model/testgetallmembers/Main.java Changeset: 33c8c38e1757 Author: tbell Date: 2009-08-24 22:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/33c8c38e1757 Merge Changeset: d434aa041b52 Author: xdono Date: 2009-09-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d434aa041b52 Added tag jdk7-b71 for changeset 33c8c38e1757 ! .hgtags From Ulf.Zibis at gmx.de Fri Sep 4 02:14:53 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 04 Sep 2009 11:14:53 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> Message-ID: <4AA0DA8D.9070408@gmx.de> Am 04.09.2009 03:52, Martin Buchholz schrieb: > When you say "you", I assume you are using the "royal you". > That change was actually made by Joe Darcy. > > Martin > Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, so as this particular change was in similar flavour of your changes in 6860431, I actually and regrettably erroneously thought, that You personally was the author. I receive my just deserts, it's cold and raining today. -Ulf From Alan.Bateman at Sun.COM Fri Sep 4 02:23:44 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 04 Sep 2009 10:23:44 +0100 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <17c6771e0909031124i2b30e97fkb7351bec16493e97@mail.gmail.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> <17c6771e0909031124i2b30e97fkb7351bec16493e97@mail.gmail.com> Message-ID: <4AA0DCA0.6050707@sun.com> Andrew John Hughes wrote: > : > Isn't there some way to test for snprintf and use it on platforms that > aren't broken? It seems a bad idea to leave a potential security hole > open for the sake of one legacy platform. snprintf is part of C99 > according to its manpage, so it should be available on all compilers > that implement this standard. > > This is one reason why it would be better if OpenJDK used autoconf; it > has a test for this exact issue, but sadly that needs to be run prior > to the build. > Windows is indeed a pain. If this were library code then we could use jio_snprintf but this is a debugger transport library that shouldn't need to be linked to the VM. As I said, we could put in platform dependent code for this - it's not hard, just didn't seem to be worth it for this one case. You are right, that if someone were to increase the message without resizing the buffer then we'd have the buffer overflow issue back again. So if folks feel strongly about this, then I can do this so that we are using snprintf/equivalent. Alternatively, we simply change this to return a generic message (like "handshake failed - the peer is not a debugger") and skip printing the bytes received from the unrecognized peer. Moving to an autoconf build is a significant project - that something for build-dev. -Alan. From martinrb at google.com Fri Sep 4 08:10:21 2009 From: martinrb at google.com (Martin Buchholz) Date: Fri, 4 Sep 2009 08:10:21 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4AA0DA8D.9070408@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> <4AA0DA8D.9070408@gmx.de> Message-ID: <1ccfd1c10909040810i3bdeb991l34e165b299477d1f@mail.gmail.com> On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: > Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, Do you know about "hg blame" ? From Ulf.Zibis at gmx.de Fri Sep 4 12:04:33 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 04 Sep 2009 21:04:33 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909040810i3bdeb991l34e165b299477d1f@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> <4AA0DA8D.9070408@gmx.de> <1ccfd1c10909040810i3bdeb991l34e165b299477d1f@mail.gmail.com> Message-ID: <4AA164C1.20507@gmx.de> Am 04.09.2009 17:10, Martin Buchholz schrieb: > On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: > > >> Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, >> > > Do you know about "hg blame" ? > Good idea. :-) I rarely used it. Thanks for remembering me. -Ulf From gnu_andrew at member.fsf.org Fri Sep 4 12:26:18 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 4 Sep 2009 20:26:18 +0100 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <4AA0DCA0.6050707@sun.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> <17c6771e0909031124i2b30e97fkb7351bec16493e97@mail.gmail.com> <4AA0DCA0.6050707@sun.com> Message-ID: <17c6771e0909041226v9f83ec4te98cef940bbfa92a@mail.gmail.com> 2009/9/4 Alan Bateman : > Andrew John Hughes wrote: >> >> : >> Isn't there some way to test for snprintf and use it on platforms that >> aren't broken? ?It seems a bad idea to leave a potential security hole >> open for the sake of one legacy platform. ?snprintf is part of C99 >> according to its manpage, so it should be available on all compilers >> that implement this standard. >> >> This is one reason why it would be better if OpenJDK used autoconf; it >> has a test for this exact issue, but sadly that needs to be run prior >> to the build. >> > > Windows is indeed a pain. If this were library code then we could use > jio_snprintf but this is a debugger transport library that shouldn't need to > be linked to the VM. As I said, we could put in platform dependent code for > this - it's not hard, just didn't seem to be worth it for this one case. You > are right, that if someone were to increase the message without resizing the > buffer then we'd have the buffer overflow issue back again. So if folks feel > strongly about this, then I can do this so that we are using > snprintf/equivalent. Alternatively, we simply change this to return a > generic message (like "handshake failed - the peer is not a debugger") and > skip printing the bytes received from the unrecognized peer. > Don't worry about going to a lot of effort if it's just me quibbling. It's annoying that we have to work to the lowest common denominator but I'm sure it's not the first time, nor will it be the last. Your FIXME should at least catch the eye of anyone changing this. > Moving to an autoconf build is a significant project - that something for > build-dev. > Yeah, I may look at it when I get some time. It shouldn't actually be too hard to have a configure run that feeds variables to the current make-based build by autodetecting some stuff and allowing users a nicer way to work with the options. We already have IcedTea as a prototype of this and it would be optional; seasoned hackers could still set the variables themselves should they so wish. If the Windows build is Cygwin based, it should even be usable there -- albeit very slowly if my memories of Cygwin-based configure are anything to go by. > -Alan. > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From martinrb at google.com Fri Sep 4 13:17:06 2009 From: martinrb at google.com (Martin Buchholz) Date: Fri, 4 Sep 2009 13:17:06 -0700 Subject: Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException In-Reply-To: <17c6771e0909041226v9f83ec4te98cef940bbfa92a@mail.gmail.com> References: <4A96FFEA.6030909@sun.com> <4A9FDC3D.8090101@sun.com> <17c6771e0909031124i2b30e97fkb7351bec16493e97@mail.gmail.com> <4AA0DCA0.6050707@sun.com> <17c6771e0909041226v9f83ec4te98cef940bbfa92a@mail.gmail.com> Message-ID: <1ccfd1c10909041317n79746d09t86f3f0f38e147663@mail.gmail.com> On Fri, Sep 4, 2009 at 12:26, Andrew John Hughes wrote: > If the Windows build is Cygwin based, it should even be usable there > -- albeit very slowly if my memories of Cygwin-based configure are > anything to go by. Speed is one problem. A bigger problem is that the JDK is not (yet) a Cygwin application - it is just a regular Windows app built using the microsoft compiler and thus does not fit well into the autoconf framework. Martin From joe.darcy at sun.com Fri Sep 4 13:19:49 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 04 Sep 2009 20:19:49 +0000 Subject: hg: jdk7/tl/jdk: 6873951: test/java/lang/reflect/Generics/Probe.java fails. Message-ID: <20090904202035.25AB812FEA@hg.openjdk.java.net> Changeset: c34f92a47245 Author: darcy Date: 2009-09-04 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c34f92a47245 6873951: test/java/lang/reflect/Generics/Probe.java fails. Reviewed-by: alanb ! test/java/lang/reflect/Generics/Probe.java From Joe.Darcy at Sun.COM Fri Sep 4 13:34:26 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 04 Sep 2009 13:34:26 -0700 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <1ccfd1c10909031905j634b184dy83a17e18558cfb05@mail.gmail.com> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <1ccfd1c10909031515o77fc310fn844d372ee03b4925@mail.gmail.com> <4AA06F6D.2080809@gmx.de> <1ccfd1c10909031852v2a09e439y4010841598d28a6e@mail.gmail.com> <1ccfd1c10909031905j634b184dy83a17e18558cfb05@mail.gmail.com> Message-ID: <4AA179D2.7050407@sun.com> Hello. Martin Buchholz wrote: > Joe, here's a fix for the stray double quote. > Mea culpa! > I've used {@code with \u005C with the hope of making Ulf happy. > > As usual, we'll need bug filed, etc... > I've filed bug 6879368 "Remove stray quote in Character javadoc" for this issue. > diff --git a/src/share/classes/java/lang/Character.java > b/src/share/classes/java/lang/Character.java > --- a/src/share/classes/java/lang/Character.java > +++ b/src/share/classes/java/lang/Character.java > @@ -2587,9 +2587,9 @@ > * significantly better space and time performance by caching > * frequently requested values. > * > - * This method will always cache values in the range '\u0000' > - * to '\u007f'", inclusive, and may cache other values outside > - * of this range. > + * This method will always cache values in the range {@code > + * '\u005Cu0000'} to {@code '\u005Cu007f'}, inclusive, and may > + * cache other values outside of this range. > * > * @param c a char value. > * @return a Character instance representing c. > I approve this going back. Thanks, -Joe From martinrb at google.com Fri Sep 4 13:59:01 2009 From: martinrb at google.com (martinrb at google.com) Date: Fri, 04 Sep 2009 20:59:01 +0000 Subject: hg: jdk7/tl/jdk: 6879368: Remove stray quote in Character javadoc Message-ID: <20090904205940.3BF69E013@hg.openjdk.java.net> Changeset: 704296144175 Author: martin Date: 2009-09-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/704296144175 6879368: Remove stray quote in Character javadoc Summary: Remove stray quote in Character.valueOf javadoc, using Ulf's \u005CuXXXX technique Reviewed-by: darcy ! src/share/classes/java/lang/Character.java From alan.bateman at sun.com Sat Sep 5 08:07:05 2009 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Sat, 05 Sep 2009 15:07:05 +0000 Subject: hg: jdk7/tl/jdk: 4 new changesets Message-ID: <20090905150831.EE952E07F@hg.openjdk.java.net> Changeset: 3f87b755b1c8 Author: alanb Date: 2009-09-04 18:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3f87b755b1c8 6873621: (file) FileStore.supportsFileAttributeView(Class type) returns wrong result Reviewed-by: andrew ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/SolarisFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: 05ea733a7ae2 Author: alanb Date: 2009-09-04 18:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05ea733a7ae2 6868627: (spec) Files.walkFileTree doesn't make it clear that uncaught errors and exceptions are propagated Reviewed-by: sherman ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java Changeset: 87a2ef2439bc Author: alanb Date: 2009-09-04 22:22 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/87a2ef2439bc 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException Reviewed-by: tbell, ohair, dcubed, andrew ! src/share/transport/socket/socketTransport.c ! test/com/sun/jdi/BadHandshakeTest.java Changeset: 7afdf9d0bc2c Author: alanb Date: 2009-09-05 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7afdf9d0bc2c Merge From Ulf.Zibis at gmx.de Sat Sep 5 12:54:30 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 05 Sep 2009 21:54:30 +0200 Subject: hg: jdk7/tl/jdk: 6879368: Remove stray quote in Character javadoc In-Reply-To: <20090904205940.3BF69E013@hg.openjdk.java.net> References: <20090904205940.3BF69E013@hg.openjdk.java.net> Message-ID: <4AA2C1F6.8000403@gmx.de> Am 04.09.2009 22:59, martinrb at google.com schrieb: > Changeset: 704296144175 > Author: martin > Date: 2009-09-04 13:44 -0700 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/704296144175 > > 6879368: Remove stray quote in Character javadoc > Summary: Remove stray quote in Character.valueOf javadoc, using Ulf's \u005CuXXXX technique > Reviewed-by: darcy > > ! src/share/classes/java/lang/Character.java > > > To be accurate: It's David M. Lloyd's technique! -Ulf From Alan.Bateman at Sun.COM Sun Sep 6 12:17:38 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Sun, 06 Sep 2009 20:17:38 +0100 Subject: API's for monitoring disk activity In-Reply-To: References: Message-ID: <4AA40AD2.5030806@sun.com> Avinash Lakshman wrote: > Are there APIs to monitor disk related activity? An API based > mechanism to get information provided by iostat. Any plans to add them > going forward? Are there ways to obtain them today perhaps through > some other library? There isn't anything in the management interface to the operating system (in java.lang.management) or in the platform extensions (com.sun.management). I'm not aware of any plans either but serviceability-dev would be the place to bring it up. For java.nio.file, it won't be too hard to expose the stats as FileStore attributes. Another option is to just simple open an InputStream to /proc/diskstats or /sys/blocks (where iostat reads the statistics for its output). -Alan. From Ulf.Zibis at gmx.de Sun Sep 6 14:31:28 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sun, 06 Sep 2009 23:31:28 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4AA01E4B.8020500@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> Message-ID: <4AA42A30.6080703@gmx.de> Cosmetics for class Character is finished (there have been javadoc errors in String+AbstractStringbuilder too): https://bugs.openjdk.java.net/attachment.cgi?id=145&action=diff -Ulf Am 03.09.2009 21:51, Ulf Zibis schrieb: > Am 03.09.2009 20:10, Martin Buchholz schrieb: >> I agree that the spec can be clarified. >> Another case is the similar >> >> http://java.sun.com/javase/6/docs/api/java/lang/String.html#replace(char, >> char) >> >> which states "Returns a new string", but then goes on to contradict >> itself, >> although the meaning is clear. >> >> Webrev please. >> >> > > Martin, > > I was in the assumption, that you could add this clarification to your > CR as you are involved anyway on finishing the javadoc of String. As > you may be know, webrev script is a pain for me, as I'm on Windows. > CYGWIN is buggy in that case, so each 2nd time I try this, Windows > comes to hang because of C heap overflow. > > I like to finish the Character class and file the changes via patch on > https://bugs.openjdk.java.net. So I would be happy If you could answer > my question, if replacing all occurrences of ... by > {@code ...} using \u005CuXXXX is secure. > > -Ulf > > > From Ulf.Zibis at gmx.de Mon Sep 7 05:30:03 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 07 Sep 2009 14:30:03 +0200 Subject: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch) In-Reply-To: <4AA42A30.6080703@gmx.de> References: <20090831221217.2CEFA12912@hg.openjdk.java.net> <1ccfd1c10909012021g78d4fa3cx5f6ab0792c3ba688@mail.gmail.com> <4A9E27BF.8000905@gmx.de> <1ccfd1c10909020927v74fe5ceekc91f4e4a4724a273@mail.gmail.com> <4A9E9FE9.7060107@redhat.com> <1ccfd1c10909021003o7b060a23ge700680cd75b07bf@mail.gmail.com> <4A9EA759.3050804@redhat.com> <4A9ECBAC.7060303@gmx.de> <1ccfd1c10909021329i34005b1bi5816e695d71a174d@mail.gmail.com> <4A9FC319.3030508@gmx.de> <1ccfd1c10909031110p6d38eb9dv9787ff88f3b4d1b7@mail.gmail.com> <4AA01E4B.8020500@gmx.de> <4AA42A30.6080703@gmx.de> Message-ID: <4AA4FCCB.3010107@gmx.de> Am 06.09.2009 23:31, Ulf Zibis schrieb: > Cosmetics for class Character is finished (there have been javadoc > errors in String+AbstractStringbuilder too): > https://bugs.openjdk.java.net/attachment.cgi?id=145&action=diff > Update: https://bugs.openjdk.java.net/attachment.cgi?id=146&action=diff Benefit from package private helpers: https://bugs.openjdk.java.net/attachment.cgi?id=147&action=diff Removed usages of class Surrogate where ever possible: https://bugs.openjdk.java.net/attachment.cgi?id=148&action=diff -Ulf From tim.bell at sun.com Mon Sep 7 09:44:52 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 16:44:52 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b71 for changeset 4c36e9853dda Message-ID: <20090907164453.2B39CE0F1@hg.openjdk.java.net> Changeset: 378f57273f09 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/378f57273f09 Added tag jdk7-b71 for changeset 4c36e9853dda ! .hgtags From tim.bell at sun.com Mon Sep 7 09:51:22 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 16:51:22 +0000 Subject: hg: jdk7/tl/corba: 4 new changesets Message-ID: <20090907165126.8A819E0F8@hg.openjdk.java.net> Changeset: 8001ba2bf10d Author: andrew Date: 2009-08-20 01:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/8001ba2bf10d 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and targets of the boot javac Reviewed-by: jjg, ohair ! make/common/shared/Defs-java.gmk Changeset: 04414f276160 Author: xdono Date: 2009-08-24 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/04414f276160 Merge Changeset: 3f1ef7f899ea Author: andrew Date: 2009-09-01 23:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/3f1ef7f899ea 6878106: Synchronize CORBA and JDK makefiles where possible Summary: Add recent changes to the JDK makefile to the CORBA makefile Reviewed-by: jjg, never ! make/common/shared/Defs-java.gmk Changeset: c793a3120926 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/c793a3120926 Added tag jdk7-b71 for changeset 3f1ef7f899ea ! .hgtags From tim.bell at sun.com Mon Sep 7 09:59:41 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 16:59:41 +0000 Subject: hg: jdk7/tl/hotspot: Added tag jdk7-b71 for changeset 50a95aa4a247 Message-ID: <20090907165947.3A9F5E0FF@hg.openjdk.java.net> Changeset: 6e6427f797c0 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6e6427f797c0 Added tag jdk7-b71 for changeset 50a95aa4a247 ! .hgtags From tim.bell at sun.com Mon Sep 7 10:15:50 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 17:15:50 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b71 for changeset ff94d8ce0dad Message-ID: <20090907171552.7AF24E104@hg.openjdk.java.net> Changeset: 37c805b6156f Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/37c805b6156f Added tag jdk7-b71 for changeset ff94d8ce0dad ! .hgtags From tim.bell at sun.com Mon Sep 7 10:22:01 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 17:22:01 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b71 for changeset 03314cf56a72 Message-ID: <20090907172204.27D39E109@hg.openjdk.java.net> Changeset: 4c990aa99bc0 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/4c990aa99bc0 Added tag jdk7-b71 for changeset 03314cf56a72 ! .hgtags From tim.bell at sun.com Mon Sep 7 10:29:02 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 17:29:02 +0000 Subject: hg: jdk7/tl/jdk: 9 new changesets Message-ID: <20090907173119.D25E8E10E@hg.openjdk.java.net> Changeset: 80368890a2a0 Author: andrew Date: 2009-08-18 19:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80368890a2a0 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk javac Summary: The bootstrap javac currently uses the default source and targets of the boot javac Reviewed-by: ohair ! make/common/shared/Defs-java.gmk Changeset: 43465920bf47 Author: xdono Date: 2009-08-18 19:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43465920bf47 Merge - test/java/util/concurrent/ConcurrentLinkedQueue/ConcurrentQueueLoops.java - test/java/util/concurrent/ConcurrentLinkedQueue/LoopHelpers.java Changeset: b3aac0db5586 Author: tbell Date: 2009-08-21 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b3aac0db5586 6705913: freetype_versioncheck.exe - Unable To Locate Component Summary: Update freetype_versioncheck to deal with newer Visual Studio releases Reviewed-by: ohair ! make/tools/freetypecheck/Makefile ! make/tools/freetypecheck/freetypecheck.c Changeset: e0b26d347302 Author: xdono Date: 2009-08-24 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0b26d347302 Merge Changeset: b3f3240135f0 Author: xdono Date: 2009-09-01 13:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b3f3240135f0 Merge - src/share/classes/sun/nio/ch/AbstractFuture.java Changeset: ce3fde68c495 Author: xdono Date: 2009-09-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ce3fde68c495 Added tag jdk7-b71 for changeset b3f3240135f0 ! .hgtags Changeset: ed0863629d28 Author: tbell Date: 2009-09-03 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed0863629d28 Merge - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: 658a4255c797 Author: tbell Date: 2009-09-04 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/658a4255c797 Merge Changeset: abb69e8b1774 Author: tbell Date: 2009-09-06 23:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/abb69e8b1774 Merge From tim.bell at sun.com Mon Sep 7 10:44:03 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 07 Sep 2009 17:44:03 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20090907174410.44916E11F@hg.openjdk.java.net> Changeset: d434aa041b52 Author: xdono Date: 2009-09-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d434aa041b52 Added tag jdk7-b71 for changeset 33c8c38e1757 ! .hgtags Changeset: 90c28923e449 Author: tbell Date: 2009-09-03 18:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/90c28923e449 Merge - test/tools/javac/innerClassFile/Driver.java - test/tools/javac/meth/InvokeMH_BAD68.java - test/tools/javac/meth/InvokeMH_BAD72.java - test/tools/javac/quid/QuotedIdent_BAD61.java - test/tools/javac/quid/QuotedIdent_BAD62.java - test/tools/javac/quid/QuotedIdent_BAD63.java From ahughes at redhat.com Tue Sep 8 01:10:33 2009 From: ahughes at redhat.com (ahughes at redhat.com) Date: Tue, 08 Sep 2009 08:10:33 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 2 new changesets Message-ID: <20090908081042.48187E1B2@hg.openjdk.java.net> Changeset: 5fdbe2cdf565 Author: andrew Date: 2009-09-08 09:01 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5fdbe2cdf565 6879689: Fix warning about ignored return value when compiling with -O2 Summary: Store the return value of fwrite and check it matches the size of the array. Reviewed-by: twisti, dholmes ! src/share/vm/adlc/archDesc.cpp Changeset: 0804a88ed4f5 Author: andrew Date: 2009-09-08 09:02 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0804a88ed4f5 Merge From i30817 at gmail.com Tue Sep 8 07:59:26 2009 From: i30817 at gmail.com (Paulo Levi) Date: Tue, 8 Sep 2009 15:59:26 +0100 Subject: Is there such a thing as a continuous heap dump? In-Reply-To: <212322090909070845p66f15d95sad00903923cba436@mail.gmail.com> References: <212322090909070845p66f15d95sad00903923cba436@mail.gmail.com> Message-ID: <212322090909080759w1bdfc9c5i45630021e39e7881@mail.gmail.com> Recently like i fool i did a performance OQL query for the netbeans OQL console, that gives overallocated Buffers, like duplicated BufferedReaders etc, this works, but only if the dump is at exactly the right time, which is most useless since these objects are short lived and the whole point is discovering them. So i'd like to know if there is a way to generate a continuous heap dump, like a collection of all the states the application went through until a point, or if that is not possible at least to trigger a heap dump before the finalize of certain objects (like in a finalizer, but without the finalizer obviously). I'd like this to be unobtrusive too. I guess that there might be other performance analysis that could be done if only heap dumps gave a more complete overview of the app state. the query is this: var duplicated; function instanceOf(it, other){ ? ?c2 = heap.findClass(other); ? ?if(c2 == null) ? ? ? ?return false; ? ?c1 = classof(it); ? ?return c1 == c2 || c1.isSubclassOf(c2); } function overAllocationFilterInputStream(it) { ? ?while(instanceOf(it, "java.io.FilterInputStream")){ ? ? ? ?stream = it["in"]; ? ? ? ?if(instanceOf(stream, "java.io.BufferedInputStream") || ? ? ? ? ? instanceOf(stream, "java.io.ByteArrayInputStream") || ? ? ? ? ? instanceOf(stream, "java.io.StringBufferInputStream") || ? ? ? ? ? instanceOf(stream, "java.io.PipedInputStream")){ ? ? ? ? ? ?duplicated = stream; ? ? ? ? ? ?return true; ? ? ? ? ?} ? ? ? ?it = stream; ? ?} ? ?return false; } function overAllocationFilterOutputStream(it) { ? ?while(instanceOf(it, "java.io.FilterOutputStream")){ ? ? ? ?stream = it["out"]; ? ? ? ?if(instanceOf(stream, ?"java.io.BufferedOutputStream") || ? ? ? ? ? instanceOf(stream, ?"java.io.ByteArrayOutputStream") || ? ? ? ? ? instanceOf(stream, "java.io.PipedOutputStream")){ ? ? ? ? ? ?duplicated = stream; ? ? ? ? ? ?return true; ? ? ? ? ?} ? ? ? ?it = stream; ? ?} ? ?return false; } function overAllocationReader(it) { ? ?while(instanceOf(it, "java.io.BufferedReader") || instanceOf(it, "java.io.FilterReader")){ ? ? ? ?stream = it["in"]; ? ? ? ?if(instanceOf(stream, "java.io.BufferedReader") || ? ? ? ? ? instanceOf(stream, "java.io.PipedReader") || ? ? ? ? ? instanceOf(stream, "java.io.CharArrayReader") || ? ? ? ? ? instanceOf(stream, "java.io.StringReader")){ ? ? ? ? ? ?duplicated = stream; ? ? ? ? ? ?return true; ? ? ? ? ?} ? ? ? ?it = stream; ? ?} ? ?return false; } function overAllocationWriter(it) { ? ?while(instanceOf(it, "java.io.BufferedWriter") || instanceOf(it, "java.io.FilterWriter")){ ? ? ? ?stream = it["out"]; ? ? ? ?if(instanceOf(stream, "java.io.BufferedWriter") || ? ? ? ? ? instanceOf(stream, "java.io.PipedWriter") || ? ? ? ? ? instanceOf(stream, "java.io.CharArrayWriter") || ? ? ? ? ? instanceOf(stream, "java.io.StringWriter")){ ? ? ? ? ? ?duplicated = stream; ? ? ? ? ? ?return true; ? ? ? ? ?} ? ? ? ?it = stream; ? ?} ? ?return false; } function showOAinfo(it) { ? ?return toHtml(it) + " buffers data that " + toHtml(duplicated) + " also does, one of them probably should be eliminated."; } map( concat( concat( concat( concat( concat( heap.objects("java.util.zip.InflaterInputStream", false, 'overAllocationFilterInputStream(it)'), heap.objects("java.io.BufferedInputStream", false, 'overAllocationFilterInputStream(it)')), heap.objects("java.util.zip.DeflaterOutputStream", false, 'overAllocationFilterOutputStream(it)')), heap.objects("java.io.BufferedOutputStream", false, 'overAllocationFilterOutputStream(it)')), heap.objects("java.io.BufferedReader", false, 'overAllocationReader(it)')), heap.objects("java.io.BufferedWriter", false, 'overAllocationWriter(it)')), showOAinfo); From jonathan.gibbons at sun.com Tue Sep 8 11:20:35 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 08 Sep 2009 18:20:35 +0000 Subject: hg: jdk7/tl/langtools: 6419701: DefaultFileManager clean up: URI.create; ... Message-ID: <20090908182040.7DCC1E24D@hg.openjdk.java.net> Changeset: 35e29f51a7c3 Author: jjg Date: 2009-09-08 11:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/35e29f51a7c3 6419701: DefaultFileManager clean up: URI.create 6483788: DefaultFileManager.ZipFileObject.toUri() fails to escape space characters 6501502: JSR 199: FileObject.toUri should return file:///c:/ or file:/c:/ not file://c:/ 6877206: JavaFileObject.toUri returns bogus URI (win) 6877223: tests @ignored because of issues with File.toURI on Windows Reviewed-by: mcimadamore, alanb ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! test/tools/javac/Diagnostics/6769027/tester.properties ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/Sibling.java + test/tools/javac/api/T6483788.java + test/tools/javac/api/T6501502.java + test/tools/javac/api/T6877206.java From jonathan.gibbons at sun.com Tue Sep 8 11:38:59 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 08 Sep 2009 18:38:59 +0000 Subject: hg: jdk7/tl/langtools: 6879346: files have Windows newlines Message-ID: <20090908183904.4E176E254@hg.openjdk.java.net> Changeset: dd98acd9f717 Author: jjg Date: 2009-09-08 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dd98acd9f717 6879346: files have Windows newlines Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testCRLineSeparator/pkg/MyClass.java ! test/com/sun/javadoc/testHref/package-list ! test/com/sun/javadoc/testLinkOption/testNewLineInLink/package.html ! test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testRelativeLinks/pkg/package.html ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testWarnings/pkg/package.html ! test/tools/javah/SubClassConsts.win From jonathan.gibbons at sun.com Tue Sep 8 11:52:20 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 08 Sep 2009 18:52:20 +0000 Subject: hg: jdk7/tl/langtools: 6879371: javap does not close internal default file manager Message-ID: <20090908185225.9D5B1E259@hg.openjdk.java.net> Changeset: 261c54b2312e Author: jjg Date: 2009-09-08 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/261c54b2312e 6879371: javap does not close internal default file manager Reviewed-by: darcy ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/T6879371.java From mandy.chung at sun.com Tue Sep 8 13:12:35 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Tue, 08 Sep 2009 20:12:35 +0000 Subject: hg: jdk7/tl/jdk: 7 new changesets Message-ID: <20090908201437.B63FAE2D9@hg.openjdk.java.net> Changeset: fdf11ce72e8e Author: mchung Date: 2009-08-06 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fdf11ce72e8e 4917309: (cl) Reduce internal usage of ClassNotFoundExceptions during class-loading Summary: Change findBootstrapClass to return null instead of throwing CNFE if class not found Reviewed-by: alanb, dholmes, iris ! src/share/classes/java/lang/ClassLoader.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/ClassLoader.c Changeset: 3323e6c925f9 Author: mchung Date: 2009-08-06 16:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3323e6c925f9 6864028: Update the java launcher to use the new entry point JVM_FindClassFromBootLoader Summary: Update the java launcher to use the new entry point JVM_FindClassFromBootLoader Reviewed-by: ksrini ! src/share/bin/java.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c Changeset: 1f1c824e6244 Author: mchung Date: 2009-08-24 10:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f1c824e6244 Merge - src/share/classes/com/sun/crypto/provider/JarVerifier.java - src/share/classes/javax/swing/plaf/basic/DesktopIconMover.java - src/share/classes/sun/nio/ch/AbstractFuture.java - src/share/classes/sun/security/pkcs11/JarVerifier.java - src/windows/classes/sun/security/mscapi/JarVerifier.java Changeset: 799731b1cd03 Author: mchung Date: 2009-08-27 12:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/799731b1cd03 Merge - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: dfb5cf81d8cd Author: mchung Date: 2009-09-03 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfb5cf81d8cd Merge Changeset: b9b7f56bdfa3 Author: mchung Date: 2009-09-04 15:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b9b7f56bdfa3 Merge Changeset: 466915134131 Author: mchung Date: 2009-09-08 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/466915134131 Merge From jonathan.gibbons at sun.com Tue Sep 8 14:07:28 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 08 Sep 2009 21:07:28 +0000 Subject: hg: jdk7/tl/langtools: 5093723: REGRESSION: ClassCastException in SingleIndexWriter Message-ID: <20090908210735.49896E2E4@hg.openjdk.java.net> Changeset: ebb6ad5a95bb Author: jjg Date: 2009-09-08 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ebb6ad5a95bb 5093723: REGRESSION: ClassCastException in SingleIndexWriter Reviewed-by: jjg Contributed-by: ahe at google.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/5093723/DocumentedClass.java + test/com/sun/javadoc/5093723/T5093723.java + test/com/sun/javadoc/5093723/UndocumentedClass.java From jonathan.gibbons at sun.com Tue Sep 8 14:19:13 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 08 Sep 2009 21:19:13 +0000 Subject: hg: jdk7/tl/langtools: 6709246: ClassCastException in javadoc Message-ID: <20090908211923.6C716E2EB@hg.openjdk.java.net> Changeset: 071a4e36cd87 Author: jjg Date: 2009-09-08 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/071a4e36cd87 6709246: ClassCastException in javadoc Reviewed-by: jjg Contributed-by: ahe at google.com ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/tools/javadoc/annotations/missing/Main.java + test/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java From martinrb at google.com Tue Sep 8 16:39:09 2009 From: martinrb at google.com (martinrb at google.com) Date: Tue, 08 Sep 2009 23:39:09 +0000 Subject: hg: jdk7/tl/jdk: 6850958: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit Message-ID: <20090908233956.9A942E308@hg.openjdk.java.net> Changeset: 0d50d40a4a39 Author: martin Date: 2009-09-08 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d50d40a4a39 6850958: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit Summary: Test hotspot/jvmti fix 6850957 using ProcessBuilder test infrastructure Reviewed-by: tbell, dholmes, alanb, ysr ! test/java/lang/ProcessBuilder/Basic.java From gkorland at gmail.com Tue Sep 8 22:01:09 2009 From: gkorland at gmail.com (Guy Korland) Date: Wed, 9 Sep 2009 08:01:09 +0300 Subject: -Xrunhprof start time Message-ID: <79be5fa30909082201ie8989b0l17f7e7fc2785e182@mail.gmail.com> Hi, -Xrunhprof is very useful as a light weight profiler especially using cpu=samples.But the lack of controls makes it many time useless. e.g. setting the start time or a trigger for the profile information collection start time. Also a more control like a profile dump on request (like ctrl+break) -- Thanks, Guy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20090909/6bc5f73c/attachment.html From Alan.Bateman at Sun.COM Wed Sep 9 01:57:33 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Wed, 09 Sep 2009 09:57:33 +0100 Subject: Review request for 6529758: JVMTI Waiters demo crashes. Double free. Message-ID: <4AA76DFD.6000402@sun.com> This one is a fix to the JVM TI "waiters" demo. When the VM terminates, the agent frees the Monitors on its list but some may already have been freed by the ObjectFree callback. The fix changes the ObjectFree callback so that it removes the Monitor from the agent's list. I also eliminated the raw monitor used in Agent::get_monitor - it's not needed because the raw monitor used for handling VMDeath events prevents any concurrent execution of the agent's callbacks. A production variant of this demo would likely use RWL, in which case the agent's callback would need locking around access to the monitor list. The webrev is here: http://cr.openjdk.java.net/~alanb/6529758/webrev.00/ Thanks, Alan. From sean.mullan at sun.com Wed Sep 9 09:52:58 2009 From: sean.mullan at sun.com (sean.mullan at sun.com) Date: Wed, 09 Sep 2009 16:52:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090909165352.6752BE36B@hg.openjdk.java.net> Changeset: 8252729d51a3 Author: mullan Date: 2009-09-09 09:54 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8252729d51a3 6745437: Add option to only check revocation of end-entity certificate in a chain of certificates 6869739: Cannot check revocation of single certificate without validating the entire chain Reviewed-by: xuelei + src/share/classes/sun/security/action/GetBooleanSecurityPropertyAction.java ! src/share/classes/sun/security/provider/certpath/Builder.java ! src/share/classes/sun/security/provider/certpath/CertId.java ! src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java + src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! src/share/classes/sun/security/x509/AccessDescription.java Changeset: 7b85ef3d752e Author: mullan Date: 2009-09-09 09:59 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b85ef3d752e Merge From lance.andersen at sun.com Wed Sep 9 14:53:09 2009 From: lance.andersen at sun.com (lance.andersen at sun.com) Date: Wed, 09 Sep 2009 21:53:09 +0000 Subject: hg: jdk7/tl/jdk: 6737212: Fixed javadoc warning messages in RowSet classes Message-ID: <20090909215352.F154BE392@hg.openjdk.java.net> Changeset: f1eb4c28b313 Author: lancea Date: 2009-09-09 20:15 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1eb4c28b313 6737212: Fixed javadoc warning messages in RowSet classes Reviewed-by: darcy ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlReader.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java From karen.kinnear at sun.com Fri Sep 11 02:11:55 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Fri, 11 Sep 2009 09:11:55 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 10 new changesets Message-ID: <20090911091221.35447EF30@hg.openjdk.java.net> Changeset: 05f89f00a864 Author: jmasa Date: 2009-08-24 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/05f89f00a864 6798898: CMS: bugs related to class unloading Summary: Override should_remember_klasses() and remember_klass() as needed. Reviewed-by: ysr, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.inline.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp Changeset: e1fdf4fd34dc Author: tonyp Date: 2009-08-19 12:53 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e1fdf4fd34dc 6871111: G1: remove the concurrent overhead tracker Summary: Removing the concurrent overhead tracker from G1, along with the GC overhead reporter and the G1AccountConcurrentOverhead (both of which rely on the the concurrent overhead tracker). Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 ! src/share/vm/gc_implementation/includeDB_gc_shared - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: ead53f6b615d Author: tonyp Date: 2009-08-24 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ead53f6b615d Merge - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: b37c246bf7ce Author: jcoomes Date: 2009-08-11 15:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b37c246bf7ce 6861660: OopMapBlock count/size confusion Reviewed-by: tonyp, iveresov ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp Changeset: 9eebd3ac74cf Author: jcoomes Date: 2009-08-13 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/9eebd3ac74cf 6845368: large objects cause a crash or unexpected exception Reviewed-by: jmasa, iveresov ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp + test/gc/6845368/bigobj.java Changeset: 8624da129f0b Author: apetrusenko Date: 2009-08-31 05:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8624da129f0b 6841313: G1: dirty cards of survivor regions in parallel Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 8b46c4d82093 Author: ysr Date: 2009-09-02 00:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8b46c4d82093 4957990: Perm heap bloat in JVM Summary: Treat ProfileData in MDO's as a source of weak, not strong, roots. Fixes the bug for stop-world collection -- the case of concurrent collection will be fixed separately. Reviewed-by: jcoomes, jmasa, kvn, never ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.inline.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: 2c79770d1f6e Author: tonyp Date: 2009-07-30 16:22 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/2c79770d1f6e 6819085: G1: use larger and/or user settable region size Summary: Instead of the region size being hard-coded, allow the user to set it. Reviewed-by: jmasa, johnc, apetrusenko ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 Changeset: b1606b3c0a8a Author: apetrusenko Date: 2009-09-04 05:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b1606b3c0a8a Merge ! src/share/vm/code/nmethod.cpp - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: 682194ca1d8d Author: acorn Date: 2009-09-10 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/682194ca1d8d Merge - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp ! src/share/vm/oops/instanceKlass.cpp From xueming.shen at sun.com Fri Sep 11 16:45:15 2009 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Fri, 11 Sep 2009 23:45:15 +0000 Subject: hg: jdk7/tl/jdk: 6881337: ZipEntry.setComment() was accidentally changed back to old spec/impl in jdk7-b64 Message-ID: <20090911234603.9E71112044@hg.openjdk.java.net> Changeset: 46406871599c Author: sherman Date: 2009-09-11 16:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/46406871599c 6881337: ZipEntry.setComment() was accidentally changed back to old spec/impl in jdk7-b64 Summary: restored the correct spec and implementation of setComment Reviewed-by: martin ! src/share/classes/java/util/zip/ZipEntry.java From Tim.Bell at Sun.COM Sat Sep 12 10:50:11 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Sat, 12 Sep 2009 10:50:11 -0700 Subject: Review request for 6529758: JVMTI Waiters demo crashes. Double free. In-Reply-To: <4AA76DFD.6000402@sun.com> References: <4AA76DFD.6000402@sun.com> Message-ID: <4AABDF53.8050803@sun.com> Alan Bateman wrote: > This one is a fix to the JVM TI "waiters" demo. When the VM terminates, > the agent frees the Monitors on its list but some may already have been > freed by the ObjectFree callback. The fix changes the ObjectFree > callback so that it removes the Monitor from the agent's list. Looks good to me - approved! Tim > eliminated the raw monitor used in Agent::get_monitor - it's not needed > because the raw monitor used for handling VMDeath events prevents any > concurrent execution of the agent's callbacks. A production variant of > this demo would likely use RWL, in which case the agent's callback would > need locking around access to the monitor list. > > The webrev is here: > http://cr.openjdk.java.net/~alanb/6529758/webrev.00/ > > Thanks, > Alan. From martinrb at google.com Sat Sep 12 15:32:32 2009 From: martinrb at google.com (martinrb at google.com) Date: Sat, 12 Sep 2009 22:32:32 +0000 Subject: hg: jdk7/tl/jdk: 6881442: (reflect) Race condition in Class.getName() Message-ID: <20090912223309.8736A12067@hg.openjdk.java.net> Changeset: 020a0fed38c9 Author: martin Date: 2009-09-12 15:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/020a0fed38c9 6881442: (reflect) Race condition in Class.getName() Summary: only read "name" field racily once Reviewed-by: darcy ! src/share/classes/java/lang/Class.java From Daniel.Daugherty at Sun.COM Sat Sep 12 20:22:18 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Sat, 12 Sep 2009 21:22:18 -0600 Subject: OpenJDK code review request for jmethodID and JNI itable cache race fixes (6419370) Message-ID: <4AAC656A.1020103@sun.com> Greetings, I'm looking for a couple of OpenJDK code reviewers for my fix to the following bug: 6419370 4/4 new jmethodID code has tiny holes in synchronization The synopsis is a bit misleading since two different caches are involved: - the jmethodID cache - the JNI itable index cache Both of these caches are used by the regular system and when JVM/TI is used so this code is applicable outside my usual Serviceability arena. That's why this code review request is so wide... Here is the URL for the OpenJDK code review round 1 webrev: http://cr.openjdk.java.net/~dcubed/6419370-webrev/1-open/ I've updated the bug with descriptions of the races involved: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6419370 See Evaluation note #3 for a walk through that refers to both old and new code. I'm targeting this fix for HSX-17-B02 so I'd like to hear back from at least one reviewer in a week or so... Thanks, in advance, for any feedback! Dan From john.coomes at sun.com Sun Sep 13 14:34:34 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 13 Sep 2009 21:34:34 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk Message-ID: <20090913213441.61F9B1209B@hg.openjdk.java.net> Changeset: 0fc81f0a8ca8 Author: andrew Date: 2009-09-12 12:50 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0fc81f0a8ca8 6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk Summary: The build fails if the bootstrap JDK defaults to <1.5 Reviewed-by: jcoomes ! make/linux/makefiles/jvmti.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/jvmti.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/sa.make ! make/solaris/makefiles/top.make ! make/windows/makefiles/generated.make ! make/windows/makefiles/jvmti.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sa.make ! make/windows/projectfiles/common/Makefile From alan.bateman at sun.com Mon Sep 14 10:03:40 2009 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Mon, 14 Sep 2009 17:03:40 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090914170432.B75AF1210B@hg.openjdk.java.net> Changeset: 060c4c7082ef Author: alanb Date: 2009-09-14 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/060c4c7082ef 6529758: JVMTI Waiters demo crashes. Double free. Reviewed-by: ohair, tbell ! src/share/demo/jvmti/waiters/Agent.cpp ! src/share/demo/jvmti/waiters/Agent.hpp ! src/share/demo/jvmti/waiters/Monitor.cpp ! src/share/demo/jvmti/waiters/Monitor.hpp Changeset: aac01ec2cec4 Author: alanb Date: 2009-09-14 17:47 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aac01ec2cec4 6876541: (file) Files.walkFileTree(...): no SecurityException if read access to the starting file is denied Reviewed-by: chegar ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java + test/java/nio/file/Files/WalkWithSecurity.java + test/java/nio/file/Files/denyAll.policy + test/java/nio/file/Files/grantAll.policy + test/java/nio/file/Files/grantTopOnly.policy From kevin.walls at sun.com Mon Sep 14 12:57:06 2009 From: kevin.walls at sun.com (kevin.walls at sun.com) Date: Mon, 14 Sep 2009 19:57:06 +0000 Subject: hg: jdk7/tl/jdk: 6842838: 64-bit failure in handling invalid manifest in launcher. Message-ID: <20090914195748.B8D6712176@hg.openjdk.java.net> Changeset: eb19c5dc52bf Author: kevinw Date: 2009-09-14 20:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb19c5dc52bf 6842838: 64-bit failure in handling invalid manifest in launcher. Summary: Don't compare with hard-coded 32-bit -1 when checking zip fields. Reviewed-by: ksrini ! src/share/bin/parse_manifest.c + test/tools/launcher/6842838/CreateBadJar.java + test/tools/launcher/6842838/Test6842838.sh From mandy.chung at sun.com Mon Sep 14 13:44:22 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Mon, 14 Sep 2009 20:44:22 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090914204454.07EA912181@hg.openjdk.java.net> Changeset: c7e469ae3edb Author: mchung Date: 2009-09-14 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c7e469ae3edb 6878481: Add performance counters in the JDK Summary: Added new performance counters in the JDK to track performance metrics Reviewed-by: alanb, dholmes, iris, forax, andrew ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/zip/ZipFile.java + src/share/classes/sun/misc/PerfCounter.java ! src/windows/classes/sun/java2d/d3d/D3DGraphicsDevice.java Changeset: 0a3244fe7142 Author: mchung Date: 2009-09-14 13:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a3244fe7142 Merge From jonathan.gibbons at sun.com Mon Sep 14 17:15:42 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 15 Sep 2009 00:15:42 +0000 Subject: hg: jdk7/tl/langtools: 6881317: regression: NPE in CloseableURLClassLoader Message-ID: <20090915001550.EA9F612199@hg.openjdk.java.net> Changeset: f8be8bf150c3 Author: jjg Date: 2009-09-14 17:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f8be8bf150c3 6881317: regression: NPE in CloseableURLClassLoader Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java From daniel.daugherty at sun.com Mon Sep 14 17:51:16 2009 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Tue, 15 Sep 2009 00:51:16 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090915005310.1407B121AA@hg.openjdk.java.net> Changeset: f0182203084a Author: dcubed Date: 2009-09-14 18:45 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0182203084a 6862295: JDWP threadid changes during debugging session (leading to ingored breakpoints) Summary: New test for the above fix. Reviewed-by: tbell + test/com/sun/jdi/BreakpointWithFullGC.sh Changeset: f78b7d9973b7 Author: dcubed Date: 2009-09-14 18:54 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f78b7d9973b7 Merge From jonathan.gibbons at sun.com Tue Sep 15 12:22:02 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 15 Sep 2009 19:22:02 +0000 Subject: hg: jdk7/tl/langtools: 6882235: invalid exponent causes silent javac crash Message-ID: <20090915192203.BF6CB1221C@hg.openjdk.java.net> Changeset: 9dd34ed62341 Author: jjg Date: 2009-09-15 12:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9dd34ed62341 6882235: invalid exponent causes silent javac crash Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T6882235.java + test/tools/javac/T6882235.out From karen.kinnear at sun.com Tue Sep 15 18:11:43 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Wed, 16 Sep 2009 01:11:43 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 14 new changesets Message-ID: <20090916011213.86F8412242@hg.openjdk.java.net> Changeset: b1f5ced5da21 Author: jcoomes Date: 2009-09-03 19:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b1f5ced5da21 6879076: disable jprt sync after builds are done Reviewed-by: kamg, dholmes ! make/jprt.properties Changeset: 68ef3fdcdb76 Author: ysr Date: 2009-09-10 16:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/68ef3fdcdb76 6872136: CMS: confusing message may be printed when a collector is switched off implicitly Summary: Fix CDS/CMS option overrides related to iCMS option CMSIncrementalMode; explicate overrides to error stream. Reviewed-by: coleenp ! src/share/vm/runtime/arguments.cpp Changeset: 489a4f8dcd0f Author: twisti Date: 2009-08-27 06:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/489a4f8dcd0f 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String Summary: ldc seems to load an empty String and that leads to an assert on offset < length, which are both zero. Reviewed-by: kvn, never ! src/share/vm/classfile/javaClasses.cpp Changeset: 8fe1963e3964 Author: kvn Date: 2009-08-28 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8fe1963e3964 6875577: CTW fails with /hotspot/src/share/vm/opto/memnode.cpp Summary: Fix do_null_check to check for unloaded klass for all oop pointers. Reviewed-by: never, cfang ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp Changeset: 1fbd5d696bf4 Author: twisti Date: 2009-08-31 02:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1fbd5d696bf4 6875967: CTW fails with./generated/adfiles/ad_sparc.cpp:6711 Reviewed-by: cfang, never ! src/cpu/sparc/vm/sparc.ad Changeset: ace8397c8563 Author: cfang Date: 2009-08-31 08:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ace8397c8563 6876276: assert(!is_visited,"visit only once") Summary: schedule the superword loads based on dependence constraints Reviewed-by: kvn, never ! src/share/vm/opto/superword.cpp ! test/compiler/6636138/Test1.java ! test/compiler/6636138/Test2.java Changeset: ff1a29907b6c Author: never Date: 2009-08-31 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ff1a29907b6c 6855215: Calculation error (NaN) after about 1500 calculations Reviewed-by: kvn ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp + test/compiler/6855215/Test6855215.java Changeset: 0f1c19b7a52d Author: kvn Date: 2009-09-08 10:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0f1c19b7a52d 6875619: CTW fails with /hotspot/src/share/vm/opto/type.hpp Summary: In load_array_length() cast array's type to TypeOopPtr when calling make_ideal_length() method. Reviewed-by: never ! src/share/vm/opto/graphKit.cpp Changeset: 26fbe81d30cf Author: kvn Date: 2009-09-08 16:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/26fbe81d30cf 6880052: SIGSEGV in GraphKit::null_check_common() Summary: Check that a klass is not NULL before the is_loaded() call. Reviewed-by: never ! src/share/vm/opto/graphKit.cpp Changeset: 9a4e87ba1a90 Author: kvn Date: 2009-09-09 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/9a4e87ba1a90 6880533: test/compiler/6865031/Test.java miss -XX:+IgnoreUnrecognizedVMOptions Summary: Add missing test option -XX:+IgnoreUnrecognizedVMOptions. Reviewed-by: never ! test/compiler/6865031/Test.java Changeset: 159d56b94894 Author: kvn Date: 2009-09-10 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/159d56b94894 6880574: C2 assert in escape.cpp:445 on linux-amd64 Summary: Look through chained AddP nodes in get_addp_base(). Reviewed-by: jrose ! src/share/vm/opto/escape.cpp Changeset: c7e94e8fff43 Author: kvn Date: 2009-09-10 18:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c7e94e8fff43 6880053: assert(alloc_obj->as_CheckCastPP()->type() != TypeInstPtr::NOTNULL) Summary: Removed second CheckCastPP and use MembarCPUOrder after arraycopy to cloned object. Reviewed-by: never ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: a6f533fc33e0 Author: kvn Date: 2009-09-14 11:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a6f533fc33e0 Merge Changeset: e5b31fd85b72 Author: acorn Date: 2009-09-15 16:28 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e5b31fd85b72 Merge From jonathan.gibbons at sun.com Tue Sep 15 18:37:26 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 16 Sep 2009 01:37:26 +0000 Subject: hg: jdk7/tl/langtools: 6860965: Project Coin: binary literals; ... Message-ID: <20090916013728.7A9981224D@hg.openjdk.java.net> Changeset: 69eaccd3ea85 Author: jjg Date: 2009-09-15 18:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/69eaccd3ea85 6860965: Project Coin: binary literals 6860973: Project Coin: Underscores in literals Summary: [Portions contributed by Bruce Chapman] Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/enum/6384542/T6384542.out + test/tools/javac/literals/BadBinaryLiterals.6.out + test/tools/javac/literals/BadBinaryLiterals.7.out + test/tools/javac/literals/BadBinaryLiterals.java + test/tools/javac/literals/BadUnderscoreLiterals.6.out + test/tools/javac/literals/BadUnderscoreLiterals.7.out + test/tools/javac/literals/BadUnderscoreLiterals.java + test/tools/javac/literals/BinaryLiterals.java + test/tools/javac/literals/UnderscoreLiterals.java From Daniel.Daugherty at Sun.COM Tue Sep 15 20:15:51 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Tue, 15 Sep 2009 21:15:51 -0600 Subject: code review request for suspend/resume deadlock (6876794) Message-ID: <4AB05867.10501@sun.com> Greetings, I'm looking for a couple of OpenJDK code reviewers for my fix to the following bug: 6876794 4/4 sp07t002 hangs very intermittently This one is a classic suspend/resume three-way deadlock caused by a case of over locking so I figured I would give this one a wider review. Here is the URL for code review round 0 webrev: http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ I'm targeting this fix for HSX-17-B02 so I'd like to hear back from at least one reviewer in a week or so... Thanks, in advance, for any feedback! Dan From daniel.daugherty at sun.com Tue Sep 15 21:13:28 2009 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Wed, 16 Sep 2009 04:13:28 +0000 Subject: hg: jdk7/tl/jdk: 6882363: 4/4 typos in java.util.logging javadocs Message-ID: <20090916041404.D86C512266@hg.openjdk.java.net> Changeset: e8c2dd4b8bac Author: dcubed Date: 2009-09-15 22:11 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8c2dd4b8bac 6882363: 4/4 typos in java.util.logging javadocs Summary: Fix typos, some grammar and some inconsistencies in phrasing. Reviewed-by: tbell ! src/share/classes/java/util/logging/ErrorManager.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Formatter.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/Level.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/LoggingMXBean.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java From David.Holmes at Sun.COM Wed Sep 16 02:14:23 2009 From: David.Holmes at Sun.COM (David Holmes - Sun Microsystems) Date: Wed, 16 Sep 2009 19:14:23 +1000 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB05867.10501@sun.com> References: <4AB05867.10501@sun.com> Message-ID: <4AB0AC6F.9070309@sun.com> Hi Dan, As per the CR comments I agree with the analysis and the fix. Thanks, David Daniel D. Daugherty said the following on 09/16/09 13:15: > Greetings, > > I'm looking for a couple of OpenJDK code reviewers for my fix to > the following bug: > > 6876794 4/4 sp07t002 hangs very intermittently > > This one is a classic suspend/resume three-way deadlock caused by > a case of over locking so I figured I would give this one a wider > review. > > Here is the URL for code review round 0 webrev: > > http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ > > I'm targeting this fix for HSX-17-B02 so I'd like to hear back > from at least one reviewer in a week or so... > > Thanks, in advance, for any feedback! > > Dan > From Daniel.Daugherty at Sun.COM Wed Sep 16 07:43:40 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Wed, 16 Sep 2009 08:43:40 -0600 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB0AC6F.9070309@sun.com> References: <4AB05867.10501@sun.com> <4AB0AC6F.9070309@sun.com> Message-ID: <4AB0F99C.4060504@sun.com> David, thanks for the fast review! Dan David Holmes - Sun Microsystems wrote: > Hi Dan, > > As per the CR comments I agree with the analysis and the fix. > > Thanks, > David > > Daniel D. Daugherty said the following on 09/16/09 13:15: >> Greetings, >> >> I'm looking for a couple of OpenJDK code reviewers for my fix to >> the following bug: >> >> 6876794 4/4 sp07t002 hangs very intermittently >> >> This one is a classic suspend/resume three-way deadlock caused by >> a case of over locking so I figured I would give this one a wider >> review. >> >> Here is the URL for code review round 0 webrev: >> >> http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ >> >> I'm targeting this fix for HSX-17-B02 so I'd like to hear back >> from at least one reviewer in a week or so... >> >> Thanks, in advance, for any feedback! >> >> Dan >> From karen.kinnear at sun.com Wed Sep 16 10:28:09 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Wed, 16 Sep 2009 17:28:09 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 2 new changesets Message-ID: <20090916172818.6B8CE122E2@hg.openjdk.java.net> Changeset: ad6585fd4087 Author: acorn Date: 2009-09-04 12:53 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ad6585fd4087 6830542: Performance: JVM_DefineClass already verified. Reviewed-by: kamg, phh ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 26b774d693aa Author: acorn Date: 2009-09-16 09:10 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/26b774d693aa Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp From karen.kinnear at sun.com Wed Sep 16 20:40:25 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Thu, 17 Sep 2009 03:40:25 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6879572: SA fails _is_marked_dependent not found Message-ID: <20090917034032.4DA401230A@hg.openjdk.java.net> Changeset: 83c29a26f67c Author: acorn Date: 2009-09-16 15:42 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/83c29a26f67c 6879572: SA fails _is_marked_dependent not found Reviewed-by: kamg, dcubed ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/runtime/vmStructs.cpp From tim.bell at sun.com Thu Sep 17 11:09:07 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 17 Sep 2009 18:09:07 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20090917180908.0077C12342@hg.openjdk.java.net> Changeset: 4079d923a501 Author: peterz Date: 2009-08-31 14:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4079d923a501 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README-builds.html Changeset: 0d7e03b426df Author: yan Date: 2009-09-09 00:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/0d7e03b426df Merge From tim.bell at sun.com Thu Sep 17 11:09:47 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 17 Sep 2009 18:09:47 +0000 Subject: hg: jdk7/tl/hotspot: 31 new changesets Message-ID: <20090917181049.9CCD412349@hg.openjdk.java.net> Changeset: a05ea7791ee3 Author: trims Date: 2009-08-21 20:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a05ea7791ee3 6873236: Fork HS16 to HS17 - renumber Major and build numbers of JVM Summary: Update the Major and build numbers for HS17 fork Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1760a1cbed36 Author: dcubed Date: 2009-08-11 11:57 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1760a1cbed36 6862945: 4/3 conversion of jmethodID to methodOop in JVMTI is too expensive Summary: Refactor JNIHandles::checked_resolve_jmethod_id() into fast and paranoid parts. Reviewed-by: never, alanb ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/runtime/jniHandles.hpp Changeset: 6ab1d6ece8bd Author: apangin Date: 2009-08-17 15:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6ab1d6ece8bd Merge Changeset: 585222cadf79 Author: apangin Date: 2009-08-19 15:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/585222cadf79 Merge Changeset: a774e1abbe85 Author: trims Date: 2009-08-21 20:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a774e1abbe85 Merge Changeset: 046932b72aa2 Author: never Date: 2009-08-14 00:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode Reviewed-by: kvn, twisti ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp Changeset: 1a81ea4b45d4 Author: kvn Date: 2009-08-14 12:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1a81ea4b45d4 6869822: assert(Universe::narrow_oop_shift() == 0,"use unscaled narrow oop") Summary: Replace the assert with narrow_oop_shift set to 0. Reviewed-by: never, jcoomes ! src/share/vm/memory/universe.cpp Changeset: a70508bb21c3 Author: never Date: 2009-08-14 15:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a70508bb21c3 6862863: C2 compiler fails in elide_copy() Reviewed-by: kvn ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/postaloc.cpp Changeset: 55784fd95fe3 Author: never Date: 2009-08-14 15:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/55784fd95fe3 Merge Changeset: 7c14587118b3 Author: never Date: 2009-08-14 22:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7c14587118b3 Merge Changeset: c8e2135f7e30 Author: cfang Date: 2009-08-17 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c8e2135f7e30 6829127: Deoptimization Failure on Specjvm98 _227_mtrt with -XX:+DeoptimizeALot since Hs11 b01 Summary: Make sure the control word is correct in deopt_blob after restore_result_registers Reviewed-by: kvn, never ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp Changeset: 662f330d7275 Author: cfang Date: 2009-08-17 12:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/662f330d7275 6866651: Regression: simple int sum crashes jvm (build 1.6.0_14-b08 and 1.7.0-ea-b59) Summary: delay dead code elimination in set_req_X to make it safe Reviewed-by: kvn, never ! src/share/vm/opto/phaseX.cpp + test/compiler/6866651/Test.java Changeset: d0acbc302e14 Author: never Date: 2009-08-17 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d0acbc302e14 6795465: Crash in assembler_sparc.cpp with client compiler on solaris-sparc Reviewed-by: twisti, cfang ! src/cpu/sparc/vm/c1_Defs_sparc.hpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/share/vm/includeDB_compiler1 + test/compiler/6795465/Test6795465.java Changeset: cd18bd5e667c Author: never Date: 2009-08-19 18:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cd18bd5e667c 6873777: FPU control word optimization still performed with SSE Reviewed-by: kvn ! src/share/vm/opto/compile.cpp Changeset: 357d4e2eb4dd Author: kvn Date: 2009-08-19 19:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/357d4e2eb4dd 6873799: enable escape analysis by default Summary: enable escape analysis by default Reviewed-by: never ! src/share/vm/opto/c2_globals.hpp Changeset: 72088be4b386 Author: cfang Date: 2009-08-20 12:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/72088be4b386 6873116: Modify reexecute implementation to use pcDesc to record the reexecute bit Summary: use PcDesc to keep record of the reexecute bit instead of using DebugInfoStreams Reviewed-by: kvn, never, twisti ! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/code/debugInfo.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/scopeDesc.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 82bd76d4d7f2 Author: kvn Date: 2009-08-24 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/82bd76d4d7f2 6873800: enable compressed oops by default Summary: enable compressed oops by default Reviewed-by: never, ysr ! src/share/vm/runtime/arguments.cpp Changeset: cdb8b7c37ac1 Author: never Date: 2009-08-24 22:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cdb8b7c37ac1 6875329: fix for 6795465 broke exception handler cloning Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Changeset: aba04734b61e Author: kvn Date: 2009-08-25 13:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/aba04734b61e Merge Changeset: 05f89f00a864 Author: jmasa Date: 2009-08-24 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/05f89f00a864 6798898: CMS: bugs related to class unloading Summary: Override should_remember_klasses() and remember_klass() as needed. Reviewed-by: ysr, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.inline.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp Changeset: e1fdf4fd34dc Author: tonyp Date: 2009-08-19 12:53 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e1fdf4fd34dc 6871111: G1: remove the concurrent overhead tracker Summary: Removing the concurrent overhead tracker from G1, along with the GC overhead reporter and the G1AccountConcurrentOverhead (both of which rely on the the concurrent overhead tracker). Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 ! src/share/vm/gc_implementation/includeDB_gc_shared - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: ead53f6b615d Author: tonyp Date: 2009-08-24 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ead53f6b615d Merge - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: b37c246bf7ce Author: jcoomes Date: 2009-08-11 15:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b37c246bf7ce 6861660: OopMapBlock count/size confusion Reviewed-by: tonyp, iveresov ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp Changeset: 9eebd3ac74cf Author: jcoomes Date: 2009-08-13 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9eebd3ac74cf 6845368: large objects cause a crash or unexpected exception Reviewed-by: jmasa, iveresov ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp + test/gc/6845368/bigobj.java Changeset: 8624da129f0b Author: apetrusenko Date: 2009-08-31 05:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8624da129f0b 6841313: G1: dirty cards of survivor regions in parallel Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 8b46c4d82093 Author: ysr Date: 2009-09-02 00:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8b46c4d82093 4957990: Perm heap bloat in JVM Summary: Treat ProfileData in MDO's as a source of weak, not strong, roots. Fixes the bug for stop-world collection -- the case of concurrent collection will be fixed separately. Reviewed-by: jcoomes, jmasa, kvn, never ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.inline.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: 2c79770d1f6e Author: tonyp Date: 2009-07-30 16:22 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2c79770d1f6e 6819085: G1: use larger and/or user settable region size Summary: Instead of the region size being hard-coded, allow the user to set it. Reviewed-by: jmasa, johnc, apetrusenko ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 Changeset: b1606b3c0a8a Author: apetrusenko Date: 2009-09-04 05:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b1606b3c0a8a Merge ! src/share/vm/code/nmethod.cpp - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp Changeset: b1f5ced5da21 Author: jcoomes Date: 2009-09-03 19:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b1f5ced5da21 6879076: disable jprt sync after builds are done Reviewed-by: kamg, dholmes ! make/jprt.properties Changeset: 68ef3fdcdb76 Author: ysr Date: 2009-09-10 16:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/68ef3fdcdb76 6872136: CMS: confusing message may be printed when a collector is switched off implicitly Summary: Fix CDS/CMS option overrides related to iCMS option CMSIncrementalMode; explicate overrides to error stream. Reviewed-by: coleenp ! src/share/vm/runtime/arguments.cpp Changeset: a94714c55065 Author: trims Date: 2009-09-15 20:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a94714c55065 Merge From tim.bell at sun.com Thu Sep 17 11:12:35 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 17 Sep 2009 18:12:35 +0000 Subject: hg: jdk7/tl/jdk: 30 new changesets Message-ID: <20090917181908.4B32E12352@hg.openjdk.java.net> Changeset: 559fb14d0ae9 Author: anthony Date: 2009-08-27 16:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/559fb14d0ae9 6780496: Javaw process taking up 80-90 percent of CPU time! Summary: The transparency effects get enabled on showing, and disabled on hiding a window Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: 7599cca4fe5e Author: dcherepanov Date: 2009-08-27 17:04 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7599cca4fe5e 6852051: Getting Null Pointer Exception when displaying message for TrayIcon on Opensolaris Reviewed-by: anthony ! src/share/classes/java/awt/Component.java Changeset: 911a82b4901f Author: dcherepanov Date: 2009-08-27 17:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/911a82b4901f 6854898: Frame is located at the negative coordinates instead of origin for Solaris 10 CDE Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XErrorHandler.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: d5ac8fb96d13 Author: anthony Date: 2009-08-28 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5ac8fb96d13 6689468: test/closed/java/awt/Component/VisibleHwInLwContTest/VisibleHwInLwContTest.html fails Summary: The addNotify() checks whether the component is actually hidden, and hides the peer appropriately if needed Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java Changeset: d755ace580b2 Author: yan Date: 2009-09-04 14:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d755ace580b2 6871299: Shift+Tab no longer generates a KEY_TYPED event; used to with JRE 1.5 Summary: Add XK_ISO_Left_Tab -> VK_TAB rule Reviewed-by: dcherepanov ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: 5a584fbcc712 Author: yan Date: 2009-09-09 00:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5a584fbcc712 Merge Changeset: a48c15bcf64f Author: rupashka Date: 2009-08-14 13:18 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a48c15bcf64f 6824600: OOM occurs when setLookAndFeel() is executed in Windows L&F(XP style) Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/DesktopProperty.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalFontDesktopProperty.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java + test/com/sun/java/swing/plaf/windows/Test6824600.java Changeset: fa334ff12794 Author: alexp Date: 2009-08-19 17:24 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa334ff12794 6872492: JLayer sources contain wrong header Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/plaf/LayerUI.java Changeset: 3e36c9abb569 Author: yan Date: 2009-08-20 23:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e36c9abb569 Merge - test/java/util/concurrent/ConcurrentLinkedQueue/ConcurrentQueueLoops.java - test/java/util/concurrent/ConcurrentLinkedQueue/LoopHelpers.java Changeset: e8d93257cf7e Author: rupashka Date: 2009-08-21 16:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8d93257cf7e 6579827: vista : JSlider on JColorchooser is not properly render or can't be seen completely. Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java + test/javax/swing/JSlider/6579827/bug6579827.java Changeset: d07bd8fa89e4 Author: rupashka Date: 2009-08-24 18:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d07bd8fa89e4 6849266: closed/javax/swing/JFileChooser/6484091/bug6484091.java fails on solaris 10 sparc Reviewed-by: peterz + test/javax/swing/JFileChooser/6484091/bug6484091.java Changeset: 799439873bf9 Author: alexp Date: 2009-08-24 19:22 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/799439873bf9 6824395: Several Swing core components prevent using them in wrapper classes Reviewed-by: peterz ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JLayer/6824395/bug6824395.java ! test/javax/swing/JLayer/SerializationTest/SerializationTest.java Changeset: 4914723317b9 Author: peytoia Date: 2009-08-31 12:55 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4914723317b9 6851214: (tz) New Jordan rule creates a failure for SimpleTimeZone parsing post tzdata2009h Reviewed-by: okutsu ! src/share/classes/java/util/SimpleTimeZone.java + test/java/util/TimeZone/ListTimeZones.java Changeset: 7aa6cb832991 Author: peytoia Date: 2009-08-31 14:50 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7aa6cb832991 6872467: (tz) Support tzdata2009l Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/factory ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/pacificnew ! make/sun/javazic/tzdata/solar87 ! make/sun/javazic/tzdata/solar88 ! make/sun/javazic/tzdata/solar89 ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/systemv ! make/sun/javazic/tzdata/zone.tab Changeset: 92b6482e7719 Author: peytoia Date: 2009-08-31 14:53 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92b6482e7719 6456628: (tz) Default timezone is incorrectly set occasionally on Linux Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c Changeset: f7d606ca25a9 Author: peterz Date: 2009-08-31 13:46 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f7d606ca25a9 6802944: Nimbus initialization is too slow Reviewed-by: jasper ! make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/DerivedColor.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java Changeset: 7e7153da24ef Author: peterz Date: 2009-08-31 13:56 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7e7153da24ef 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README ! make/common/Sanity.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/javax/swing/plaf/Makefile - make/javax/swing/plaf/nimbus/Makefile ! make/tools/Makefile + make/tools/generate_nimbus/Makefile + make/tools/src/build/tools/generatenimbus/Generator.java + make/tools/src/build/tools/generatenimbus/ObjectFactory.java + make/tools/src/build/tools/generatenimbus/Paint.java + make/tools/src/build/tools/generatenimbus/PainterGenerator.java + make/tools/src/build/tools/generatenimbus/Shape.java + make/tools/src/build/tools/generatenimbus/SynthModel.java + make/tools/src/build/tools/generatenimbus/UIDefault.java + make/tools/src/build/tools/generatenimbus/UIStyle.java + make/tools/src/build/tools/generatenimbus/Utils.java - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: e7d311b4ae94 Author: alexp Date: 2009-08-31 18:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7d311b4ae94 6872503: JLayer event handling should be rewritten Reviewed-by: art ! src/share/classes/javax/swing/JLayer.java + test/javax/swing/JLayer/6872503/bug6872503.java Changeset: 9d8f551780d5 Author: peytoia Date: 2009-09-01 15:39 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d8f551780d5 6830423: Unified Ext B character not displayed with Dialog font Reviewed-by: okutsu ! src/windows/classes/sun/awt/windows/fontconfig.properties Changeset: 37c33432e98a Author: peytoia Date: 2009-09-01 15:42 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/37c33432e98a 6838887: (tz) Add UTC and Yerevan to tzmappings Reviewed-by: okutsu ! src/windows/lib/tzmappings Changeset: 5780cff2763c Author: peytoia Date: 2009-09-01 16:15 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5780cff2763c 6856390: RFE : sequence.allfonts.UTF-8.ja for Windows fontconfig.properties Reviewed-by: okutsu ! src/windows/classes/sun/awt/windows/fontconfig.properties Changeset: 4f819e2e0bfc Author: peterz Date: 2009-09-01 15:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4f819e2e0bfc 6387579: Usage of package-private class as parameter of a method (javax.swing.tree.DefaultTreeSelectionModel) Reviewed-by: rupashka ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java Changeset: 935814bd43a6 Author: alexp Date: 2009-09-01 18:51 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/935814bd43a6 6875153: JLayer.isOptimizedDrawingEnabled() throws NPE for null glass pane set Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/plaf/LayerUI.java + test/javax/swing/JLayer/6875153/bug6875153.java Changeset: 281fbd82a971 Author: alexp Date: 2009-09-02 17:47 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/281fbd82a971 6797139: JButton title is truncating for some strings irrespective of preferred size. Reviewed-by: peterz ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java ! src/share/classes/sun/swing/MenuItemLayoutHelper.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/SwingUtilities/6797139/bug6797139.java Changeset: ff468ef27959 Author: gsm Date: 2009-09-07 12:27 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff468ef27959 6699856: Creating text in a JTextPane using Chinese text causes undesired behavior Reviewed-by: peterz ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/text/JTextComponent.java Changeset: 01c46cb72eb7 Author: rupashka Date: 2009-09-07 15:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01c46cb72eb7 6589634: Unable to view focus on "Up one level", "create new folder" etc. of JFileChooser Dialog Reviewed-by: peterz, loneid ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java Changeset: d73a741a7ea1 Author: malenkov Date: 2009-09-08 14:08 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d73a741a7ea1 6868185: 2 JCK api/java_beans/Introspector/ tests fails starting from jdk7 b66 Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/BeanInfoFinder.java Changeset: e289c06b6d36 Author: yan Date: 2009-09-09 00:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e289c06b6d36 Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: 460639b036f3 Author: yan Date: 2009-09-15 23:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/460639b036f3 Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: 81b85ea694f8 Author: tbell Date: 2009-09-16 09:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81b85ea694f8 Merge From Daniel.Daugherty at Sun.COM Thu Sep 17 14:34:37 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Thu, 17 Sep 2009 15:34:37 -0600 Subject: OpenJDK code review request for jmethodID and JNI itable cache race fixes (6419370) In-Reply-To: <4AAC656A.1020103@sun.com> References: <4AAC656A.1020103@sun.com> Message-ID: <4AB2AB6D.8040007@sun.com> Second Call for any OpenJDK reviewers! I will be closing the review window this weekend on this fix. Dan Daniel D. Daugherty wrote: > Greetings, > > I'm looking for a couple of OpenJDK code reviewers for my fix to > the following bug: > > 6419370 4/4 new jmethodID code has tiny holes in synchronization > > The synopsis is a bit misleading since two different caches are > involved: > > - the jmethodID cache > - the JNI itable index cache > > Both of these caches are used by the regular system and when JVM/TI > is used so this code is applicable outside my usual Serviceability > arena. That's why this code review request is so wide... > > Here is the URL for the OpenJDK code review round 1 webrev: > > http://cr.openjdk.java.net/~dcubed/6419370-webrev/1-open/ > > I've updated the bug with descriptions of the races involved: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6419370 > > See Evaluation note #3 for a walk through that refers to both > old and new code. > > I'm targeting this fix for HSX-17-B02 so I'd like to hear back > from at least one reviewer in a week or so... > > Thanks, in advance, for any feedback! > > Dan > > From john.coomes at sun.com Thu Sep 17 22:13:50 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:13:50 +0000 Subject: hg: jdk7/hotspot-rt: 3 new changesets Message-ID: <20090918051350.9E4B412434@hg.openjdk.java.net> Changeset: 4079d923a501 Author: peterz Date: 2009-08-31 14:10 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/4079d923a501 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README-builds.html Changeset: 0d7e03b426df Author: yan Date: 2009-09-09 00:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/0d7e03b426df Merge Changeset: 4c4fe09fb670 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/4c4fe09fb670 Added tag jdk7-b72 for changeset 0d7e03b426df ! .hgtags From john.coomes at sun.com Thu Sep 17 22:14:24 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:14:24 +0000 Subject: hg: jdk7/hotspot-rt/corba: Added tag jdk7-b72 for changeset c793a3120926 Message-ID: <20090918051426.48E7112439@hg.openjdk.java.net> Changeset: 12991b453239 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/12991b453239 Added tag jdk7-b72 for changeset c793a3120926 ! .hgtags From john.coomes at sun.com Thu Sep 17 22:17:47 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:17:47 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b72 for changeset 37c805b6156f Message-ID: <20090918051750.5C4EA1243E@hg.openjdk.java.net> Changeset: 93dfa6e0fe76 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/93dfa6e0fe76 Added tag jdk7-b72 for changeset 37c805b6156f ! .hgtags From john.coomes at sun.com Thu Sep 17 22:18:21 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:18:21 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b72 for changeset 4c990aa99bc0 Message-ID: <20090918051824.69A8012443@hg.openjdk.java.net> Changeset: d79f0d601c2b Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/d79f0d601c2b Added tag jdk7-b72 for changeset 4c990aa99bc0 ! .hgtags From john.coomes at sun.com Thu Sep 17 22:20:01 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:20:01 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 52 new changesets Message-ID: <20090918053111.B1FC412448@hg.openjdk.java.net> Changeset: b115cf946852 Author: sherman Date: 2009-08-25 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/b115cf946852 4963968: zlib should be upgraded to current version of zlib Summary: upgrade zlib to the latest ver 1.2.3 Reviewed-by: martin, alanb, ksrini ! make/com/sun/java/pack/Makefile ! make/common/Defs.gmk ! make/java/jli/Makefile ! make/java/zip/FILES_c.gmk ! make/java/zip/Makefile ! make/java/zip/reorder-i586 ! make/java/zip/reorder-sparc ! make/java/zip/reorder-sparcv9 ! make/sun/splashscreen/FILES_c.gmk ! make/sun/splashscreen/Makefile - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h + src/share/native/java/util/zip/zlib-1.2.3/ChangeLog + src/share/native/java/util/zip/zlib-1.2.3/README + src/share/native/java/util/zip/zlib-1.2.3/compress.c + src/share/native/java/util/zip/zlib-1.2.3/crc32.h + src/share/native/java/util/zip/zlib-1.2.3/deflate.c + src/share/native/java/util/zip/zlib-1.2.3/deflate.h + src/share/native/java/util/zip/zlib-1.2.3/gzio.c + src/share/native/java/util/zip/zlib-1.2.3/infback.c + src/share/native/java/util/zip/zlib-1.2.3/inffast.c + src/share/native/java/util/zip/zlib-1.2.3/inffast.h + src/share/native/java/util/zip/zlib-1.2.3/inffixed.h + src/share/native/java/util/zip/zlib-1.2.3/inflate.c + src/share/native/java/util/zip/zlib-1.2.3/inflate.h + src/share/native/java/util/zip/zlib-1.2.3/inftrees.c + src/share/native/java/util/zip/zlib-1.2.3/inftrees.h + src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java + src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff + src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff + src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff + src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff + src/share/native/java/util/zip/zlib-1.2.3/trees.c + src/share/native/java/util/zip/zlib-1.2.3/trees.h + src/share/native/java/util/zip/zlib-1.2.3/uncompr.c + src/share/native/java/util/zip/zlib-1.2.3/zadler32.c + src/share/native/java/util/zip/zlib-1.2.3/zconf.h + src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c + src/share/native/java/util/zip/zlib-1.2.3/zlib.h + src/share/native/java/util/zip/zlib-1.2.3/zutil.c + src/share/native/java/util/zip/zlib-1.2.3/zutil.h Changeset: 196c7bb551e7 Author: darcy Date: 2009-08-25 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/196c7bb551e7 6875861: javadoc build warning on java.util.Properites from unconventional @see ordering Reviewed-by: martin ! src/share/classes/java/util/Properties.java Changeset: 2607e571a6d5 Author: weijun Date: 2009-08-26 12:17 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2607e571a6d5 6868864: Kerberos tests fail under windows/cygwin Reviewed-by: wetmore ! test/sun/security/krb5/auto/basic.sh Changeset: 69396f593772 Author: dl Date: 2009-08-25 19:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/69396f593772 6871697: LinkedBlockingQueue Iterator/remove/poll race Summary: More checks for node.next == node Reviewed-by: martin, dholmes, chegar ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java Changeset: aeaf7b138d90 Author: dl Date: 2009-08-25 19:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/aeaf7b138d90 6868712: Improve concurrent queue tests Summary: Fix all known flaky tests, plus minor maintenance Reviewed-by: martin, chegar ! test/java/util/Collection/BiggernYours.java ! test/java/util/Collection/IteratorAtEnd.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collections/RacingCollections.java ! test/java/util/PriorityQueue/RemoveContains.java ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/Interrupt.java + test/java/util/concurrent/BlockingQueue/LastElement.java ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/OfferDrainToLoops.java ! test/java/util/concurrent/BlockingQueue/PollMemoryLeak.java ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java ! test/java/util/concurrent/ConcurrentQueues/ConcurrentQueueLoops.java ! test/java/util/concurrent/ConcurrentQueues/GCRetention.java ! test/java/util/concurrent/ConcurrentQueues/IteratorWeakConsistency.java + test/java/util/concurrent/ConcurrentQueues/OfferRemoveLoops.java ! test/java/util/concurrent/ConcurrentQueues/RemovePollRace.java - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: 25371bf31658 Author: darcy Date: 2009-08-27 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/25371bf31658 6876628: @throw instead of @throws in two ParagraphView classes Reviewed-by: peterz ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/html/ParagraphView.java Changeset: 5342b0cdbf95 Author: xlu Date: 2009-08-27 18:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5342b0cdbf95 6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces incorrect result Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java ! test/java/math/BigDecimal/DivideTests.java Changeset: 4a5f2147f953 Author: darcy Date: 2009-08-28 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4a5f2147f953 6877122: Many javadoc warnings from java.awt.Window, other awt classes Reviewed-by: anthony ! src/share/classes/java/awt/Cursor.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/dnd/DragSourceContext.java Changeset: e0f79982edd2 Author: darcy Date: 2009-08-28 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e0f79982edd2 6261502: (reflect) Add the functionality to screen out the "inappropriate" modifier bits Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java Changeset: 225aa5ee10da Author: tbell Date: 2009-08-28 16:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/225aa5ee10da Merge ! src/share/classes/javax/swing/text/ParagraphView.java - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: db5d6b4cbc11 Author: martin Date: 2009-08-31 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/db5d6b4cbc11 6860431: Character.isSurrogate(char ch) Summary: Add new method Character.isSurrogate(char ch) Reviewed-by: sherman, darcy, okutsu ! src/share/classes/java/lang/Character.java ! src/share/classes/sun/io/CharToByteDBCS_ASCII.java ! src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java ! src/share/classes/sun/nio/cs/ISO_8859_1.java ! src/share/classes/sun/nio/cs/SingleByte.java ! src/share/classes/sun/nio/cs/SingleByteEncoder.java ! src/share/classes/sun/nio/cs/Surrogate.java ! src/share/classes/sun/nio/cs/US_ASCII.java ! src/share/classes/sun/nio/cs/UTF_32Coder.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/UnicodeDecoder.java ! src/share/classes/sun/nio/cs/UnicodeEncoder.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/DoubleByteEncoder.java ! src/share/classes/sun/nio/cs/ext/EUC_JP.java ! src/share/classes/sun/nio/cs/ext/EUC_JP_LINUX.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! src/share/classes/sun/nio/cs/ext/GB18030.java ! src/share/classes/sun/nio/cs/ext/ISCII91.java ! src/share/classes/sun/nio/cs/ext/ISO2022.java ! src/share/classes/sun/nio/cs/ext/ISO2022_JP.java ! src/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java Changeset: ed0863629d28 Author: tbell Date: 2009-09-03 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ed0863629d28 Merge - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: ee5300e1835a Author: weijun Date: 2009-09-04 14:58 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ee5300e1835a 6876328: different names for the same digest algorithms breaks jarsigner Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java + test/sun/security/tools/jarsigner/nameclash.sh Changeset: 98ad1322051e Author: weijun Date: 2009-09-04 14:59 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/98ad1322051e 6871847: AlgorithmId.get("SHA256withECDSA") not available Reviewed-by: vinnie ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/x509/AlgorithmId/SHA256withECDSA.java Changeset: c34f92a47245 Author: darcy Date: 2009-09-04 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/c34f92a47245 6873951: test/java/lang/reflect/Generics/Probe.java fails. Reviewed-by: alanb ! test/java/lang/reflect/Generics/Probe.java Changeset: 704296144175 Author: martin Date: 2009-09-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/704296144175 6879368: Remove stray quote in Character javadoc Summary: Remove stray quote in Character.valueOf javadoc, using Ulf's \u005CuXXXX technique Reviewed-by: darcy ! src/share/classes/java/lang/Character.java Changeset: 658a4255c797 Author: tbell Date: 2009-09-04 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/658a4255c797 Merge Changeset: 3f87b755b1c8 Author: alanb Date: 2009-09-04 18:15 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3f87b755b1c8 6873621: (file) FileStore.supportsFileAttributeView(Class type) returns wrong result Reviewed-by: andrew ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/SolarisFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: 05ea733a7ae2 Author: alanb Date: 2009-09-04 18:17 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/05ea733a7ae2 6868627: (spec) Files.walkFileTree doesn't make it clear that uncaught errors and exceptions are propagated Reviewed-by: sherman ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java Changeset: 87a2ef2439bc Author: alanb Date: 2009-09-04 22:22 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/87a2ef2439bc 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException Reviewed-by: tbell, ohair, dcubed, andrew ! src/share/transport/socket/socketTransport.c ! test/com/sun/jdi/BadHandshakeTest.java Changeset: 7afdf9d0bc2c Author: alanb Date: 2009-09-05 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7afdf9d0bc2c Merge Changeset: abb69e8b1774 Author: tbell Date: 2009-09-06 23:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/abb69e8b1774 Merge Changeset: 559fb14d0ae9 Author: anthony Date: 2009-08-27 16:42 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/559fb14d0ae9 6780496: Javaw process taking up 80-90 percent of CPU time! Summary: The transparency effects get enabled on showing, and disabled on hiding a window Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: 7599cca4fe5e Author: dcherepanov Date: 2009-08-27 17:04 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7599cca4fe5e 6852051: Getting Null Pointer Exception when displaying message for TrayIcon on Opensolaris Reviewed-by: anthony ! src/share/classes/java/awt/Component.java Changeset: 911a82b4901f Author: dcherepanov Date: 2009-08-27 17:06 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/911a82b4901f 6854898: Frame is located at the negative coordinates instead of origin for Solaris 10 CDE Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XErrorHandler.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: d5ac8fb96d13 Author: anthony Date: 2009-08-28 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d5ac8fb96d13 6689468: test/closed/java/awt/Component/VisibleHwInLwContTest/VisibleHwInLwContTest.html fails Summary: The addNotify() checks whether the component is actually hidden, and hides the peer appropriately if needed Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java Changeset: d755ace580b2 Author: yan Date: 2009-09-04 14:50 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d755ace580b2 6871299: Shift+Tab no longer generates a KEY_TYPED event; used to with JRE 1.5 Summary: Add XK_ISO_Left_Tab -> VK_TAB rule Reviewed-by: dcherepanov ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: 5a584fbcc712 Author: yan Date: 2009-09-09 00:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5a584fbcc712 Merge Changeset: a48c15bcf64f Author: rupashka Date: 2009-08-14 13:18 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/a48c15bcf64f 6824600: OOM occurs when setLookAndFeel() is executed in Windows L&F(XP style) Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/DesktopProperty.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalFontDesktopProperty.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java + test/com/sun/java/swing/plaf/windows/Test6824600.java Changeset: fa334ff12794 Author: alexp Date: 2009-08-19 17:24 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/fa334ff12794 6872492: JLayer sources contain wrong header Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/plaf/LayerUI.java Changeset: 3e36c9abb569 Author: yan Date: 2009-08-20 23:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3e36c9abb569 Merge - test/java/util/concurrent/ConcurrentLinkedQueue/ConcurrentQueueLoops.java - test/java/util/concurrent/ConcurrentLinkedQueue/LoopHelpers.java Changeset: e8d93257cf7e Author: rupashka Date: 2009-08-21 16:59 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e8d93257cf7e 6579827: vista : JSlider on JColorchooser is not properly render or can't be seen completely. Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java + test/javax/swing/JSlider/6579827/bug6579827.java Changeset: d07bd8fa89e4 Author: rupashka Date: 2009-08-24 18:21 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d07bd8fa89e4 6849266: closed/javax/swing/JFileChooser/6484091/bug6484091.java fails on solaris 10 sparc Reviewed-by: peterz + test/javax/swing/JFileChooser/6484091/bug6484091.java Changeset: 799439873bf9 Author: alexp Date: 2009-08-24 19:22 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/799439873bf9 6824395: Several Swing core components prevent using them in wrapper classes Reviewed-by: peterz ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JLayer/6824395/bug6824395.java ! test/javax/swing/JLayer/SerializationTest/SerializationTest.java Changeset: 4914723317b9 Author: peytoia Date: 2009-08-31 12:55 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4914723317b9 6851214: (tz) New Jordan rule creates a failure for SimpleTimeZone parsing post tzdata2009h Reviewed-by: okutsu ! src/share/classes/java/util/SimpleTimeZone.java + test/java/util/TimeZone/ListTimeZones.java Changeset: 7aa6cb832991 Author: peytoia Date: 2009-08-31 14:50 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7aa6cb832991 6872467: (tz) Support tzdata2009l Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/factory ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/pacificnew ! make/sun/javazic/tzdata/solar87 ! make/sun/javazic/tzdata/solar88 ! make/sun/javazic/tzdata/solar89 ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/systemv ! make/sun/javazic/tzdata/zone.tab Changeset: 92b6482e7719 Author: peytoia Date: 2009-08-31 14:53 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/92b6482e7719 6456628: (tz) Default timezone is incorrectly set occasionally on Linux Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c Changeset: f7d606ca25a9 Author: peterz Date: 2009-08-31 13:46 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f7d606ca25a9 6802944: Nimbus initialization is too slow Reviewed-by: jasper ! make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/DerivedColor.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java Changeset: 7e7153da24ef Author: peterz Date: 2009-08-31 13:56 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7e7153da24ef 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README ! make/common/Sanity.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/javax/swing/plaf/Makefile - make/javax/swing/plaf/nimbus/Makefile ! make/tools/Makefile + make/tools/generate_nimbus/Makefile + make/tools/src/build/tools/generatenimbus/Generator.java + make/tools/src/build/tools/generatenimbus/ObjectFactory.java + make/tools/src/build/tools/generatenimbus/Paint.java + make/tools/src/build/tools/generatenimbus/PainterGenerator.java + make/tools/src/build/tools/generatenimbus/Shape.java + make/tools/src/build/tools/generatenimbus/SynthModel.java + make/tools/src/build/tools/generatenimbus/UIDefault.java + make/tools/src/build/tools/generatenimbus/UIStyle.java + make/tools/src/build/tools/generatenimbus/Utils.java - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: e7d311b4ae94 Author: alexp Date: 2009-08-31 18:39 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e7d311b4ae94 6872503: JLayer event handling should be rewritten Reviewed-by: art ! src/share/classes/javax/swing/JLayer.java + test/javax/swing/JLayer/6872503/bug6872503.java Changeset: 9d8f551780d5 Author: peytoia Date: 2009-09-01 15:39 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/9d8f551780d5 6830423: Unified Ext B character not displayed with Dialog font Reviewed-by: okutsu ! src/windows/classes/sun/awt/windows/fontconfig.properties Changeset: 37c33432e98a Author: peytoia Date: 2009-09-01 15:42 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/37c33432e98a 6838887: (tz) Add UTC and Yerevan to tzmappings Reviewed-by: okutsu ! src/windows/lib/tzmappings Changeset: 5780cff2763c Author: peytoia Date: 2009-09-01 16:15 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5780cff2763c 6856390: RFE : sequence.allfonts.UTF-8.ja for Windows fontconfig.properties Reviewed-by: okutsu ! src/windows/classes/sun/awt/windows/fontconfig.properties Changeset: 4f819e2e0bfc Author: peterz Date: 2009-09-01 15:34 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4f819e2e0bfc 6387579: Usage of package-private class as parameter of a method (javax.swing.tree.DefaultTreeSelectionModel) Reviewed-by: rupashka ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java Changeset: 935814bd43a6 Author: alexp Date: 2009-09-01 18:51 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/935814bd43a6 6875153: JLayer.isOptimizedDrawingEnabled() throws NPE for null glass pane set Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/plaf/LayerUI.java + test/javax/swing/JLayer/6875153/bug6875153.java Changeset: 281fbd82a971 Author: alexp Date: 2009-09-02 17:47 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/281fbd82a971 6797139: JButton title is truncating for some strings irrespective of preferred size. Reviewed-by: peterz ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java ! src/share/classes/sun/swing/MenuItemLayoutHelper.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/SwingUtilities/6797139/bug6797139.java Changeset: ff468ef27959 Author: gsm Date: 2009-09-07 12:27 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ff468ef27959 6699856: Creating text in a JTextPane using Chinese text causes undesired behavior Reviewed-by: peterz ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/text/JTextComponent.java Changeset: 01c46cb72eb7 Author: rupashka Date: 2009-09-07 15:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/01c46cb72eb7 6589634: Unable to view focus on "Up one level", "create new folder" etc. of JFileChooser Dialog Reviewed-by: peterz, loneid ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java Changeset: d73a741a7ea1 Author: malenkov Date: 2009-09-08 14:08 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d73a741a7ea1 6868185: 2 JCK api/java_beans/Introspector/ tests fails starting from jdk7 b66 Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/BeanInfoFinder.java Changeset: e289c06b6d36 Author: yan Date: 2009-09-09 00:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/e289c06b6d36 Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: 460639b036f3 Author: yan Date: 2009-09-15 23:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/460639b036f3 Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java Changeset: f09a2bfba691 Author: xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f09a2bfba691 Added tag jdk7-b72 for changeset 460639b036f3 ! .hgtags From john.coomes at sun.com Thu Sep 17 22:38:16 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 18 Sep 2009 05:38:16 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 23 new changesets Message-ID: <20090918053855.C678D1244D@hg.openjdk.java.net> Changeset: 40aca381dcaf Author: darcy Date: 2009-08-25 16:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/40aca381dcaf 6872011: Update printing processor to support JSR 308 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java Changeset: 25f15fdd168a Author: darcy Date: 2009-08-26 19:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/25f15fdd168a 6548708: Annotation processing should free service loader if there are no processors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: 8109aa93b212 Author: mcimadamore Date: 2009-08-27 13:40 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8109aa93b212 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond') Summary: diamond operator implementation (simple approach) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/generics/diamond/neg/Neg01.java + test/tools/javac/generics/diamond/neg/Neg01.out + test/tools/javac/generics/diamond/neg/Neg02.java + test/tools/javac/generics/diamond/neg/Neg02.out + test/tools/javac/generics/diamond/neg/Neg03.java + test/tools/javac/generics/diamond/neg/Neg03.out + test/tools/javac/generics/diamond/neg/Neg04.java + test/tools/javac/generics/diamond/neg/Neg04.out + test/tools/javac/generics/diamond/neg/Neg05.java + test/tools/javac/generics/diamond/neg/Neg05.out + test/tools/javac/generics/diamond/pos/Pos01.java + test/tools/javac/generics/diamond/pos/Pos02.java + test/tools/javac/generics/diamond/pos/Pos03.java + test/tools/javac/generics/diamond/pos/Pos04.java Changeset: ed31953ca025 Author: jjg Date: 2009-08-27 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ed31953ca025 6875336: some tests should use /nodynamiccopyright/ Reviewed-by: darcy ! test/tools/javac/6521805/T6521805a.java ! test/tools/javac/6521805/T6521805a_1.out ! test/tools/javac/6521805/T6521805a_2.out ! test/tools/javac/6521805/T6521805d.java ! test/tools/javac/6521805/T6521805d.out ! test/tools/javac/6717241/T6717241a.java ! test/tools/javac/6717241/T6717241a.out ! test/tools/javac/6717241/T6717241b.java ! test/tools/javac/6717241/T6717241b.out ! test/tools/javac/6734819/T6734819c.java ! test/tools/javac/6734819/T6734819c.out ! test/tools/javac/6758789/T6758789a.java ! test/tools/javac/6758789/T6758789a.out ! test/tools/javac/6758789/T6758789b.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/6840059/T6840059.java ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/Diagnostics/6722234/T6722234a.java ! test/tools/javac/Diagnostics/6722234/T6722234a_1.out ! test/tools/javac/Diagnostics/6722234/T6722234a_2.out ! test/tools/javac/Diagnostics/6722234/T6722234b.java ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6722234/T6722234c.java ! test/tools/javac/Diagnostics/6722234/T6722234c.out ! test/tools/javac/Diagnostics/6722234/T6722234d.java ! test/tools/javac/Diagnostics/6722234/T6722234d_1.out ! test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/Diagnostics/6799605/T6799605.java ! test/tools/javac/Diagnostics/6799605/T6799605.out ! test/tools/javac/Diagnostics/6860795/T6860795.java ! test/tools/javac/Diagnostics/6860795/T6860795.out ! test/tools/javac/Diagnostics/6862608/T6862608a.java ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/Diagnostics/6862608/T6862608b.java ! test/tools/javac/Diagnostics/6862608/T6862608b.out ! test/tools/javac/Diagnostics/6864382/T6864382.java ! test/tools/javac/Diagnostics/6864382/T6864382.out ! test/tools/javac/OverrideChecks/6199153/T6199153.java ! test/tools/javac/OverrideChecks/6199153/T6199153.out ! test/tools/javac/OverrideChecks/6400189/T6400189a.java ! test/tools/javac/OverrideChecks/6400189/T6400189a.out ! test/tools/javac/OverrideChecks/6400189/T6400189b.java ! test/tools/javac/OverrideChecks/6400189/T6400189b.out ! test/tools/javac/cast/6467183/T6467183a.java ! test/tools/javac/cast/6467183/T6467183a.out ! test/tools/javac/cast/6557182/T6557182.java ! test/tools/javac/cast/6557182/T6557182.out ! test/tools/javac/cast/6665356/T6665356.java ! test/tools/javac/cast/6665356/T6665356.out ! test/tools/javac/cast/6795580/T6795580.java ! test/tools/javac/cast/6795580/T6795580.out ! test/tools/javac/generics/5009937/T5009937.java ! test/tools/javac/generics/5009937/T5009937.out ! test/tools/javac/generics/6182950/T6182950a.java ! test/tools/javac/generics/6182950/T6182950a.out ! test/tools/javac/generics/6182950/T6182950b.java ! test/tools/javac/generics/6182950/T6182950b.out ! test/tools/javac/generics/6677785/T6677785.java ! test/tools/javac/generics/6677785/T6677785.out ! test/tools/javac/generics/6711619/T6711619a.java ! test/tools/javac/generics/6711619/T6711619a.out ! test/tools/javac/generics/6711619/T6711619b.java ! test/tools/javac/generics/6711619/T6711619b.out ! test/tools/javac/generics/6723444/T6723444.java ! test/tools/javac/generics/6723444/T6723444.out ! test/tools/javac/generics/inference/6315770/T6315770.java ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6611449/T6611449.java ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712a.java ! test/tools/javac/generics/inference/6638712/T6638712a.out ! test/tools/javac/generics/inference/6638712/T6638712b.java ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712c.java ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.java ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6638712/T6638712e.java ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/6718364/T6718364.java ! test/tools/javac/generics/inference/6718364/T6718364.out ! test/tools/javac/generics/rare/6665356/T6665356.java ! test/tools/javac/generics/rare/6665356/T6665356.out ! test/tools/javac/generics/typevars/6569404/T6569404b.java ! test/tools/javac/generics/typevars/6569404/T6569404b.out ! test/tools/javac/generics/typevars/6680106/T6680106.java ! test/tools/javac/generics/typevars/6680106/T6680106.out ! test/tools/javac/generics/typevars/6804733/T6804733.java ! test/tools/javac/generics/typevars/6804733/T6804733.out ! test/tools/javac/typeAnnotations/failures/AnnotationVersion.java ! test/tools/javac/typeAnnotations/failures/AnnotationVersion.out ! test/tools/javac/typeAnnotations/failures/IncompleteArray.java ! test/tools/javac/typeAnnotations/failures/IncompleteArray.out ! test/tools/javac/typeAnnotations/failures/IncompleteVararg.java ! test/tools/javac/typeAnnotations/failures/IncompleteVararg.out ! test/tools/javac/typeAnnotations/failures/IndexArray.java ! test/tools/javac/typeAnnotations/failures/IndexArray.out ! test/tools/javac/typeAnnotations/failures/LintCast.java ! test/tools/javac/typeAnnotations/failures/LintCast.out ! test/tools/javac/typeAnnotations/failures/Scopes.java ! test/tools/javac/typeAnnotations/failures/Scopes.out ! test/tools/javac/typeAnnotations/failures/StaticFields.java ! test/tools/javac/typeAnnotations/failures/StaticFields.out ! test/tools/javac/typeAnnotations/failures/StaticMethods.java ! test/tools/javac/typeAnnotations/failures/StaticMethods.out ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/target/Constructor.java ! test/tools/javac/typeAnnotations/failures/target/Constructor.out ! test/tools/javac/typeAnnotations/failures/target/IncompleteArray.java ! test/tools/javac/typeAnnotations/failures/target/IncompleteArray.out ! test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.java ! test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.out ! test/tools/javac/typeAnnotations/failures/target/NotTypeUse.java ! test/tools/javac/typeAnnotations/failures/target/NotTypeUse.out ! test/tools/javac/typeAnnotations/failures/target/VoidMethod.java ! test/tools/javac/typeAnnotations/failures/target/VoidMethod.out ! test/tools/javac/varargs/6806876/T6806876.java ! test/tools/javac/varargs/6806876/T6806876.out ! test/tools/javac/warnings/6747671/T6747671.java ! test/tools/javac/warnings/6747671/T6747671.out Changeset: 74760fd5197f Author: jjg Date: 2009-08-27 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/74760fd5197f 6843707: bad tests generate files in the test/ directory 6876699: generated files in repository Reviewed-by: darcy - test/tools/javac/meth/InvokeMH_BAD68.java - test/tools/javac/meth/InvokeMH_BAD72.java ! test/tools/javac/meth/MakeNegTests.sh ! test/tools/javac/quid/MakeNegTests.sh - test/tools/javac/quid/QuotedIdent_BAD61.java - test/tools/javac/quid/QuotedIdent_BAD62.java - test/tools/javac/quid/QuotedIdent_BAD63.java Changeset: 2c20f17c429c Author: jjg Date: 2009-08-27 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2c20f17c429c 6876753: javap tests fail on Windows Reviewed-by: darcy ! test/tools/javap/T4975569.java ! test/tools/javap/T6729471.java ! test/tools/javap/pathsep.sh ! test/tools/javap/stackmap/T6271292.sh Changeset: f29068bfeaed Author: jjg Date: 2009-08-27 17:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/f29068bfeaed 6876755: apt tests fail on Windows Reviewed-by: darcy ! test/tools/apt/Basics/apt.sh ! test/tools/apt/Basics/print.sh ! test/tools/apt/Compile/compile.sh Changeset: 477c5bf1149c Author: jjg Date: 2009-08-27 18:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/477c5bf1149c 6876765: javah tests fail on Windows Reviewed-by: darcy ! test/tools/javah/6257087/foo.sh ! test/tools/javah/ConstMacroTest.sh ! test/tools/javah/MissingParamClassTest.sh ! test/tools/javah/ReadOldClass.sh Changeset: 0ba956343648 Author: jjg Date: 2009-08-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/0ba956343648 6876782: two javadoc tests fail on Windows Reviewed-by: darcy ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java Changeset: f0c9fc46990b Author: jjg Date: 2009-08-28 14:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/f0c9fc46990b 6877188: some javac shell tests do not work on Windows Reviewed-by: darcy ! test/tools/javac/4846262/Test.sh ! test/tools/javac/6302184/T6302184.sh ! test/tools/javac/ClassPathTest/ClassPathTest.sh ! test/tools/javac/ExtDirs/ExtDirs.sh ! test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh ! test/tools/javac/javazip/Test.sh ! test/tools/javac/newlines/Newlines.sh ! test/tools/javac/unicode/SupplementaryJavaID6.sh Changeset: ce5be4c09f2a Author: tbell Date: 2009-08-28 16:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ce5be4c09f2a Merge - test/tools/javac/meth/InvokeMH_BAD68.java - test/tools/javac/meth/InvokeMH_BAD72.java - test/tools/javac/quid/QuotedIdent_BAD61.java - test/tools/javac/quid/QuotedIdent_BAD62.java - test/tools/javac/quid/QuotedIdent_BAD63.java Changeset: d5e76d422509 Author: jjg Date: 2009-08-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d5e76d422509 6877229: more javac tests fail on Windows Reviewed-by: darcy ! test/tools/javac/6589361/T6589361.java ! test/tools/javac/MissingInclude.sh ! test/tools/javac/T5090006/compiler.sh ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/Sibling.java ! test/tools/javac/code/ArrayClone.java ! test/tools/javac/constDebug/ConstDebug.sh ! test/tools/javac/fatalErrors/NoJavaLang.sh ! test/tools/javac/innerClassFile/Driver.sh ! test/tools/javac/quid/QuotedIdent.java ! test/tools/javac/quid/QuotedIdent2.java ! test/tools/javac/stackmap/T4955930.sh Changeset: 4fa458c945ac Author: jjg Date: 2009-08-31 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4fa458c945ac 6877744: delete extraneous file Reviewed-by: darcy - test/tools/javac/innerClassFile/Driver.java Changeset: 45301370bc5a Author: jjg Date: 2009-08-31 18:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/45301370bc5a 6877751: test/tools/javac/6627362/T6627362.java fails Reviewed-by: darcy ! test/tools/javac/6627362/T6627362.java Changeset: 5a72ba18c471 Author: jjg Date: 2009-08-31 19:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/5a72ba18c471 6877759: test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java leaves open file Reviewed-by: darcy ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java Changeset: dda7e13f09fb Author: mcimadamore Date: 2009-09-01 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/dda7e13f09fb 6650759: Inference of formal type parameter (unused in formal parameters) is not performed Summary: propagate inference constraints from 15.12.2.7 to 15.12.2.8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/generics/inference/6302954/T6476073.java ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712e.out + test/tools/javac/generics/inference/6650759/T6650759a.java + test/tools/javac/generics/inference/6650759/T6650759b.java + test/tools/javac/generics/inference/6650759/T6650759c.java + test/tools/javac/generics/inference/6650759/T6650759d.java + test/tools/javac/generics/inference/6650759/T6650759e.java + test/tools/javac/generics/inference/6650759/T6650759f.java + test/tools/javac/generics/inference/6650759/T6650759g.java + test/tools/javac/generics/inference/6650759/T6650759h.java + test/tools/javac/generics/inference/6650759/T6650759i.java + test/tools/javac/generics/inference/6650759/T6650759j.java + test/tools/javac/generics/inference/6650759/T6650759k.java + test/tools/javac/generics/inference/6650759/T6650759l.java + test/tools/javac/generics/inference/6650759/T6650759m.java + test/tools/javac/generics/inference/6650759/T6650759m.out Changeset: 40a1327a5283 Author: jjg Date: 2009-09-01 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/40a1327a5283 6877763: update langtools/test/Makefile for JPRT Reviewed-by: ohair ! test/Makefile Changeset: 8d999cb7ec09 Author: jjg Date: 2009-09-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8d999cb7ec09 6874249: Check has duplicate local variable and field for "source" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: 90c28923e449 Author: tbell Date: 2009-09-03 18:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/90c28923e449 Merge - test/tools/javac/innerClassFile/Driver.java - test/tools/javac/meth/InvokeMH_BAD68.java - test/tools/javac/meth/InvokeMH_BAD72.java - test/tools/javac/quid/QuotedIdent_BAD61.java - test/tools/javac/quid/QuotedIdent_BAD62.java - test/tools/javac/quid/QuotedIdent_BAD63.java Changeset: 35e29f51a7c3 Author: jjg Date: 2009-09-08 11:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/35e29f51a7c3 6419701: DefaultFileManager clean up: URI.create 6483788: DefaultFileManager.ZipFileObject.toUri() fails to escape space characters 6501502: JSR 199: FileObject.toUri should return file:///c:/ or file:/c:/ not file://c:/ 6877206: JavaFileObject.toUri returns bogus URI (win) 6877223: tests @ignored because of issues with File.toURI on Windows Reviewed-by: mcimadamore, alanb ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! test/tools/javac/Diagnostics/6769027/tester.properties ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/Sibling.java + test/tools/javac/api/T6483788.java + test/tools/javac/api/T6501502.java + test/tools/javac/api/T6877206.java Changeset: dd98acd9f717 Author: jjg Date: 2009-09-08 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/dd98acd9f717 6879346: files have Windows newlines Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testCRLineSeparator/pkg/MyClass.java ! test/com/sun/javadoc/testHref/package-list ! test/com/sun/javadoc/testLinkOption/testNewLineInLink/package.html ! test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testRelativeLinks/pkg/package.html ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testWarnings/pkg/package.html ! test/tools/javah/SubClassConsts.win Changeset: 261c54b2312e Author: jjg Date: 2009-09-08 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/261c54b2312e 6879371: javap does not close internal default file manager Reviewed-by: darcy ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/T6879371.java Changeset: bfad32768345 Author: xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/bfad32768345 Added tag jdk7-b72 for changeset 261c54b2312e ! .hgtags From jean-christophe.collet at sun.com Fri Sep 18 02:04:02 2009 From: jean-christophe.collet at sun.com (jean-christophe.collet at sun.com) Date: Fri, 18 Sep 2009 09:04:02 +0000 Subject: hg: jdk7/tl/jdk: 6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to localhost Message-ID: <20090918090436.38E6612454@hg.openjdk.java.net> Changeset: ee68feef41d2 Author: jccollet Date: 2009-09-18 10:51 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee68feef41d2 6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to localhost Summary: Move default nonProxyHosts from hardcoded to property default value Reviewed-by: chegar ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/lib/net.properties + test/java/net/ProxySelector/B6737819.java From ahughes at redhat.com Fri Sep 18 04:24:01 2009 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 18 Sep 2009 11:24:01 +0000 Subject: hg: jdk7/tl/jdk: 6882745: Add DISABLE_INTREE_EC option to make new EC provider optional. Message-ID: <20090918112448.4509712468@hg.openjdk.java.net> Changeset: 39c15c0a71f7 Author: andrew Date: 2009-09-10 19:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/39c15c0a71f7 6882745: Add DISABLE_INTREE_EC option to make new EC provider optional. Summary: Don't build the ec subdirectory when DISABLE_INTREE_EC is defined. Reviewed-by: vinnie ! make/sun/security/Makefile From tim.bell at sun.com Fri Sep 18 09:27:14 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:27:14 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b72 for changeset 0d7e03b426df Message-ID: <20090918162715.46E7112494@hg.openjdk.java.net> Changeset: 4c4fe09fb670 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4c4fe09fb670 Added tag jdk7-b72 for changeset 0d7e03b426df ! .hgtags From tim.bell at sun.com Fri Sep 18 09:27:45 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:27:45 +0000 Subject: hg: jdk7/tl/corba: Added tag jdk7-b72 for changeset c793a3120926 Message-ID: <20090918162747.6A4FD12499@hg.openjdk.java.net> Changeset: 12991b453239 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/12991b453239 Added tag jdk7-b72 for changeset c793a3120926 ! .hgtags From tim.bell at sun.com Fri Sep 18 09:29:15 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:29:15 +0000 Subject: hg: jdk7/tl/hotspot: Added tag jdk7-b72 for changeset a94714c55065 Message-ID: <20090918162923.A45D61249E@hg.openjdk.java.net> Changeset: 1e5f0e56d242 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1e5f0e56d242 Added tag jdk7-b72 for changeset a94714c55065 ! .hgtags From tim.bell at sun.com Fri Sep 18 09:32:57 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:32:57 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b72 for changeset 37c805b6156f Message-ID: <20090918163259.BDEBA124A3@hg.openjdk.java.net> Changeset: 93dfa6e0fe76 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/93dfa6e0fe76 Added tag jdk7-b72 for changeset 37c805b6156f ! .hgtags From tim.bell at sun.com Fri Sep 18 09:33:32 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:33:32 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b72 for changeset 4c990aa99bc0 Message-ID: <20090918163335.CF608124A8@hg.openjdk.java.net> Changeset: d79f0d601c2b Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d79f0d601c2b Added tag jdk7-b72 for changeset 4c990aa99bc0 ! .hgtags From tim.bell at sun.com Fri Sep 18 09:34:32 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:34:32 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090918163545.6099B124AD@hg.openjdk.java.net> Changeset: f09a2bfba691 Author: xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f09a2bfba691 Added tag jdk7-b72 for changeset 460639b036f3 ! .hgtags Changeset: f119e21c0ca7 Author: tbell Date: 2009-09-18 08:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f119e21c0ca7 Merge From tim.bell at sun.com Fri Sep 18 09:38:22 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Fri, 18 Sep 2009 16:38:22 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20090918163829.C000A124B2@hg.openjdk.java.net> Changeset: bfad32768345 Author: xdono Date: 2009-09-17 13:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bfad32768345 Added tag jdk7-b72 for changeset 261c54b2312e ! .hgtags Changeset: 5dd400fd62d9 Author: tbell Date: 2009-09-18 08:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5dd400fd62d9 Merge From christopher.hegarty at sun.com Fri Sep 18 14:21:56 2009 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Fri, 18 Sep 2009 21:21:56 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20090918212320.2ACA81252D@hg.openjdk.java.net> Changeset: c9cbd2a09fd4 Author: chegar Date: 2009-09-18 16:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9cbd2a09fd4 6882609: Move default InMemoryCookieStore to java.net Summary: remove static dependency on sun.net.www.protocol.http Reviewed-by: alanb, jccollet ! make/sun/net/FILES_java.gmk ! src/share/classes/java/net/CookieManager.java + src/share/classes/java/net/InMemoryCookieStore.java - src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java Changeset: 9cd7133ea287 Author: chegar Date: 2009-09-18 22:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9cd7133ea287 6882594: Remove static dependancy on NTLM authentication Reviewed-by: alanb, weijun ! make/sun/net/FILES_java.gmk ! src/share/classes/sun/net/www/protocol/http/AuthCache.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java + src/share/classes/sun/net/www/protocol/http/AuthScheme.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java Changeset: 45a343706f73 Author: chegar Date: 2009-09-18 22:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/45a343706f73 Merge From mandy.chung at sun.com Fri Sep 18 18:51:57 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Sat, 19 Sep 2009 01:51:57 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090919015248.8C8E8125E7@hg.openjdk.java.net> Changeset: d3281fa8e46c Author: mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author: mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b4e73ca6fd7 Merge From daniel.daugherty at sun.com Mon Sep 21 11:16:02 2009 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Mon, 21 Sep 2009 18:16:02 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6419370: 4/4 new jmethodID code has tiny holes in synchronization Message-ID: <20090921181610.3543512691@hg.openjdk.java.net> Changeset: 74a5db69c1fe Author: dcubed Date: 2009-09-21 09:30 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/74a5db69c1fe 6419370: 4/4 new jmethodID code has tiny holes in synchronization Summary: Fix races in jmethodID cache and JNI itable index cache. Reviewed-by: ikrylov, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.hpp From Daniel.Daugherty at Sun.COM Mon Sep 21 12:45:21 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Mon, 21 Sep 2009 13:45:21 -0600 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB05867.10501@sun.com> References: <4AB05867.10501@sun.com> Message-ID: <4AB7D7D1.8010904@sun.com> Second Call for any OpenJDK reviewers! I will be closing the review window Tuesday (09.22) evening on this fix. Dan Daniel D. Daugherty wrote: > Greetings, > > I'm looking for a couple of OpenJDK code reviewers for my fix to > the following bug: > > 6876794 4/4 sp07t002 hangs very intermittently > > This one is a classic suspend/resume three-way deadlock caused by > a case of over locking so I figured I would give this one a wider > review. > > Here is the URL for code review round 0 webrev: > > http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ > > I'm targeting this fix for HSX-17-B02 so I'd like to hear back > from at least one reviewer in a week or so... > > Thanks, in advance, for any feedback! > > Dan > > From gnu_andrew at member.fsf.org Mon Sep 21 13:43:36 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 21 Sep 2009 21:43:36 +0100 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB7D7D1.8010904@sun.com> References: <4AB05867.10501@sun.com> <4AB7D7D1.8010904@sun.com> Message-ID: <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> 2009/9/21 Daniel D. Daugherty : > Second Call for any OpenJDK reviewers! > > I will be closing the review window Tuesday (09.22) evening on this fix. > > Dan > > > Daniel D. Daugherty wrote: >> >> Greetings, >> >> I'm looking for a couple of OpenJDK code reviewers for my fix to >> the following bug: >> >> ? 6876794 4/4 sp07t002 hangs very intermittently >> >> This one is a classic suspend/resume three-way deadlock caused by >> a case of over locking so I figured I would give this one a wider >> review. >> >> Here is the URL for code review round 0 webrev: >> >> ? http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ >> >> I'm targeting this fix for HSX-17-B02 so I'd like to hear back >> from at least one reviewer in a week or so... >> >> Thanks, in advance, for any feedback! >> >> Dan >> >> > Hi Dan, First of all, thanks for posting this for public review. It's a shame more people haven't responded, but then I guess fairly intimate HotSpot code like this may scare most people off :) Assuming your analysis of the locking is correct (it sounds that way to me), then this seems like a fairly straightforward patch. From what I can see, most of it is cleanup; the is_any_suspended_with_lock() method that is removed is presumably not called from anywhere (I don't see any call removal in the patch) and replacing is_any_suspended with its single line contents is also straightforward. So I also agree with the patch. Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Daniel.Daugherty at Sun.COM Mon Sep 21 13:56:49 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Mon, 21 Sep 2009 14:56:49 -0600 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> References: <4AB05867.10501@sun.com> <4AB7D7D1.8010904@sun.com> <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> Message-ID: <4AB7E891.1090209@sun.com> Andrew John Hughes wrote: > 2009/9/21 Daniel D. Daugherty : > >> Second Call for any OpenJDK reviewers! >> >> I will be closing the review window Tuesday (09.22) evening on this fix. >> >> Dan >> >> >> Daniel D. Daugherty wrote: >> >>> Greetings, >>> >>> I'm looking for a couple of OpenJDK code reviewers for my fix to >>> the following bug: >>> >>> 6876794 4/4 sp07t002 hangs very intermittently >>> >>> This one is a classic suspend/resume three-way deadlock caused by >>> a case of over locking so I figured I would give this one a wider >>> review. >>> >>> Here is the URL for code review round 0 webrev: >>> >>> http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ >>> >>> I'm targeting this fix for HSX-17-B02 so I'd like to hear back >>> from at least one reviewer in a week or so... >>> >>> Thanks, in advance, for any feedback! >>> >>> Dan >>> >>> >>> > > Hi Dan, > > First of all, thanks for posting this for public review. You're welcome. > It's a shame > more people haven't responded, but then I guess fairly intimate > HotSpot code like this may scare most people off :) > Hopefully, these reviews and the verbose comments will help with that situation. > Assuming your analysis of the locking is correct (it sounds that way > to me), then this seems like a fairly straightforward patch. So far no one has found any holes in the logic :-) But then again it took a few years to find this one :-) > From > what I can see, most of it is cleanup; the > is_any_suspended_with_lock() method that is removed is presumably not > called from anywhere (I don't see any call removal in the patch) The one remaining use of is_any_suspended_with_lock() was line 774 in safepoint.cpp and it was replaced with is_ext_suspended() on new line 788 in safepoint.cpp. > and > replacing is_any_suspended with its single line contents is also > straightforward. > And that was the only use of is_any_suspended(). > So I also agree with the patch. > Thanks for the review. I'll add you to the reviewers list. Dan From gnu_andrew at member.fsf.org Mon Sep 21 14:15:48 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 21 Sep 2009 22:15:48 +0100 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB7E891.1090209@sun.com> References: <4AB05867.10501@sun.com> <4AB7D7D1.8010904@sun.com> <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> <4AB7E891.1090209@sun.com> Message-ID: <17c6771e0909211415mbb115dcq7ecba79223f9cf30@mail.gmail.com> 2009/9/21 Daniel D. Daugherty : > Andrew John Hughes wrote: >> >> 2009/9/21 Daniel D. Daugherty : >> >>> >>> Second Call for any OpenJDK reviewers! >>> >>> I will be closing the review window Tuesday (09.22) evening on this fix. >>> >>> Dan >>> >>> >>> Daniel D. Daugherty wrote: >>> >>>> >>>> Greetings, >>>> >>>> I'm looking for a couple of OpenJDK code reviewers for my fix to >>>> the following bug: >>>> >>>> ?6876794 4/4 sp07t002 hangs very intermittently >>>> >>>> This one is a classic suspend/resume three-way deadlock caused by >>>> a case of over locking so I figured I would give this one a wider >>>> review. >>>> >>>> Here is the URL for code review round 0 webrev: >>>> >>>> ?http://cr.openjdk.java.net/~dcubed/6876794-webrev/0/ >>>> >>>> I'm targeting this fix for HSX-17-B02 so I'd like to hear back >>>> from at least one reviewer in a week or so... >>>> >>>> Thanks, in advance, for any feedback! >>>> >>>> Dan >>>> >>>> >>>> >> >> Hi Dan, >> >> First of all, thanks for posting this for public review. > > You're welcome. > > >> It's a shame >> more people haven't responded, but then I guess fairly intimate >> HotSpot code like this may scare most people off :) >> > > Hopefully, these reviews and the verbose comments will help with > that situation. > > >> Assuming your analysis of the locking is correct (it sounds that way >> to me), then this seems like a fairly straightforward patch. > > So far no one has found any holes in the logic :-) But then again it > took a few years to find this one :-) > Concurrency problems tend to be like that. Code like this can be difficult to get right, and still far too few people are even taught good practice, never mind using it. MutexLocker seems to make things especially interesting, as there is no explicit unlock call, it just happens as a side-effect of the instance leaving scope and the destructor being called. > >> From >> what I can see, most of it is cleanup; the >> is_any_suspended_with_lock() method that is removed is presumably not >> called from anywhere (I don't see any call removal in the patch) > > The one remaining use of is_any_suspended_with_lock() was line 774 > in safepoint.cpp and it was replaced with is_ext_suspended() on > new line 788 in safepoint.cpp. > Ah, I see it now! I missed it in the comment changes. > >> and >> replacing is_any_suspended with its single line contents is also >> straightforward. >> > > And that was the only use of is_any_suspended(). > > >> So I also agree with the patch. >> > > Thanks for the review. I'll add you to the reviewers list. > > Dan > > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Daniel.Daugherty at Sun.COM Mon Sep 21 14:49:05 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Mon, 21 Sep 2009 15:49:05 -0600 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <17c6771e0909211415mbb115dcq7ecba79223f9cf30@mail.gmail.com> References: <4AB05867.10501@sun.com> <4AB7D7D1.8010904@sun.com> <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> <4AB7E891.1090209@sun.com> <17c6771e0909211415mbb115dcq7ecba79223f9cf30@mail.gmail.com> Message-ID: <4AB7F4D1.1010304@sun.com> Andrew John Hughes wrote: > 2009/9/21 Daniel D. Daugherty : > >> Andrew John Hughes wrote: >> >>> Assuming your analysis of the locking is correct (it sounds that way >>> to me), then this seems like a fairly straightforward patch. >>> >> So far no one has found any holes in the logic :-) But then again it >> took a few years to find this one :-) >> >> > > Concurrency problems tend to be like that. Code like this can be > difficult to get right, and still far too few people are even taught > good practice, never mind using it. > > MutexLocker seems to make things especially interesting, as there is > no explicit unlock call, it just happens as a side-effect of the > instance leaving scope and the destructor being called. > I guess I would argue that there is no explicit lock call either. That's the beauty of the helper object pattern. You allocate the helper object for the scope in which you need to hold the lock. No more. No less. No more forgetting to unlock. No more matching of lock and unlock calls. Dan From gnu_andrew at member.fsf.org Mon Sep 21 15:13:37 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 21 Sep 2009 23:13:37 +0100 Subject: code review request for suspend/resume deadlock (6876794) In-Reply-To: <4AB7F4D1.1010304@sun.com> References: <4AB05867.10501@sun.com> <4AB7D7D1.8010904@sun.com> <17c6771e0909211343x7a87f4ccj7de9a58737d91711@mail.gmail.com> <4AB7E891.1090209@sun.com> <17c6771e0909211415mbb115dcq7ecba79223f9cf30@mail.gmail.com> <4AB7F4D1.1010304@sun.com> Message-ID: <17c6771e0909211513t8df95d2m13241ee6a60f6598@mail.gmail.com> 2009/9/21 Daniel D. Daugherty : > > > Andrew John Hughes wrote: >> >> 2009/9/21 Daniel D. Daugherty : >> >>> >>> Andrew John Hughes wrote: >>> >>>> >>>> Assuming your analysis of the locking is correct (it sounds that way >>>> to me), then this seems like a fairly straightforward patch. >>>> >>> >>> So far no one has found any holes in the logic :-) But then again it >>> took a few years to find this one :-) >>> >>> >> >> Concurrency problems tend to be like that. ?Code like this can be >> difficult to get right, and still far too few people are even taught >> good practice, never mind using it. >> >> MutexLocker seems to make things especially interesting, as there is >> no explicit unlock call, it just happens as a side-effect of the >> instance leaving scope and the destructor being called. >> > > I guess I would argue that there is no explicit lock call either. > That's the beauty of the helper object pattern. You allocate the > helper object for the scope in which you need to hold the lock. > No more. No less. No more forgetting to unlock. No more matching > of lock and unlock calls. > > Dan > > Yes, it's good in that respect, half the problem with locking is placing lock/unlock statements at the correct points. It just wasn't that intuitive at first from the patch. After reading through MutexLocker.hpp it made sense. You wouldn't want to use it with two dependent locks at the same scope though, as you'd be relying on destructor ordering to make sure they are unlocked in the correct order. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From vincent.ryan at sun.com Mon Sep 21 15:16:14 2009 From: vincent.ryan at sun.com (vincent.ryan at sun.com) Date: Mon, 21 Sep 2009 22:16:14 +0000 Subject: hg: jdk7/tl/jdk: 6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms Message-ID: <20090921221715.ED322126A6@hg.openjdk.java.net> Changeset: 845fefff00a4 Author: vinnie Date: 2009-09-21 23:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/845fefff00a4 6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms Reviewed-by: wetmore ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/SunEC.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/native/sun/security/ec/ECC_JNI.cpp - src/share/native/sun/security/ec/ec.c + src/share/native/sun/security/ec/impl/ec.c + src/share/native/sun/security/ec/impl/ec.h + src/share/native/sun/security/ec/impl/ec2.h + src/share/native/sun/security/ec/impl/ec2_163.c + src/share/native/sun/security/ec/impl/ec2_193.c + src/share/native/sun/security/ec/impl/ec2_233.c + src/share/native/sun/security/ec/impl/ec2_aff.c + src/share/native/sun/security/ec/impl/ec2_mont.c + src/share/native/sun/security/ec/impl/ec_naf.c + src/share/native/sun/security/ec/impl/ecc_impl.h + src/share/native/sun/security/ec/impl/ecdecode.c + src/share/native/sun/security/ec/impl/ecl-curve.h + src/share/native/sun/security/ec/impl/ecl-exp.h + src/share/native/sun/security/ec/impl/ecl-priv.h + src/share/native/sun/security/ec/impl/ecl.c + src/share/native/sun/security/ec/impl/ecl.h + src/share/native/sun/security/ec/impl/ecl_curve.c + src/share/native/sun/security/ec/impl/ecl_gf.c + src/share/native/sun/security/ec/impl/ecl_mult.c + src/share/native/sun/security/ec/impl/ecp.h + src/share/native/sun/security/ec/impl/ecp_192.c + src/share/native/sun/security/ec/impl/ecp_224.c + src/share/native/sun/security/ec/impl/ecp_256.c + src/share/native/sun/security/ec/impl/ecp_384.c + src/share/native/sun/security/ec/impl/ecp_521.c + src/share/native/sun/security/ec/impl/ecp_aff.c + src/share/native/sun/security/ec/impl/ecp_jac.c + src/share/native/sun/security/ec/impl/ecp_jm.c + src/share/native/sun/security/ec/impl/ecp_mont.c + src/share/native/sun/security/ec/impl/logtab.h + src/share/native/sun/security/ec/impl/mp_gf2m-priv.h + src/share/native/sun/security/ec/impl/mp_gf2m.c + src/share/native/sun/security/ec/impl/mp_gf2m.h + src/share/native/sun/security/ec/impl/mpi-config.h + src/share/native/sun/security/ec/impl/mpi-priv.h + src/share/native/sun/security/ec/impl/mpi.c + src/share/native/sun/security/ec/impl/mpi.h + src/share/native/sun/security/ec/impl/mplogic.c + src/share/native/sun/security/ec/impl/mplogic.h + src/share/native/sun/security/ec/impl/mpmontg.c + src/share/native/sun/security/ec/impl/mpprime.h + src/share/native/sun/security/ec/impl/oid.c + src/share/native/sun/security/ec/impl/secitem.c + src/share/native/sun/security/ec/impl/secoidt.h ! test/sun/security/ec/TestEC.java + test/sun/security/ec/certs/sunlabscerts.pem + test/sun/security/ec/keystore + test/sun/security/ec/truststore ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/sslecc/CipherTest.java From weijun.wang at sun.com Mon Sep 21 19:03:40 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Tue, 22 Sep 2009 02:03:40 +0000 Subject: hg: jdk7/tl/jdk: 6877357: IPv6 address does not work Message-ID: <20090922020417.316C0126D0@hg.openjdk.java.net> Changeset: 81dffe63c913 Author: weijun Date: 2009-09-22 10:01 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81dffe63c913 6877357: IPv6 address does not work Reviewed-by: xuelei, alanb ! src/share/classes/sun/security/krb5/KrbKdcReq.java + test/sun/security/krb5/IPv6.java From joe.darcy at sun.com Mon Sep 21 21:09:19 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 22 Sep 2009 04:09:19 +0000 Subject: hg: jdk7/tl/langtools: 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements Message-ID: <20090922040921.9BEFB126E5@hg.openjdk.java.net> Changeset: 789ee1acf107 Author: darcy Date: 2009-09-21 21:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/789ee1acf107 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/TypeElement.java From christopher.hegarty at sun.com Tue Sep 22 06:51:10 2009 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Tue, 22 Sep 2009 13:51:10 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090922135200.99A751275B@hg.openjdk.java.net> Changeset: 023063a403ed Author: chegar Date: 2009-09-22 14:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/023063a403ed 6882654: Remove dependency on java.util.concurrent from KeepAlive implementaion Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java Changeset: 44ccaa4bb8a0 Author: chegar Date: 2009-09-22 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44ccaa4bb8a0 6882384: Update http protocol handler to use PlatformLogger Reviewed-by: jccollet, alanb ! src/share/classes/sun/net/www/http/HttpCapture.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/share/classes/sun/util/logging/PlatformLogger.java From kevin.walls at sun.com Tue Sep 22 09:17:22 2009 From: kevin.walls at sun.com (kevin.walls at sun.com) Date: Tue, 22 Sep 2009 16:17:22 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090922161810.7485412766@hg.openjdk.java.net> Changeset: b8004f6f4812 Author: kevinw Date: 2009-09-22 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8004f6f4812 6882768: (launcher) test for 6842838 is broken Summary: Testcase correction. Reviewed-by: ksrini ! test/tools/launcher/6842838/Test6842838.sh Changeset: f708138c9aca Author: kevinw Date: 2009-09-22 17:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f708138c9aca Merge From karen.kinnear at sun.com Tue Sep 22 13:13:48 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Tue, 22 Sep 2009 20:13:48 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 4 new changesets Message-ID: <20090922201401.D256B127AA@hg.openjdk.java.net> Changeset: eb058abd0562 Author: ysr Date: 2009-09-15 16:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/eb058abd0562 6861557: G1: assert(top() == bottom() || zfs == Allocated,"Region must be empty, or ...") Summary: Druing heap shrinking, check for emptiness of a region before modifying its ZF status. Reviewed-by: tonyp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp Changeset: d7c9544cc141 Author: apetrusenko Date: 2009-09-18 06:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/d7c9544cc141 Merge Changeset: 723131383de6 Author: acorn Date: 2009-09-18 15:14 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/723131383de6 Merge Changeset: d72ba3205918 Author: acorn Date: 2009-09-21 18:10 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/d72ba3205918 Merge From joe.darcy at sun.com Tue Sep 22 16:11:07 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 22 Sep 2009 23:11:07 +0000 Subject: hg: jdk7/tl/jdk: 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Message-ID: <20090922231202.85783127D6@hg.openjdk.java.net> Changeset: c715b68cdcaf Author: darcy Date: 2009-09-22 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c715b68cdcaf 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java From martinrb at google.com Tue Sep 22 18:40:37 2009 From: martinrb at google.com (martinrb at google.com) Date: Wed, 23 Sep 2009 01:40:37 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090923014109.01775127ED@hg.openjdk.java.net> Changeset: bbb543254c63 Author: martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbb543254c63 4245470: algorithm of java.lang.Byte.hashCode() is not specified Summary: Specify some hashCode methods are equivalent to intValue Reviewed-by: darcy ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Short.java + test/java/lang/HashCode.java Changeset: eb92c939b8a7 Author: martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb92c939b8a7 6582946: Add suite of compare(T, T) methods for ints, longs etc Reviewed-by: darcy Contributed-by: kevinb at google.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Compare.java From daniel.daugherty at sun.com Tue Sep 22 23:19:03 2009 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Wed, 23 Sep 2009 06:19:03 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6876794: 4/4 sp07t002 hangs very intermittently Message-ID: <20090923061905.C9FE6127FC@hg.openjdk.java.net> Changeset: 87770dcf831b Author: dcubed Date: 2009-09-22 21:12 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/87770dcf831b 6876794: 4/4 sp07t002 hangs very intermittently Summary: remove over locking by VMThread on "is thread suspended?" check Reviewed-by: dholmes, acorn, andrew ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp From joe.darcy at sun.com Wed Sep 23 18:30:26 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 24 Sep 2009 01:30:26 +0000 Subject: hg: jdk7/tl/langtools: 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception; ... Message-ID: <20090924013028.87B1512856@hg.openjdk.java.net> Changeset: e992e602788e Author: darcy Date: 2009-09-23 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e992e602788e 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception 6517907: javax.lang.model.util.Elements.getConstantExpression() with negative byte value fails Summary: Fix various problems with Elements.getConstantExpression() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/Convert.java + test/tools/javac/processing/model/util/elements/Foo.java + test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java From jonathan.gibbons at sun.com Wed Sep 23 18:49:47 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 24 Sep 2009 01:49:47 +0000 Subject: hg: jdk7/tl/langtools: 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject.; ... Message-ID: <20090924014949.1C3811285D@hg.openjdk.java.net> Changeset: 49359d0e6a9c Author: jjg Date: 2009-09-23 18:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/49359d0e6a9c 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject. 6747645: ZipFileObject.getName is incorrectly deprecated 6885123: JavaFileObject getName issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java - src/share/classes/com/sun/tools/javac/file/Old199.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java ! src/share/classes/javax/tools/SimpleJavaFileObject.java + test/tools/javac/4241573/T4241573.java ! test/tools/javac/6589361/T6589361.java ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T6705935.java ! test/tools/javac/api/6411310/T6411310.java + test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/6733837/T6733837.java From jonathan.gibbons at sun.com Wed Sep 23 19:16:34 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 24 Sep 2009 02:16:34 +0000 Subject: hg: jdk7/tl/langtools: 6572945: javah should be written as an annotation processor, not a doclet Message-ID: <20090924021636.53D0D12862@hg.openjdk.java.net> Changeset: c287d51c57da Author: jjg Date: 2009-09-23 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c287d51c57da 6572945: javah should be written as an annotation processor, not a doclet Reviewed-by: darcy ! make/build.xml ! src/share/classes/com/sun/tools/javah/Gen.java + src/share/classes/com/sun/tools/javah/InternalError.java ! src/share/classes/com/sun/tools/javah/JNI.java + src/share/classes/com/sun/tools/javah/JavahFileManager.java + src/share/classes/com/sun/tools/javah/JavahTask.java + src/share/classes/com/sun/tools/javah/JavahTool.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Main.java - src/share/classes/com/sun/tools/javah/MainDoclet.java ! src/share/classes/com/sun/tools/javah/Mangle.java + src/share/classes/com/sun/tools/javah/NativeHeaderTool.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/Util.java - src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties - src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties ! src/share/classes/com/sun/tools/javah/resources/l10n.properties - src/share/classes/com/sun/tools/javah/resources/win32_x86.properties ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java + test/tools/javah/6572945/T6572945.java + test/tools/javah/6572945/TestClass1.java + test/tools/javah/6572945/TestClass2.java + test/tools/javah/6572945/TestClass3.java + test/tools/javah/6572945/gold/jni.dir.1/TestClass1.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner1.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner2.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass2.h + test/tools/javah/6572945/gold/jni.file.1 + test/tools/javah/6572945/gold/jni.file.2 + test/tools/javah/6572945/gold/jni.file.3 ! test/tools/javah/MissingParamClassTest.sh + test/tools/javah/compareTest/CompareTest.java + test/tools/javah/compareTest/CompareTest.sh + test/tools/javah/compareTest/FindNativeFiles.java + test/tools/javah/compareTest/README From weijun.wang at sun.com Thu Sep 24 06:38:25 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Thu, 24 Sep 2009 13:38:25 +0000 Subject: hg: jdk7/tl/jdk: 6885166: regression test for 6877357 (IPv6 address does not work) error (timed out) Message-ID: <20090924133901.793EC12878@hg.openjdk.java.net> Changeset: bd928aefe692 Author: weijun Date: 2009-09-24 21:35 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bd928aefe692 6885166: regression test for 6877357 (IPv6 address does not work) error (timed out) Reviewed-by: xuelei ! test/sun/security/krb5/IPv6.java From joe.darcy at sun.com Thu Sep 24 15:59:21 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 24 Sep 2009 22:59:21 +0000 Subject: hg: jdk7/tl/langtools: 6337964: should ignore last comma in annotation array Message-ID: <20090924225924.367B1128BB@hg.openjdk.java.net> Changeset: d0f541480556 Author: darcy Date: 2009-09-24 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0f541480556 6337964: should ignore last comma in annotation array Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/annotations/pos/TrailingComma.java From xiaobin.lu at sun.com Thu Sep 24 17:22:22 2009 From: xiaobin.lu at sun.com (xiaobin.lu at sun.com) Date: Fri, 25 Sep 2009 00:22:22 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6880029: JDK 1.6.0_u14p Application crashed very early Message-ID: <20090925002229.A4244128C4@hg.openjdk.java.net> Changeset: 528d98fe1037 Author: xlu Date: 2009-09-24 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/528d98fe1037 6880029: JDK 1.6.0_u14p Application crashed very early Reviewed-by: never, ysr, acorn ! src/share/vm/runtime/safepoint.cpp From tim.bell at sun.com Sat Sep 26 10:02:51 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:02:51 +0000 Subject: hg: jdk7/tl: 5 new changesets Message-ID: <20090926170251.6D485129C0@hg.openjdk.java.net> Changeset: e76b72562a98 Author: ohair Date: 2009-09-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/e76b72562a98 6855174: Improve log output when builds transition from one workspace to another Reviewed-by: jjg ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/jdk-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 931f7f7501da Author: ohair Date: 2009-09-17 13:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/931f7f7501da Merge Changeset: 76f6380ac0b4 Author: xdono Date: 2009-09-18 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/76f6380ac0b4 Merge Changeset: d70b157f6407 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d70b157f6407 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! make/corba-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 3ac6dcf78232 Author: robilad Date: 2009-09-23 20:06 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/rev/3ac6dcf78232 6872735: Further update build readme for new platforms 6641691: Bring build readme's up-to-date Summary: Added build instructions for Debian, Ubuntu 8.04, 8.10, 9.04, Fedora 10, 11, OpenSolaris 2009.06, OpenSUSE and Mandriva Reviewed-by: ohair, andrew ! README-builds.html From tim.bell at sun.com Sat Sep 26 10:03:27 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:03:27 +0000 Subject: hg: jdk7/tl/corba: 6 new changesets Message-ID: <20090926170332.B0A93129C5@hg.openjdk.java.net> Changeset: 1c130e7b7a2e Author: ohair Date: 2009-09-02 09:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/1c130e7b7a2e 6875240: Reduce Makefile build time by limiting repeated exec's (mostly for cygwin building) Reviewed-by: jjg, iris ! make/Makefile ! make/common/BuildToolJar.gmk ! make/common/CancelImplicits.gmk ! make/common/Defs.gmk ! make/common/Rules.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Platform.gmk ! make/jprt.properties Changeset: 085333867e39 Author: xdono Date: 2009-09-14 10:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/085333867e39 Merge Changeset: 546970b224ca Author: xdono Date: 2009-09-18 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/546970b224ca Merge Changeset: 31ce3cac3cc1 Author: ohair Date: 2009-09-18 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/31ce3cac3cc1 6883790: corba build problem related to wildcard and vpath, regression Reviewed-by: tbell ! make/common/Rules.gmk Changeset: 2aa5665d86a5 Author: ohair Date: 2009-09-18 17:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/2aa5665d86a5 6883816: corba fix for missing javax/transaction/xa classes (the real fix) Reviewed-by: tbell ! make/common/Rules.gmk Changeset: b751c528c555 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/b751c528c555 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! make/common/CancelImplicits.gmk From tim.bell at sun.com Sat Sep 26 10:04:11 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:04:11 +0000 Subject: hg: jdk7/tl/hotspot: 6884624: Update copyright year Message-ID: <20090926170417.C8DE0129CA@hg.openjdk.java.net> Changeset: 89e0543e1737 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/89e0543e1737 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/os/solaris/proc/Makefile ! agent/src/os/solaris/proc/mapfile ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeChunk.java ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/os_cpu/solaris_x86/vm/atomic_solaris_x86.inline.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/code/debugInfoRec.hpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/compiler/oopMap.hpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/serialize.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/perfData.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/vframe_hp.hpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp From tim.bell at sun.com Sat Sep 26 10:04:59 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:04:59 +0000 Subject: hg: jdk7/tl/jaxp: 3 new changesets Message-ID: <20090926170504.82C27129CF@hg.openjdk.java.net> Changeset: 534e23823a1b Author: ohair Date: 2009-09-21 13:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/534e23823a1b 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties + build.xml + jaxp.properties ! make/Makefile - make/build.properties - make/build.xml ! make/jprt.properties - make/tools/StripProperties/StripProperties.java - make/tools/StripProperties/StripPropertiesTask.java + nbproject/findbugs.settings + nbproject/project.xml + nbproject/sqe.properties + patches/jaxp_src/README Changeset: 0748962aa825 Author: ohair Date: 2009-09-21 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/0748962aa825 6884220: Have drop sources ignore the output.dir property Reviewed-by: xdono ! build.properties Changeset: ee9c7578aca5 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/ee9c7578aca5 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java From tim.bell at sun.com Sat Sep 26 10:05:41 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:05:41 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20090926170544.D63A2129D4@hg.openjdk.java.net> Changeset: ae2bec597586 Author: ohair Date: 2009-09-21 13:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/ae2bec597586 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties + build.xml + jaxws.properties ! make/Makefile - make/build.properties - make/build.xml ! make/jprt.properties - make/tools/StripProperties/StripProperties.java - make/tools/StripProperties/StripPropertiesTask.java + nbproject/findbugs.settings + nbproject/project.xml + nbproject/sqe.properties + patches/jaxws_src/README Changeset: 77708e68db52 Author: ohair Date: 2009-09-21 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/77708e68db52 6884220: Have drop sources ignore the output.dir property Reviewed-by: xdono ! build.properties From tim.bell at sun.com Sat Sep 26 10:07:21 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 26 Sep 2009 17:07:21 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20090926170729.882AB129DB@hg.openjdk.java.net> Changeset: 14735c7932d7 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14735c7932d7 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testCRLineSeparator/pkg/MyClass.java ! test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/tools/apt/Basics/apt.sh ! test/tools/apt/Basics/print.sh ! test/tools/apt/Compile/compile.sh ! test/tools/javac/4846262/Test.sh ! test/tools/javac/6302184/T6302184.sh ! test/tools/javac/6627362/T6627362.java ! test/tools/javac/ClassPathTest/ClassPathTest.sh ! test/tools/javac/ExtDirs/ExtDirs.sh ! test/tools/javac/MissingInclude.sh ! test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh ! test/tools/javac/T5090006/compiler.sh ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/Sibling.java ! test/tools/javac/code/ArrayClone.java ! test/tools/javac/constDebug/ConstDebug.sh ! test/tools/javac/fatalErrors/NoJavaLang.sh ! test/tools/javac/generics/inference/6302954/T6476073.java ! test/tools/javac/innerClassFile/Driver.sh ! test/tools/javac/javazip/Test.sh ! test/tools/javac/meth/MakeNegTests.sh ! test/tools/javac/newlines/Newlines.sh ! test/tools/javac/quid/MakeNegTests.sh ! test/tools/javac/quid/QuotedIdent.java ! test/tools/javac/quid/QuotedIdent2.java ! test/tools/javac/stackmap/T4955930.sh ! test/tools/javac/unicode/SupplementaryJavaID6.sh ! test/tools/javah/6257087/foo.sh ! test/tools/javah/ConstMacroTest.sh ! test/tools/javah/MissingParamClassTest.sh ! test/tools/javah/ReadOldClass.sh ! test/tools/javap/T4975569.java ! test/tools/javap/pathsep.sh ! test/tools/javap/stackmap/T6271292.sh Changeset: 9596dff46093 Author: tbell Date: 2009-09-25 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9596dff46093 Merge Changeset: 4776a869fdfa Author: tbell Date: 2009-09-25 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4776a869fdfa Merge ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java - src/share/classes/com/sun/tools/javac/file/Old199.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java - src/share/classes/com/sun/tools/javah/MainDoclet.java - src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties - src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties - src/share/classes/com/sun/tools/javah/resources/win32_x86.properties ! test/tools/javah/MissingParamClassTest.sh From karen.kinnear at sun.com Mon Sep 28 14:25:15 2009 From: karen.kinnear at sun.com (karen.kinnear at sun.com) Date: Mon, 28 Sep 2009 21:25:15 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 3 new changesets Message-ID: <20090928212526.96BB312A0E@hg.openjdk.java.net> Changeset: c3c4a1d3801a Author: andrew Date: 2009-09-23 11:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c3c4a1d3801a 6884552: remove some unnecessary #ifdef's introduced in the fix for 4957990 Summary: Removed the unnecessary #ifdef's which were interfering with the build of the Zero-assembler port Reviewed-by: ysr, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp Changeset: 1af62b6ca0f9 Author: apetrusenko Date: 2009-09-25 04:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1af62b6ca0f9 Merge Changeset: 054afbef9081 Author: acorn Date: 2009-09-28 12:27 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/054afbef9081 Merge From jonathan.gibbons at sun.com Mon Sep 28 16:50:50 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 28 Sep 2009 23:50:50 +0000 Subject: hg: jdk7/tl/langtools: 6886348: apt incorrectly uses Scope.table Message-ID: <20090928235055.B343712A1B@hg.openjdk.java.net> Changeset: c6d0c55b1aba Author: jjg Date: 2009-09-28 16:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c6d0c55b1aba 6886348: apt incorrectly uses Scope.table Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/comp/Apt.java From ptisnovs at redhat.com Wed Sep 30 02:49:39 2009 From: ptisnovs at redhat.com (ptisnovs at redhat.com) Date: Wed, 30 Sep 2009 09:49:39 +0000 Subject: hg: jdk7/tl/jdk: 6884837: JTReg test SetOutgoingIf is not correct Message-ID: <20090930094959.2F52441574@hg.openjdk.java.net> Changeset: 5b1aaf2d7504 Author: ptisnovs Date: 2009-09-30 11:49 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5b1aaf2d7504 6884837: JTReg test SetOutgoingIf is not correct Summary: Added check of network interfaces status Reviewed-by: alanb, chegar ! test/java/net/MulticastSocket/SetOutgoingIf.java