Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException

[Andrew John Hughes]

2009/9/3 Alan Bateman <Alan.Bateman at sun.com>:
> Sorry for the delay getting back to this one. I've updated the webrev to
> address the comments, except for snprintf. The reason is that snprintf isn't
> in the Windows CRT. We usually use jio_snprintf (implemented on vsnprintf or
> _vsnprintf on Windows) but this is a transport library for the debugger
> agent and so isn't linked against the VM. We could extend its transport
> platform dependent code to add a function for this, but it hardly seems
> worth it for this one case.
>
>  http://cr.openjdk.java.net/~alanb/6432567/webrev.00/
>
> Thanks,
> Alan.
>

Isn't there some way to test for snprintf and use it on platforms that
aren't broken?  It seems a bad idea to leave a potential security hole
open for the sake of one legacy platform.  snprintf is part of C99
according to its manpage, so it should be available on all compilers
that implement this standard.

This is one reason why it would be better if OpenJDK used autoconf; it
has a test for this exact issue, but sadly that needs to be run prior
to the build.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8