Request Review: 6902182: Starting with jdwp agent should not incur performance penalty

[Tom Rodriguez]

Some of the renames in ciEnv.?pp messed up alignment.  Could you fix that?  Otherwise it looks ok.

tom

On Jan 12, 2010, at 8:24 AM, Deneau, Tom wrote:

> Dan has given his OK for the jvmti-related changes, could someone from the compiler side
> look over the final webrev as well?  As mentioned previously, not much has really changed
> on the compiler side from the earlier webrev.
> 
> http://cr.openjdk.java.net/~tdeneau/6902182/webrev.05
> 
> -- Tom
> 
> -----Original Message-----
> From: Daniel.Daugherty at Sun.COM [mailto:Daniel.Daugherty at Sun.COM] 
> Sent: Friday, January 08, 2010 7:37 PM
> To: Deneau, Tom
> Cc: serviceability-dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
> Subject: Re: Request Review: 6902182: Starting with jdwp agent should not incur performance penalty
> 
> Thumbs up from me!
> 
> Dan
> 
> 
> Deneau, Tom wrote:
>> Cross posting to hotspot-compiler-dev at openjdk.java.net and
>> serviceability-dev at openjdk.java.net since this review request touches
>> both compiler/runtime code and JVMTI code...
>> 
>> New webrev is at http://cr.openjdk.java.net/~tdeneau/6902182/webrev.05
>> 
>> This webrev addresses the comments made by Dan Daugherty in 
>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2010-January/002450.html
>> 
>> This webrev includes the name change from
>> jvmti_can_post_exceptions() to jvmti_can_post_on_exceptions()
>> 
>> New files that were not in previous webrevs:
>>   * jvmtiThreadState.hpp, 
>>        JvmtiEventControllerPrivate::recompute_thread_enabled() now calls a routine
>>        in here rather than in JavaThread directly
>> 
>>   * All other new files are due to the name change from
>>     jvmti_can_post_exceptions() to jvmti_can_post_on_exceptions()
>> 
>> -- Tom Deneau
>> 
>> 
>> 
> 
>