Review request: Add new jstat -classload option
Mandy Chung
mandy.chung at oracle.com
Thu Jun 10 13:11:46 PDT 2010
Alan,
Here is the revised webrev:
http://cr.openjdk.java.net/~mchung/6959965/webrev.01/
Thanks
Mandy
On 06/10/10 08:33, Mandy Chung wrote:
> Alan Bateman wrote:
>> Mandy Chung wrote:
>>> Fixed 6959965: jstat: Add new -classload option to print class
>>> loading statistics
>>>
>>> I added several new perf counters for collecting class loading
>>> related metrics some time ago (6857194). This fix updates jstat to
>>> print these new statistics (I finally got time to do this).
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~mchung/6959965/webrev.00/
>>>
>>> I added this -classload as an internal option for now.
>>>
>>> Mandy
>> I went through the webrev.
>>
>> Do you plan to make this a "standard" option at some point? If so
>> then maybe it would be best to do that now and save introducing a
>> second file of options.
>
> I expect we may add new class loading metrics in jdk 7 to support
> modules. I think it's better to wait and make this a supported option
> later.
>
>> Related to this is terminology and I wonder if "unsupported" would be
>> better than "internal" given that the the jstat.showUnsupported
>> property needs to be set to enable this option.
>>
> I can rename it.
>> Minor comment is that the "findClass" and "defineClass" headers have
>> the first character in lower case whereas all other headers (I think)
>> uses capital. Another minor comment is that
>> OptionFinder.optionsSources and OptionLister.sources can be final.
>>
> Ok. Will clean that up.
>> Do you plan to add a test to test/sun/tools/jstate for this option?
>>
>
> I am adding a new test. Thanks for the review.
>
> Mandy
>
More information about the serviceability-dev
mailing list